From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C31BC433DF for ; Mon, 1 Jun 2020 22:19:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDFAD2073B for ; Mon, 1 Jun 2020 22:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CbAFNhKA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDFAD2073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfsmR-0002bF-1q for qemu-devel@archiver.kernel.org; Mon, 01 Jun 2020 18:19:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfslL-00023J-Do for qemu-devel@nongnu.org; Mon, 01 Jun 2020 18:18:31 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:43247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfslJ-0007kw-DH for qemu-devel@nongnu.org; Mon, 01 Jun 2020 18:18:30 -0400 Received: by mail-pl1-x642.google.com with SMTP id g12so485287pll.10 for ; Mon, 01 Jun 2020 15:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=An14sIGzSpbFgWG0PXrY9PWzJT6fDYxa7R5qY1qFmgM=; b=CbAFNhKAMnCehCjUksLZifmll7TrGyL2dDrV0oJud1cArwknzWnW0L/O8VX8OLKXp1 ruCwxRKf8r6fLh9aJGUi4CoOM8893gOtJ3Xy1+MIyxEv5wmPdGvsYlakdqllzNIwT6c8 Gy4lVRRGO8yjNpHu0O9DKAqY2IzpTbtNFqGa5to81Apgadbw5p4RfOHa7eoH//SX14uy 5GxuYXZvYM+tpzdm3vCSfO9Ejd42QMSIdlUn8kFNkUNNl5HOatbHBWh+Aotwv2CQeq5c JK2Ke3/r4aSLhx9knCd8BJ3OMVqHQoDAURJ9NPCV7Xu3ITCahVlUqmmap5Rm8SLWrjOY uZxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=An14sIGzSpbFgWG0PXrY9PWzJT6fDYxa7R5qY1qFmgM=; b=WL9Yhkn0vxKveQGCTg/wdjD62a3dnJQYZRLfFDH5Fkz9SnF/bL5Ac1TTL8ib4F0Gh4 oEsYvW+/idQvGQPTLTqRI+vg59btpsVFWQzwAjot4zv5q+Bh8Cj4zd4F989man1SKEBp xYYqAk7hUT4n6m5hlK4UA7zV4VRWB4Sd4QBispPrqHQLpzKvPmCdN3TbS/d4j+4Ptb3X 3j9oxcLjcBHRUbjXQqphpgaPdRIpAIXIhkIfkWKRyY5cqF2AyY1yIhEEwTfYL7Zp/cyo IFmHyFQt46tb88U6yYDbw5YKUQ9z0b3f3X5uoDuaw6DbKgSHMNspjVkdGWim+eqMZ7sb b2dg== X-Gm-Message-State: AOAM533DTRxopYeL9GqCUdpq5JVgGnYm3pAuIgm82X4uookGFbmt2is7 X3h/GJ2fBiQ/N1Wg2paPSVEYt6KhXRo= X-Google-Smtp-Source: ABdhPJx/5fpwa4t4JmizbLvhi+zwEPz6YUHliNUm7Rn+8oatSOKHovKKNXSImrh24Y9+jVAEd3DDIQ== X-Received: by 2002:a17:902:b18b:: with SMTP id s11mr21432520plr.160.1591049903691; Mon, 01 Jun 2020 15:18:23 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id s75sm406795pgc.13.2020.06.01.15.18.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 15:18:23 -0700 (PDT) Subject: Re: [PATCH] target/m68k: implement opcode fetoxm1 To: Laurent Vivier , qemu-devel@nongnu.org References: <20200531131951.631902-1-laurent@vivier.eu> From: Richard Henderson Message-ID: <968951a6-0f27-9cce-8a06-75b5be3a2ad9@linaro.org> Date: Mon, 1 Jun 2020 15:18:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200531131951.631902-1-laurent@vivier.eu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::642; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x642.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/31/20 6:19 AM, Laurent Vivier wrote: > Example provided in the launchpad bug fails with: > > qemu: uncaught target signal 4 (Illegal instruction) - core dumped > Illegal instruction (core dumped) > > It appears fetoxm1 is not implemented: > > IN: expm1f > 0x800005cc: fetoxm1x %fp2,%fp0 > Disassembler disagrees with translator over instruction decoding > Please report this to qemu-devel@nongnu.org > > (gdb) x/2hx 0x800005cc > 0x800005cc: 0xf200 0x0808 > > This patch adds the instruction. > > Bug: https://bugs.launchpad.net/qemu/+bug/1881450 > Signed-off-by: Laurent Vivier > --- > target/m68k/helper.h | 1 + > target/m68k/fpu_helper.c | 5 +++++ > target/m68k/translate.c | 3 +++ > 3 files changed, 9 insertions(+) Reviewed-by: Richard Henderson r~