From: Marek Vasut <marex@denx.de>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel <openembedded-devel@lists.openembedded.org>,
Khem Raj <raj.khem@gmail.com>
Subject: Re: [oe] [meta-oe][PATCH] apitrace: Conditionally enable X11 support
Date: Fri, 15 Oct 2021 01:41:31 +0200 [thread overview]
Message-ID: <9698672a-edb9-f66a-ba8e-e4355829f4fe@denx.de> (raw)
In-Reply-To: <CA+chaQcH9R06Q4N5z021=dTdAKT35MgVKgcOP_U60smu6L=7wA@mail.gmail.com>
On 10/14/21 11:32 PM, Martin Jansa wrote:
> Why not use PACKAGECONFIG for this? It won't set the EXTRA_OECMAKE
> automatically, but will handle the depends correctly (and will be easy to
> switch of if someone with x1 and opengl in DISTRO_FEATURES still doesn't
> wan to have X11 enabled here for whatever reason).
>
> On Fri, Oct 15, 2021 at 12:41 AM Marek Vasut <marex@denx.de> wrote:
>
>> In case DISTRO_FEATURES contain both x11 and opengl, enable X11 support
>> in apitrace, because all the requirements are satisfied.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta-oe/recipes-devtools/apitrace/apitrace_10.0.bb | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-devtools/apitrace/apitrace_10.0.bb
>> b/meta-oe/recipes-devtools/apitrace/apitrace_10.0.bb
>> index 57ec1f8e0..f097f78a9 100644
>> --- a/meta-oe/recipes-devtools/apitrace/apitrace_10.0.bb
>> +++ b/meta-oe/recipes-devtools/apitrace/apitrace_10.0.bb
>> @@ -13,12 +13,13 @@ SRC_URI = "gitsm://github.com/${BPN}/${BPN}.git
>> <http://github.com/$%7BBPN%7D/$%7BBPN%7D.git> \
>> S = "${WORKDIR}/git"
>>
>> DEPENDS += "zlib libpng python3-native"
>> +DEPENDS += " ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl',
>> 'libx11', '', d)} "
>>
>> inherit cmake
>>
>> EXTRA_OECMAKE += "\
>> -DENABLE_GUI=OFF \
>> - -DENABLE_X11=OFF \
>> + ${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl',
>> '-DENABLE_X11=ON', '-DENABLE_X11=OFF', d)} \
>> -DENABLE_STATIC_LIBGCC=OFF \
>> -DENABLE_STATIC_LIBSTDCXX=OFF \
>> -DPython3_ROOT_DIR=/usr/bin/python3-native \
>> --
>> 2.33.0
I would expect that someone who uses apitrace and enables x11 would also
want that tracing functionality in by default, which can be handled by
default packageconfig , sure. It felt like adding packageconfig with
this x11 enabled by default in there (if DISTRO_FEATURES contain opengl
and x11) would add extra complexity for little actual gain.
prev parent reply other threads:[~2021-10-14 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 22:41 [meta-oe][PATCH] apitrace: Conditionally enable X11 support Marek Vasut
2021-10-14 21:32 ` [oe] " Martin Jansa
2021-10-14 23:41 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9698672a-edb9-f66a-ba8e-e4355829f4fe@denx.de \
--to=marex@denx.de \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.