git lfs support

git lfs support

[jon.richardson]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hi,

I added lfs=1 to my SRC_URI that uses a git repo. I see code for supporting lfs, but I don't see a git-lfs checkout being called. Does yocto not support lfs? I'll have to had a postfunc to do the git-lfs fetch otherwise the files aren't checkout out properly. What is the purpose of lfs=1 in SRC_URI? It even checks for the existence of git-lfs yet doesn't use it anywhere that I can see.

I'm using dunfell (52b59e884110b2d48ad83438eef1fed7a28f01cf).

Thanks.

[-- Attachment #2: Type: text/html, Size: 1501 bytes --]

Re: [poky] git lfs support

[Richard Purdie]

On Wed, 2022-03-23 at 00:54 +0000, Jon Richardson wrote:
> Hi,
> 
> I added lfs=1 to my SRC_URI that uses a git repo. I see code for supporting lfs,
> but I don't see a git-lfs checkout being called. Does yocto not support lfs?
> I'll have to had a postfunc to do the git-lfs fetch otherwise the files aren't
> checkout out properly. What is the purpose of lfs=1 in SRC_URI? It even checks
> for the existence of git-lfs yet doesn't use it anywhere that I can see. 
> 
> I'm using dunfell (52b59e884110b2d48ad83438eef1fed7a28f01cf).

This could be a bug in dunfell, does:

https://git.yoctoproject.org/poky/commit/?id=45c02843d181b5f1872ad30f4d847c395233a676

help fix the issue?

Cheers,

Richard

Re: [poky] git lfs support

[Steve Sakoman]

On Wed, Mar 23, 2022 at 1:00 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2022-03-23 at 00:54 +0000, Jon Richardson wrote:
> > Hi,
> >
> > I added lfs=1 to my SRC_URI that uses a git repo. I see code for supporting lfs,
> > but I don't see a git-lfs checkout being called. Does yocto not support lfs?
> > I'll have to had a postfunc to do the git-lfs fetch otherwise the files aren't
> > checkout out properly. What is the purpose of lfs=1 in SRC_URI? It even checks
> > for the existence of git-lfs yet doesn't use it anywhere that I can see.
> >
> > I'm using dunfell (52b59e884110b2d48ad83438eef1fed7a28f01cf).
>
> This could be a bug in dunfell, does:
>
> https://git.yoctoproject.org/poky/commit/?id=45c02843d181b5f1872ad30f4d847c395233a676
>
> help fix the issue?

The above commit is already in dunfell:

https://git.yoctoproject.org/poky/commit/bitbake/lib/bb/fetch2/git.py?h=dunfell&id=977b7268bf4fd425cb86d4a57500350c9b829162

As well as a follow-on patch to fix an issue with the above patch:

https://git.yoctoproject.org/poky/commit/bitbake/lib/bb/fetch2/git.py?h=dunfell&id=34597b96d94cd4d7aae38c394181df7bebec4171

Steve

Re: [poky] git lfs support

[Richard Purdie]

On Wed, 2022-03-23 at 05:09 -1000, Steve Sakoman wrote:
> On Wed, Mar 23, 2022 at 1:00 AM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > 
> > On Wed, 2022-03-23 at 00:54 +0000, Jon Richardson wrote:
> > > Hi,
> > > 
> > > I added lfs=1 to my SRC_URI that uses a git repo. I see code for supporting lfs,
> > > but I don't see a git-lfs checkout being called. Does yocto not support lfs?
> > > I'll have to had a postfunc to do the git-lfs fetch otherwise the files aren't
> > > checkout out properly. What is the purpose of lfs=1 in SRC_URI? It even checks
> > > for the existence of git-lfs yet doesn't use it anywhere that I can see.
> > > 
> > > I'm using dunfell (52b59e884110b2d48ad83438eef1fed7a28f01cf).
> > 
> > This could be a bug in dunfell, does:
> > 
> > https://git.yoctoproject.org/poky/commit/?id=45c02843d181b5f1872ad30f4d847c395233a676
> > 
> > help fix the issue?
> 
> The above commit is already in dunfell:
> 
> https://git.yoctoproject.org/poky/commit/bitbake/lib/bb/fetch2/git.py?h=dunfell&id=977b7268bf4fd425cb86d4a57500350c9b829162
> 
> As well as a follow-on patch to fix an issue with the above patch:
> 
> https://git.yoctoproject.org/poky/commit/bitbake/lib/bb/fetch2/git.py?h=dunfell&id=34597b96d94cd4d7aae38c394181df7bebec4171

Sorry Steve, for some reason I thought they were missing.

In that case the lfs parameter in the SRC_URI should work. Note that the
checkout would happen in do_unpack as the files are moved to the workdir, not in
do_fetch.

Jon: As you can see, there is code there to do this so I'm not sure what is
wrong I'm afraid. We do even have tests in lib/bb/tests/fetch.py to test lfs is
working...

Cheers,

Richard