From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8BA3C433FE for ; Tue, 21 Sep 2021 07:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0DAF611C7 for ; Tue, 21 Sep 2021 07:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbhIUHY0 (ORCPT ); Tue, 21 Sep 2021 03:24:26 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:60850 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbhIUHY0 (ORCPT ); Tue, 21 Sep 2021 03:24:26 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 81DD53F4B9 for ; Tue, 21 Sep 2021 07:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632208977; bh=Cve5VR1QaxZM6zIVHTuhZn6XwrsbWxHHOPyFzizDJOw=; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=LSaX+NNYmtKaMHZc+jMNh4LhvdiDlQ/00FmmBttIsHz4Y/Ako8b9QQh4eIfUxOrlw B4fh/vPlUzc5UA4G0DVRJrFMFaU9QCoWksfkw2/h+4eOFpbgHWCEEibf79nql9343W YbbTUv+h6kKTYCc2YLD4852GuwHKUI6FvvGQ5KPbeOEwIgYNvi4hmRcej5yvPqDxx6 s+2RXlcO+NfK/QOa6+ZboKadWRppvDdB6pYxptW7Qz4iYfjdrbV+A1dzrK/zxlbP8R F+gE7NkWY3oXyYlrCI2kRxib6iyqi+mkHY+SvLj+FxPzky9BwaUPo7Nsj+OgbrHal6 vS2kBkdSsG9uw== Received: by mail-wr1-f69.google.com with SMTP id m1-20020a056000180100b0015e1ec30ac3so8039731wrh.8 for ; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cve5VR1QaxZM6zIVHTuhZn6XwrsbWxHHOPyFzizDJOw=; b=bW3G0n+5U6bK64y6HtzokCuf/jSo/cbFsDFjDLw/XJuQ4/ProQXfCqTRT/+ooJfm4j odJeRmNklZy6utAXSotMGzsSXZIwXStPeKEITbm7qJV+hFq+QhhcAgvovi4pAIO4YMgB EIqsYxeRckcn0f7q7tsWxie9enUSXO4Hf7vPxjgqXpR9Sb3lWG5/ZVIDhWMpRxvr+R4l mE+SBF1+JImxFufnGFMCGNTTBlLPU/FE7EjxZsx0raNo4HmEm6iaHrX3chg1VGYVZfF2 57eUJXz7QRywXl/o78XVzIrgcEOnl0Mzq9XJINN+FOrMgBB5XEIm/RKIVocNMBmvMmBV Klsw== X-Gm-Message-State: AOAM5303ffpc7pDUMcxz2aattdJ1w8XrHWhp4sAKrCHoOeWmO6tddIzV TUL3plL+QU+84E56YmUaJa3ryYNZfiDspC2T/BP5zZzh3aVz5V2vQwkPqXx33j8wm9BRbeE9c6o gR/gfJ40C6ySmHabfW0rMaOmy3zmyWIQ7XRmoPGE= X-Received: by 2002:adf:dcc1:: with SMTP id x1mr33377409wrm.415.1632208977226; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQw4dtnG2X2Nu2HkIk4oUuLyQI/VIi+qePjIbZ3WhkVu2uRQwXc5Ujx3o3WSA5Z6k2UAzRxA== X-Received: by 2002:adf:dcc1:: with SMTP id x1mr33377384wrm.415.1632208977082; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id r9sm10592653wru.2.2021.09.21.00.22.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:22:56 -0700 (PDT) Subject: Re: [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs From: Krzysztof Kozlowski To: Will McVicker , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Alessandro Zummo , Alexandre Belloni Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <7735b09c-cf1c-5e37-a737-9a330fbacf1e@canonical.com> Message-ID: <96e7f057-c505-e5d7-d89a-345b98d44448@canonical.com> Date: Tue, 21 Sep 2021 09:22:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <7735b09c-cf1c-5e37-a737-9a330fbacf1e@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 21/09/2021 09:19, Krzysztof Kozlowski wrote: > On 20/09/2021 21:03, Will McVicker wrote: >> This patch series tries to address the issue of ARCH_EXYNOS force selecting >> a handful of drivers without allowing the vendor to override any of the >> default configs. This takes away from the flexibilty of compiling a generic >> kernel with exynos kernel modules. For example, it doesn't allow vendors to >> modularize these drivers out of the core kernel in order to share a generic >> kernel image across multiple devices that require device-specific kernel >> modules. > > You do not address the issue in these patches. The problem you describe > is that drivers are not modules and you are not changing them into modules. > >> >> To address this without impacting the existing behavior, this series >> switches the default config logic for the offending configs to use "default >> y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select them. I have >> verified that these patches do not impact the default aarch64 .config. > > Yep, this is what you did but it does not match the described problem. > You are not solving it but doing something else. > >> >> Will McVicker (4): >> clk: samsung: change COMMON_CLK_SAMSUNG default config logic >> soc: samsung: change SOC_SAMSUNG default config logic >> pinctrl: samsung: change PINCTRL_EXYNOS default config logic >> rtc: change HAVE_S3C_RTC default config logic >> > > > I received only two patches from this set. Please resend following > get_maintainers.pl script. For the record - samsung-soc list also did not get all your patches. NAK, please use get_maintainers.pl. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39C6C433EF for ; Tue, 21 Sep 2021 07:24:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93F1D61100 for ; Tue, 21 Sep 2021 07:24:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 93F1D61100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:Cc:To:From:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=g8XVCqwxvgD1uX1tcIy9IjnpubCE4fhn0LuUUEQeJ0Y=; b=gx/tgj0HOPLGoDK8XCxVRts7EU XIkyu4A9s+iO5dTk7vkMECgdC2fwDjyxCqOLtXJXEj+8GqjefSTknZClYM4Jk1nlngPywddsLxmKX W6KuwmV5fIsa64UNi65IYIOL2F1eT4TlnP1kEln/f7gVbyeW8PiIzZalnn9xYpNSxraZOf7Dn5e3e vrBHTu2Vkee1+TzK3PWaDxo4aNPnZsFuOhZ0fnn7t0cuBL3CsPcfzXRdFoANAhiQJrxcoKsNbWECV w2qbHtvMkytjVoyu6RoL/kKRmuUcQznx+D8Jz5mH8vxF1DEYaYangKNGUJgpJYvCb3tqPLsiporBD zsQqRrOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSa7L-003mi2-TJ; Tue, 21 Sep 2021 07:23:04 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSa7H-003mgE-SF for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 07:23:01 +0000 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A5A743FE05 for ; Tue, 21 Sep 2021 07:22:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632208977; bh=Cve5VR1QaxZM6zIVHTuhZn6XwrsbWxHHOPyFzizDJOw=; h=Subject:From:To:Cc:References:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=LSaX+NNYmtKaMHZc+jMNh4LhvdiDlQ/00FmmBttIsHz4Y/Ako8b9QQh4eIfUxOrlw B4fh/vPlUzc5UA4G0DVRJrFMFaU9QCoWksfkw2/h+4eOFpbgHWCEEibf79nql9343W YbbTUv+h6kKTYCc2YLD4852GuwHKUI6FvvGQ5KPbeOEwIgYNvi4hmRcej5yvPqDxx6 s+2RXlcO+NfK/QOa6+ZboKadWRppvDdB6pYxptW7Qz4iYfjdrbV+A1dzrK/zxlbP8R F+gE7NkWY3oXyYlrCI2kRxib6iyqi+mkHY+SvLj+FxPzky9BwaUPo7Nsj+OgbrHal6 vS2kBkdSsG9uw== Received: by mail-wr1-f72.google.com with SMTP id c2-20020adfa302000000b0015e4260febdso6711469wrb.20 for ; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Cve5VR1QaxZM6zIVHTuhZn6XwrsbWxHHOPyFzizDJOw=; b=OYI2KIRoeNidYbMvdkTytO+DnJ29YYFeNa/O067KbZHIz2T9DFaHPoUjhzyZ+j/uW8 bBouK4EgyRSlVsgDuiTBGN88yNgiJa9sHWLPV2uenZYLaT1f4A8OsugR0kOuUjwp+/qN 9oyFq1uXLnE89lrsEOlSRCO8uEba91GZy55bO4w3uwqEvxXSNowcoF031U2lUEset4K9 hkPPCJf3N8sSlvja5fIQxdmaP3rCmcTGBZtgvFOyqIJf9W9ilwL7PpZKu0yBBMc6GhgC 3JETI8MrSnV6kqvzjRG+N4pIAI/3SbSkj23mKwR3yZ1P8SYnQ4QbKpen4+lokA+TaTJJ pu7w== X-Gm-Message-State: AOAM533OEUVKmk3NwCCK43v7AIxcMol9ROcSEPfBZD/H1Rak8NxBpAAS srSUNzPMr7Em8zkKs6IQB1tJhZfSMW11NbORfBqAXMFTooj1ui8JuiFdKZKrlirI/bFjkZs1yln 6y9BR+vpJYW8900ubmYdWSIX+TFayJctQR7sbt6ENEpsTHtAroKvC X-Received: by 2002:adf:dcc1:: with SMTP id x1mr33377402wrm.415.1632208977225; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQw4dtnG2X2Nu2HkIk4oUuLyQI/VIi+qePjIbZ3WhkVu2uRQwXc5Ujx3o3WSA5Z6k2UAzRxA== X-Received: by 2002:adf:dcc1:: with SMTP id x1mr33377384wrm.415.1632208977082; Tue, 21 Sep 2021 00:22:57 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id r9sm10592653wru.2.2021.09.21.00.22.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:22:56 -0700 (PDT) Subject: Re: [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs From: Krzysztof Kozlowski To: Will McVicker , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Alessandro Zummo , Alexandre Belloni Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <7735b09c-cf1c-5e37-a737-9a330fbacf1e@canonical.com> Message-ID: <96e7f057-c505-e5d7-d89a-345b98d44448@canonical.com> Date: Tue, 21 Sep 2021 09:22:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <7735b09c-cf1c-5e37-a737-9a330fbacf1e@canonical.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_002300_119148_A6DBAFC9 X-CRM114-Status: GOOD ( 24.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/09/2021 09:19, Krzysztof Kozlowski wrote: > On 20/09/2021 21:03, Will McVicker wrote: >> This patch series tries to address the issue of ARCH_EXYNOS force selecting >> a handful of drivers without allowing the vendor to override any of the >> default configs. This takes away from the flexibilty of compiling a generic >> kernel with exynos kernel modules. For example, it doesn't allow vendors to >> modularize these drivers out of the core kernel in order to share a generic >> kernel image across multiple devices that require device-specific kernel >> modules. > > You do not address the issue in these patches. The problem you describe > is that drivers are not modules and you are not changing them into modules. > >> >> To address this without impacting the existing behavior, this series >> switches the default config logic for the offending configs to use "default >> y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select them. I have >> verified that these patches do not impact the default aarch64 .config. > > Yep, this is what you did but it does not match the described problem. > You are not solving it but doing something else. > >> >> Will McVicker (4): >> clk: samsung: change COMMON_CLK_SAMSUNG default config logic >> soc: samsung: change SOC_SAMSUNG default config logic >> pinctrl: samsung: change PINCTRL_EXYNOS default config logic >> rtc: change HAVE_S3C_RTC default config logic >> > > > I received only two patches from this set. Please resend following > get_maintainers.pl script. For the record - samsung-soc list also did not get all your patches. NAK, please use get_maintainers.pl. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel