From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 7 Dec 2017 09:26:48 +0100 Subject: [U-Boot] [PATCH 2/2] i2c: at91_i2c: remove the .probe_chip function In-Reply-To: <20171129032524.14431-3-alan@softiron.com> References: <20171129032524.14431-1-alan@softiron.com> <20171129032524.14431-3-alan@softiron.com> Message-ID: <96e88a86-f81a-ba4a-bf1d-32cfc614b8ff@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Alan, Am 29.11.2017 um 04:25 schrieb Alan Ott: > The .probe_chip function is supposed to probe an i2c device on the bus to > determine whether a device is answering to a particular address. > at91_i2c_probe_chip() did not do anything resembling this and always > returned 0. > > It looks as though at91_i2c_probe_chip() was intended to be a .probe > function for the controller, as it was copied-and-pasted to become > at91_i2c_probe() in 0bc8f640a4d7ed. > > Removing the at91_i2c_probe_chip() function makes the higher layer > (i2c_probe_chip()) try a zero-length read transfer to test for the > presence of a device instead, which does work. > > Signed-off-by: Alan Ott > --- > drivers/i2c/at91_i2c.c | 22 ---------------------- > 1 file changed, 22 deletions(-) Thanks! Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de