From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01845C433E0 for ; Mon, 11 Jan 2021 07:30:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C71E8227C3 for ; Mon, 11 Jan 2021 07:30:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727589AbhAKH3z (ORCPT ); Mon, 11 Jan 2021 02:29:55 -0500 Received: from foss.arm.com ([217.140.110.172]:48438 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725917AbhAKH3y (ORCPT ); Mon, 11 Jan 2021 02:29:54 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFB1131B; Sun, 10 Jan 2021 23:29:08 -0800 (PST) Received: from [10.57.39.145] (unknown [10.57.39.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 50EC63F66E; Sun, 10 Jan 2021 23:29:05 -0800 (PST) Subject: Re: [PATCH v1 3/7] perf cs-etm: Calculate per CPU metadata array size To: Leo Yan , Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Daniel Kiss , Denis Nikitin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210109074435.626855-1-leo.yan@linaro.org> <20210109074435.626855-4-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: <96ec434e-4103-02ac-a05a-761a9ca8cb0d@arm.com> Date: Mon, 11 Jan 2021 07:28:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210109074435.626855-4-leo.yan@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/9/21 7:44 AM, Leo Yan wrote: > The metadata array can be extended over time and the tool, if using the > predefined macro (like CS_ETMV4_PRIV_MAX for ETMv4) as metadata array > size to copy data, it can cause compatible issue within different > versions of perf tool. > > E.g. we recorded a data file with an old version tool, afterwards if > use the new version perf tool to parse the file, since the metadata > array has been extended and the macro CS_ETMV4_PRIV_MAX has been > altered, if use it to parse the perf data with old format, this will > lead to mismatch. > > To maintain backward compatibility, this patch calculates per CPU > metadata array size on the runtime, the calculation is based on the > info stored in the data file so that it's reliable. > > Signed-off-by: Leo Yan Looks good to me. Acked-by: Suzuki K Poulose From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E16C433DB for ; Mon, 11 Jan 2021 07:30:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4646622795 for ; Mon, 11 Jan 2021 07:30:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4646622795 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6ABCLDuMsWOIkJpuQe0Jv5l3N9ESpyOGzb2SPVcvmY8=; b=jxdxG0UJ+04TDkcDIGppdjbDG lhwcZ+mtt4P2NstIepV5Y3+q1VEp3iJgkMkT5PBUh4L3ldoc1XANjO3tMBw1iLR7D9s69Ns2CoAht Hxwsciuarvw13Y2oZM0NGEBucFrNc/dpTyTDVZhYCJLtFxtm/W5QuoBX80qEM8JYR1MSsVIGGZhhX P+yi84MVp6S3rmmmwYU5rrigheK+CjKcsKKyWW/3TAEpnTZChNRMuwGzyDzoNiplsMfUUwsIpJYQQ F5yP4fNyv74nj2fBiWou6v7AxeKimDB+U1aIwKplXGOWNIT2c/6KRe/kEppCQiqx2NioPOUA0DG2W MPKKwy/mA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyrdc-0004dx-B3; Mon, 11 Jan 2021 07:29:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyrdX-0004c7-V4 for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 07:29:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFB1131B; Sun, 10 Jan 2021 23:29:08 -0800 (PST) Received: from [10.57.39.145] (unknown [10.57.39.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 50EC63F66E; Sun, 10 Jan 2021 23:29:05 -0800 (PST) Subject: Re: [PATCH v1 3/7] perf cs-etm: Calculate per CPU metadata array size To: Leo Yan , Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Daniel Kiss , Denis Nikitin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210109074435.626855-1-leo.yan@linaro.org> <20210109074435.626855-4-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: <96ec434e-4103-02ac-a05a-761a9ca8cb0d@arm.com> Date: Mon, 11 Jan 2021 07:28:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210109074435.626855-4-leo.yan@linaro.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_022912_112533_5637CAE4 X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/9/21 7:44 AM, Leo Yan wrote: > The metadata array can be extended over time and the tool, if using the > predefined macro (like CS_ETMV4_PRIV_MAX for ETMv4) as metadata array > size to copy data, it can cause compatible issue within different > versions of perf tool. > > E.g. we recorded a data file with an old version tool, afterwards if > use the new version perf tool to parse the file, since the metadata > array has been extended and the macro CS_ETMV4_PRIV_MAX has been > altered, if use it to parse the perf data with old format, this will > lead to mismatch. > > To maintain backward compatibility, this patch calculates per CPU > metadata array size on the runtime, the calculation is based on the > info stored in the data file so that it's reliable. > > Signed-off-by: Leo Yan Looks good to me. Acked-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel