[PATCH] siteinfo: nios2-linux - remove wrong mutex info

[PATCH] siteinfo: nios2-linux - remove wrong mutex info

[Juro Bystricky]

This fixes broken nios2 builds that involve db recipes.

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
---
 meta/site/nios2-linux | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/site/nios2-linux b/meta/site/nios2-linux
index 2f4e570..5bae748 100644
--- a/meta/site/nios2-linux
+++ b/meta/site/nios2-linux
@@ -33,7 +33,6 @@ db_cv_path_sh=${db_cv_path_sh=/bin/sh}
 db_cv_path_strip=${db_cv_path_strip=/usr/bin/strip}
 db_cv_align_t=${db_cv_align_t='unsigned long long'}
 db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
-db_cv_mutex=${db_cv_mutex=ARM/gcc-assembly}
 db_cv_posixmutexes=${db_cv_posixmutexes=no}
 db_cv_uimutexes=${db_cv_uimutexes=no}
 
-- 
2.7.4

Re: [PATCH] siteinfo: nios2-linux - remove wrong mutex info

[Marek Vasut]

On 10/03/2017 09:51 PM, Juro Bystricky wrote:
> This fixes broken nios2 builds that involve db recipes.

While I understand ARM/ is wrong, why is removing the db_cv_mutex a
correct fix instead of ie. s/ARM/nios2/ ? The patch description does not
explain that.

> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> ---
>  meta/site/nios2-linux | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/site/nios2-linux b/meta/site/nios2-linux
> index 2f4e570..5bae748 100644
> --- a/meta/site/nios2-linux
> +++ b/meta/site/nios2-linux
> @@ -33,7 +33,6 @@ db_cv_path_sh=${db_cv_path_sh=/bin/sh}
>  db_cv_path_strip=${db_cv_path_strip=/usr/bin/strip}
>  db_cv_align_t=${db_cv_align_t='unsigned long long'}
>  db_cv_alignp_t=${db_cv_alignp_t='unsigned long'}
> -db_cv_mutex=${db_cv_mutex=ARM/gcc-assembly}
>  db_cv_posixmutexes=${db_cv_posixmutexes=no}
>  db_cv_uimutexes=${db_cv_uimutexes=no}
>  
> 


-- 
Best regards,
Marek Vasut

Re: [PATCH] siteinfo: nios2-linux - remove wrong mutex info

[Bystricky, Juro]

> While I understand ARM/ is wrong, why is removing the db_cv_mutex a
> correct fix instead of ie. s/ARM/nios2/ ? The patch description does not
> explain that.

With the relatively recent commit http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/recipes-support/db?id=f4e8e9242c5df095b52688b083df3c9d36e7144b
some nios2 builds (uboot, core-image-minimal, etc) were broken due to db trying to
use ARM instructions in mutexes. The reason was db "configure" used the cached entry 
from nios2-linux (which was incorrect).  So the remedy was to remove the incorrect cached entry
and let db "configure" figure out which is the proper mutex to use. 
Besides, I don't even know if nios2/gcc-assembly exists.
Also, none of other Linux info files provides this entry (db_cv_mutex).

Re: [PATCH] siteinfo: nios2-linux - remove wrong mutex info

[Marek Vasut]

On 10/03/2017 10:44 PM, Bystricky, Juro wrote:
> 
>> While I understand ARM/ is wrong, why is removing the db_cv_mutex a
>> correct fix instead of ie. s/ARM/nios2/ ? The patch description does not
>> explain that.
> 
> With the relatively recent commit http://git.yoctoproject.org/cgit.cgi/poky/commit/meta/recipes-support/db?id=f4e8e9242c5df095b52688b083df3c9d36e7144b
> some nios2 builds (uboot, core-image-minimal, etc) were broken due to db trying to
> use ARM instructions in mutexes. The reason was db "configure" used the cached entry 
> from nios2-linux (which was incorrect).  So the remedy was to remove the incorrect cached entry
> and let db "configure" figure out which is the proper mutex to use. 
> Besides, I don't even know if nios2/gcc-assembly exists.
> Also, none of other Linux info files provides this entry (db_cv_mutex).
> 

This should be in the commit message ...

-- 
Best regards,
Marek Vasut