From: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH 4/5] drm/i915: cpu-map based dumb buffers
Date: Tue, 22 Oct 2019 10:52:55 +0300 [thread overview]
Message-ID: <96f79055-5f3a-7774-825e-00855105b7d4@linux.intel.com> (raw)
In-Reply-To: <157166491547.29536.1978879286617090513@skylake-alporthouse-com>
On 21/10/2019 16.35, Chris Wilson wrote:
> Quoting Abdiel Janulgue (2019-10-21 11:48:10)
>> +int
>> +i915_gem_mmap_dumb(struct drm_file *file,
>> + struct drm_device *dev,
>> + u32 handle,
>> + u64 *offset)
>> +{
>> + return __assign_gem_object_mmap_data(file, handle, I915_MMAP_TYPE_WC,
>
> It still needs to do boot_cpu_has(PAT),
So we probably need a special use-case for GTT mmaps in those kind of
hw, no?
but it looks like
> kms_frontbuffer is not doing enough dirtyfb for its dumb buffer usage.
> Bad IGT (it's either a bug in the test for not adhering to the uabi
> for dumb buffers, or we have some tracking bug intel_frontbuffer).
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-22 7:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 10:48 [PATCH 1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue
2019-10-21 10:48 ` [PATCH 2/5] drm/i915: define HAS_MAPPABLE_APERTURE Abdiel Janulgue
2019-10-21 10:48 ` [PATCH 3/5] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET Abdiel Janulgue
2019-10-21 10:48 ` [PATCH 4/5] drm/i915: cpu-map based dumb buffers Abdiel Janulgue
2019-10-21 13:35 ` Chris Wilson
2019-10-22 7:52 ` Abdiel Janulgue [this message]
2019-10-22 10:37 ` Chris Wilson
2019-10-21 10:48 ` [PATCH 5/5] drm/i915: Add cpu fault handler for mmap_offset Abdiel Janulgue
2019-10-21 12:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Patchwork
2019-10-21 13:02 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-23 8:24 [PATCH 1/5] " Abdiel Janulgue
2019-10-23 8:24 ` [PATCH 4/5] drm/i915: cpu-map based dumb buffers Abdiel Janulgue
2019-10-23 8:30 [PATCH 1/5] drm/i915: Allow i915 to manage the vma offset nodes instead of drm core Abdiel Janulgue
2019-10-23 8:30 ` [PATCH 4/5] drm/i915: cpu-map based dumb buffers Abdiel Janulgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96f79055-5f3a-7774-825e-00855105b7d4@linux.intel.com \
--to=abdiel.janulgue@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.