From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-comment-return-1793-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 9AC449865CD for ; Thu, 25 Mar 2021 02:38:44 +0000 (UTC) References: <20210322034717.35135-1-jasowang@redhat.com> <20210322034717.35135-2-jasowang@redhat.com> From: Jason Wang Message-ID: <96f9de37-d3cb-e861-db4e-b2adf9738b89@redhat.com> Date: Thu, 25 Mar 2021 10:38:36 +0800 MIME-Version: 1.0 In-Reply-To: Subject: Re: [virtio-comment] [PATCH V2 1/2] virtio: introduce virtqueue state as basic facility Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable To: Stefan Hajnoczi Cc: virtio-comment@lists.oasis-open.org List-ID: =E5=9C=A8 2021/3/24 =E4=B8=8B=E5=8D=885:35, Stefan Hajnoczi =E5=86=99=E9=81= =93: > On Wed, Mar 24, 2021 at 04:15:55PM +0800, Jason Wang wrote: >> =E5=9C=A8 2021/3/23 =E4=B8=8B=E5=8D=886:27, Stefan Hajnoczi =E5=86=99=E9= =81=93: >>> On Mon, Mar 22, 2021 at 11:47:16AM +0800, Jason Wang wrote: >>>> + >>>> +\devicenormative{\subsection}{Virtqueue State}{Basic Facilities of a = Virtio Device / Virtqueue State} >>>> + >>>> +If VIRTIO_F_QUEUE_STATE has been negotiated, a device MUST NOT clear >>>> +the queue state upon reset and MUST reset the queue state when the >>>> +driver sets ACKNOWLEDGE status bit. >>> I only see normative sections mentioning getting the virtqueue state bu= t >>> not setting it. Please explain how setting works. >> >> You mean the device normative part? I think the description of avail sta= te >> and used state can explain itself. Or I miss something? > Oops, I missed the earlier normative section that says the driver must > set the virtqueue state after FEATURES_OK but before DRIVER_OK. > > When re-reading I noticed that there is a typo: s/FEATURE_OK/FEATURES_OK/= . Will fix. Thanks > > Stefan This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lis= ts Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/