From: Krzysztof Adamski <krzysztof.adamski@nokia.com>
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v4 05/10] hwmon: (tmp421) support specifying n-factor via DT
Date: Tue, 12 Oct 2021 11:28:08 +0200 [thread overview]
Message-ID: <97068b3f1703db5da8fe9bec0729c6b3a79672df.1634029538.git.krzysztof.adamski@nokia.com> (raw)
In-Reply-To: <cover.1634029538.git.krzysztof.adamski@nokia.com>
Previous patches added a way to specify some channel specific parameters
in DT and n-factor is definitely one of them. This calibration mechanism
is board specific as its value depends on the diodes/transistors being
connected to the sensor and thus the DT seems like a right fit for that
information. It is very similar to the value of shunt resistor that some
drivers allows specifying in DT.
This patch adds a possibility to set n-factor for each channel via
"n-factor" DT property in each channel subnode.
Signed-off-by: Krzysztof Adamski <krzysztof.adamski@nokia.com>
---
drivers/hwmon/tmp421.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
index fffffd671e34..fcd2932a6ddb 100644
--- a/drivers/hwmon/tmp421.c
+++ b/drivers/hwmon/tmp421.c
@@ -34,6 +34,7 @@ enum chips { tmp421, tmp422, tmp423, tmp441, tmp442 };
#define TMP421_STATUS_REG 0x08
#define TMP421_CONFIG_REG_1 0x09
#define TMP421_CONVERSION_RATE_REG 0x0B
+#define TMP421_N_FACTOR_REG_1 0x21
#define TMP421_MANUFACTURER_ID_REG 0xFE
#define TMP421_DEVICE_ID_REG 0xFF
@@ -310,6 +311,7 @@ static int tmp421_probe_child_from_dt(struct i2c_client *client,
{
struct device *dev = &client->dev;
u32 i;
+ s32 val;
int err;
err = of_property_read_u32(child, "reg", &i);
@@ -329,6 +331,20 @@ static int tmp421_probe_child_from_dt(struct i2c_client *client,
data->channel[i].enabled = of_device_is_available(child);
+ if (i == 0)
+ return 0; /* input 0 is internal channel */
+
+ err = of_property_read_s32(child, "ti,n-factor", &val);
+ if (!err) {
+ if (val > 127 || val < -128) {
+ dev_err(dev, "n-factor for channel %d invalid (%d)\n",
+ i, val);
+ return -EINVAL;
+ }
+ i2c_smbus_write_byte_data(client, TMP421_N_FACTOR_REG_1 + i - 1,
+ val);
+ }
+
return 0;
}
--
2.31.1
next prev parent reply other threads:[~2021-10-12 9:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 9:14 [PATCH v4 00/10] Add per channel properies support in tmp421 Krzysztof Adamski
2021-10-12 9:14 ` [PATCH v4 01/10] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski
2021-10-12 9:26 ` [PATCH v4 02/10] hwmon: (tmp421) introduce a channel struct Krzysztof Adamski
2021-10-12 14:25 ` Guenter Roeck
2021-10-12 9:27 ` [PATCH v4 03/10] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski
2021-10-12 14:30 ` Guenter Roeck
2021-10-12 9:27 ` [PATCH v4 04/10] hwmon: (tmp421) support disabling channels " Krzysztof Adamski
2021-10-12 14:32 ` Guenter Roeck
2021-10-12 9:28 ` Krzysztof Adamski [this message]
2021-10-12 14:34 ` [PATCH v4 05/10] hwmon: (tmp421) support specifying n-factor via DT Guenter Roeck
2021-10-12 9:29 ` [PATCH v4 06/10] hwmon: (tmp421) really disable channels Krzysztof Adamski
2021-10-12 14:37 ` Guenter Roeck
2021-10-12 18:01 ` kernel test robot
2021-10-12 18:01 ` kernel test robot
2021-10-13 18:50 ` kernel test robot
2021-10-13 18:50 ` kernel test robot
2021-10-12 9:29 ` [PATCH v4 07/10] hwmon: (tmp421) support HWMON_T_ENABLE Krzysztof Adamski
2021-10-12 14:43 ` Guenter Roeck
2021-10-12 9:30 ` [PATCH v4 08/10] hwmon: (tmp421) update documentation Krzysztof Adamski
2021-10-12 14:43 ` Guenter Roeck
2021-10-12 9:30 ` [PATCH v4 09/10] hwmon: (tmp421) ignore non-channel related DT nodes Krzysztof Adamski
2021-10-12 14:44 ` Guenter Roeck
2021-10-12 9:30 ` [PATCH v4 10/10] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski
2021-10-12 22:41 [PATCH v4 06/10] hwmon: (tmp421) really disable channels kernel test robot
2021-10-13 8:36 ` Dan Carpenter
2021-10-13 8:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97068b3f1703db5da8fe9bec0729c6b3a79672df.1634029538.git.krzysztof.adamski@nokia.com \
--to=krzysztof.adamski@nokia.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.