From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE4D7CA9ED5 for ; Tue, 5 Nov 2019 05:24:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A95C12084D for ; Tue, 5 Nov 2019 05:24:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b7knXK+2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387528AbfKEFY1 (ORCPT ); Tue, 5 Nov 2019 00:24:27 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:53675 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387457AbfKEFY0 (ORCPT ); Tue, 5 Nov 2019 00:24:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572931464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=azZWRjG24KLaqLmrGvXAAipfORyjp6MDEKFPlBiuBE8=; b=b7knXK+2dcRfmiQ4PyAC4W05qr47qZPCDewGyAKwWVty7ikiS0XKeYJR7tBrV9rN56UlGw TZgEGBEUZTSgFUHjmx10m7A9hQS4oV5cNijpXS7gQwxswvLQd8mQiPRknc4MwcbNvSaJXP HNXnz7NROG64TcFx1CZGlTiQ2GLRJe0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-281-9DP0etJzPRutiF5l4L2myw-1; Tue, 05 Nov 2019 00:24:20 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CEFF8017DD; Tue, 5 Nov 2019 05:24:16 +0000 (UTC) Received: from [10.72.12.252] (ovpn-12-252.pek2.redhat.com [10.72.12.252]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85B7F5D9CD; Tue, 5 Nov 2019 05:22:58 +0000 (UTC) Subject: Re: [PATCH V7 4/6] mdev: introduce virtio device and its device ops To: Alex Williamson Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, mst@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, akrowiak@linux.ibm.com, freude@linux.ibm.com, lingshan.zhu@intel.com, idos@mellanox.com, eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com, christophe.de.dinechin@gmail.com, kevin.tian@intel.com, stefanha@redhat.com References: <20191104123952.17276-1-jasowang@redhat.com> <20191104123952.17276-5-jasowang@redhat.com> <20191104145024.5e437765@x1.home> <1faf4f36-3f79-2e15-3f61-c406d68240ab@redhat.com> <20191104213920.59d356a3@x1.home> From: Jason Wang Message-ID: <970f2107-2677-6578-ce99-65083716d04d@redhat.com> Date: Tue, 5 Nov 2019 13:22:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191104213920.59d356a3@x1.home> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 9DP0etJzPRutiF5l4L2myw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/11/5 =E4=B8=8B=E5=8D=8812:39, Alex Williamson wrote: > On Tue, 5 Nov 2019 11:52:41 +0800 > Jason Wang wrote: > >> On 2019/11/5 =E4=B8=8A=E5=8D=885:50, Alex Williamson wrote: >>> On Mon, 4 Nov 2019 20:39:50 +0800 >>> Jason Wang wrote: >>> =20 >>>> This patch implements basic support for mdev driver that supports >>>> virtio transport for kernel virtio driver. >>>> >>>> Signed-off-by: Jason Wang >>>> --- >>>> drivers/vfio/mdev/mdev_core.c | 20 ++++ >>>> drivers/vfio/mdev/mdev_private.h | 2 + >>>> include/linux/mdev.h | 6 ++ >>>> include/linux/mdev_virtio_ops.h | 166 ++++++++++++++++++++++++++++= +++ >>>> 4 files changed, 194 insertions(+) >>>> create mode 100644 include/linux/mdev_virtio_ops.h >>>> >>>> diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_co= re.c >>>> index 8d579d7ed82f..95ee4126ff9c 100644 >>>> --- a/drivers/vfio/mdev/mdev_core.c >>>> +++ b/drivers/vfio/mdev/mdev_core.c >>>> @@ -76,6 +76,26 @@ const struct mdev_vfio_device_ops *mdev_get_vfio_op= s(struct mdev_device *mdev) >>>> } >>>> EXPORT_SYMBOL(mdev_get_vfio_ops); >>>> =20 >>>> +/* Specify the virtio device ops for the mdev device, this >>>> + * must be called during create() callback for virtio mdev device. >>>> + */ >>> Comment style. >> >> Will fix. >> >> >>> =20 >>>> +void mdev_set_virtio_ops(struct mdev_device *mdev, >>>> +=09=09=09 const struct mdev_virtio_device_ops *virtio_ops) >>>> +{ >>>> +=09mdev_set_class(mdev, MDEV_CLASS_ID_VIRTIO); >>>> +=09mdev->virtio_ops =3D virtio_ops; >>>> +} >>>> +EXPORT_SYMBOL(mdev_set_virtio_ops); >>>> + >>>> +/* Get the virtio device ops for the mdev device. */ >>>> +const struct mdev_virtio_device_ops * >>>> +mdev_get_virtio_ops(struct mdev_device *mdev) >>>> +{ >>>> +=09WARN_ON(mdev->class_id !=3D MDEV_CLASS_ID_VIRTIO); >>>> +=09return mdev->virtio_ops; >>>> +} >>>> +EXPORT_SYMBOL(mdev_get_virtio_ops); >>>> + >>>> struct device *mdev_dev(struct mdev_device *mdev) >>>> { >>>> =09return &mdev->dev; >>>> diff --git a/drivers/vfio/mdev/mdev_private.h b/drivers/vfio/mdev/mdev= _private.h >>>> index 411227373625..2c74dd032409 100644 >>>> --- a/drivers/vfio/mdev/mdev_private.h >>>> +++ b/drivers/vfio/mdev/mdev_private.h >>>> @@ -11,6 +11,7 @@ >>>> #define MDEV_PRIVATE_H >>>> =20 >>>> #include >>>> +#include >>>> =20 >>>> int mdev_bus_register(void); >>>> void mdev_bus_unregister(void); >>>> @@ -38,6 +39,7 @@ struct mdev_device { >>>> =09u16 class_id; >>>> =09union { >>>> =09=09const struct mdev_vfio_device_ops *vfio_ops; >>>> +=09=09const struct mdev_virtio_device_ops *virtio_ops; >>>> =09}; >>>> }; >>>> =20 >>>> diff --git a/include/linux/mdev.h b/include/linux/mdev.h >>>> index 9e37506d1987..f3d75a60c2b5 100644 >>>> --- a/include/linux/mdev.h >>>> +++ b/include/linux/mdev.h >>>> @@ -17,6 +17,7 @@ >>>> =20 >>>> struct mdev_device; >>>> struct mdev_vfio_device_ops; >>>> +struct mdev_virtio_device_ops; >>>> =20 >>>> /* >>>> * Called by the parent device driver to set the device which repre= sents >>>> @@ -112,6 +113,10 @@ void mdev_set_class(struct mdev_device *mdev, u16= id); >>>> void mdev_set_vfio_ops(struct mdev_device *mdev, >>>> =09=09 const struct mdev_vfio_device_ops *vfio_ops); >>>> const struct mdev_vfio_device_ops *mdev_get_vfio_ops(struct mdev_de= vice *mdev); >>>> +void mdev_set_virtio_ops(struct mdev_device *mdev, >>>> +=09=09=09 const struct mdev_virtio_device_ops *virtio_ops); >>>> +const struct mdev_virtio_device_ops * >>>> +mdev_get_virtio_ops(struct mdev_device *mdev); >>>> =20 >>>> extern struct bus_type mdev_bus_type; >>>> =20 >>>> @@ -127,6 +132,7 @@ struct mdev_device *mdev_from_dev(struct device *d= ev); >>>> =20 >>>> enum { >>>> =09MDEV_CLASS_ID_VFIO =3D 1, >>>> +=09MDEV_CLASS_ID_VIRTIO =3D 2, >>>> =09/* New entries must be added here */ >>>> }; >>>> =20 >>>> diff --git a/include/linux/mdev_virtio_ops.h b/include/linux/mdev_virt= io_ops.h >>>> new file mode 100644 >>>> index 000000000000..0dcae7fa31e5 >>>> --- /dev/null >>>> +++ b/include/linux/mdev_virtio_ops.h >>>> @@ -0,0 +1,166 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>>> +/* >>>> + * Virtio mediated device driver >>>> + * >>>> + * Copyright 2019, Red Hat Corp. >>>> + * Author: Jason Wang >>>> + */ >>>> +#ifndef MDEV_VIRTIO_OPS_H >>>> +#define MDEV_VIRTIO_OPS_H >>>> + >>>> +#include >>>> +#include >>>> +#include >>>> + >>>> +#define VIRTIO_MDEV_DEVICE_API_STRING=09=09"virtio-mdev" >>>> +#define VIRTIO_MDEV_F_VERSION_1 0x1 >>>> + >>>> +struct virtio_mdev_callback { >>>> +=09irqreturn_t (*callback)(void *data); >>>> +=09void *private; >>>> +}; >>>> + >>>> +/** >>>> + * struct mdev_virtio_device_ops - Structure to be registered for eac= h >>>> + * mdev device to register the device for virtio/vhost drivers. >>>> + * >>>> + * The device ops that is supported by VIRTIO_MDEV_F_VERSION_1, the >>>> + * callbacks are mandatory unless explicity mentioned. >>>> + * >>>> + * @get_mdev_features:=09=09Get a set of bits that demonstrate >>>> + *=09=09=09=09the capability of the mdev device. New >>>> + *=09=09=09=09feature bits must be added when >>>> + *=09=09=09=09introducing new device ops. This >>>> + *=09=09=09=09allows the device ops to be extended >>>> + *=09=09=09=09(one feature could have N new ops). >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns the mdev features (API) support by >>>> + *=09=09=09=09the device. >>> I still don't see the point of VIRTIO_MDEV_F_VERSION_1. In what case >>> would it not be set? >> >> It's a must for current driver implementation. >> >> >>> What would it indicate to the caller if it were >>> not set? The existence of this interface seems to indicate version 1. >> >> The idea is when VIRTIO_MDE_F_VERSION_1 is advertised, driver will >> assume all the mandatory callbacks for this feature were implemented. >> Then there's no need to check the existence of each callback. > But this is redundant to MDEV_CLASS_ID_VIRTIO, which must imply the > struct mdev_virtio_device_ops or else we have no handshake between the > mdev device and the mdev bus driver. Essentially this creates a flag > that says there are no flags, which is useless. I can't see why > checking feature bits here is preferable to checking callbacks. Ok, so I think the point is that we can assume the existence for some=20 callbacks from the start. > >>> I'm also still unclear how device ops gets extended, can you give some >>> examples? Particularly, if feature A and feature B both add device ops >>> callbacks, is the vendor allowed to support B but not A, and does that >>> imply their device ops structure includes callbacks for A but they're >>> unused? >> >> For current API, the answer is yes. So if vendor only support feature B, >> it needs to set the device_ops that support feature A to NULL. > Which is exactly what we expect to happen with get_generation() but we > can't be bothered to add a feature flag for it? The interface is > already self inconsistent. For get_generation(), we can do simply fallback by return zero (like=20 what virito core did). But for other feature, we can not have such=20 fallback easily. > >>> Why doesn't the previous patch take any of this into account >>> for struct mdev_vfio_device_ops? I think this is an internal API, >>> therefore is it worthwhile to include feature and extension support? >> >> I'm not sure if VFIO has the request. In that case new features could be >> extended simply through transport/bus specific way (e.g PCIE capability >> list). But in the case of virtio-mdev, we need invent something on our >> own. If the simple mapping between features and device ops is proved to >> be not sufficient or sub-optimal, we can introduce a more sophisticated >> API. > I think the key is that device ops is not an ABI, if we add new > callbacks we can extend the structures of all the vendor drivers and > the mdev bus driver can either choose to test the callback at runtime > or probe time. I really don't see what we're accomplishing with this > callback. > >>>> + * @get_mdev_features:=09=09Set a set of features that will be >>> s/get/set/ >> >> Will fix. >> >> >>> =20 >>>> + *=09=09=09=09used by the driver. >>>> + *=09=09=09=09@features: features used by the driver >>>> + *=09=09=09=09Returns bollean: whether the features >>> s/bollean/boolean/ >>> >>> How does one provide a set of features to set given this prototype? >>> >>> bool (*set_mdev_feature)(struct mdev_device *mdev); >>> >>> This is starting to look like a grab bag of callbacks, what sort of >>> mdev features would the driver have the ability to set on a device? >> >> Yes, e.g device support A,B,C, but driver will only use B and C. > Can you give a _concrete_ example of such features where the device > needs to be informed of what features the driver will use rather than > simply not using them? Two examples: - dirty page logging by device - control vq support So device can choose to support one of the above features. > There appears to be no use case for this > currently, so I'd suggest dropping it. If such a feature becomes > necessary it can be added as needed since this is an internal > interface. Ok, I think I get your point. I worried about the vhost-mdev but anyway=20 those API is not exposed to user directly. I will drop those in next=20 version. > Also not sure my point above was well conveyed, the > prototype doesn't provide a feature arg in order to set features. The > comment also indicates we can set a set of features (ie. multiple), but > it's not well specified what a failure indicates or why we'd use a > boolean to indicate a failure versus an errno where we could interpret > the return code. Both these callbacks seem like placeholders, which > should be unnecessary as this is simply an internal API between > virtio-mdev vendor drivers and the bus driver. Thanks, I see. Thanks > > Alex > >>> Note that this is not listed as optional, but the sample driver doesn't >>> implement it :-\ >> >> My bad, will fix this. >> >> Thanks >> >> >>> Thanks, >>> >>> Alex >>> =20 >>>> + *=09=09=09=09is accepted by the device. >>>> + * @set_vq_address:=09=09Set the address of virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@desc_area: address of desc area >>>> + *=09=09=09=09@driver_area: address of driver area >>>> + *=09=09=09=09@device_area: address of device area >>>> + *=09=09=09=09Returns integer: success (0) or error (< 0) >>>> + * @set_vq_num:=09=09=09Set the size of virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@num: the size of virtqueue >>>> + * @kick_vq:=09=09=09Kick the virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + * @set_vq_cb:=09=09=09Set the interrupt callback function for >>>> + *=09=09=09=09a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@cb: virtio-mdev interrupt callback structure >>>> + * @set_vq_ready:=09=09Set ready status for a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@ready: ready (true) not ready(false) >>>> + * @get_vq_ready:=09=09Get ready status for a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09Returns boolean: ready (true) or not (false) >>>> + * @set_vq_state:=09=09Set the state for a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@state: virtqueue state (last_avail_idx) >>>> + *=09=09=09=09Returns integer: success (0) or error (< 0) >>>> + * @get_vq_state:=09=09Get the state for a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09Returns virtqueue state (last_avail_idx) >>>> + * @get_vq_align:=09=09Get the virtqueue align requirement >>>> + *=09=09=09=09for the device >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns virtqueue algin requirement >>>> + * @get_features:=09=09Get virtio features supported by the device >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns the virtio features support by the >>>> + *=09=09=09=09device >>>> + * @set_features:=09=09Set virtio features supported by the driver >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@features: feature support by the driver >>>> + *=09=09=09=09Returns integer: success (0) or error (< 0) >>>> + * @set_config_cb:=09=09Set the config interrupt callback >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@cb: virtio-mdev interrupt callback structure >>>> + * @get_vq_num_max:=09=09Get the max size of virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u16: max size of virtqueue >>>> + * @get_device_id:=09=09Get virtio device id >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u32: virtio device id >>>> + * @get_vendor_id:=09=09Get id for the vendor that provides this devi= ce >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u32: virtio vendor id >>>> + * @get_status:=09=09=09Get the device status >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u8: virtio device status >>>> + * @set_status:=09=09=09Set the device status >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@status: virtio device status >>>> + * @get_config:=09=09=09Read from device specific configuration space >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@offset: offset from the beginning of >>>> + *=09=09=09=09configuration space >>>> + *=09=09=09=09@buf: buffer used to read to >>>> + *=09=09=09=09@len: the length to read from >>>> + *=09=09=09=09configration space >>>> + * @set_config:=09=09=09Write to device specific configuration space >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@offset: offset from the beginning of >>>> + *=09=09=09=09configuration space >>>> + *=09=09=09=09@buf: buffer used to write from >>>> + *=09=09=09=09@len: the length to write to >>>> + *=09=09=09=09configration space >>>> + * @get_generation:=09=09Get device config generaton (optional) >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u32: device generation >>>> + */ >>>> +struct mdev_virtio_device_ops { >>>> +=09/* Mdev device ops */ >>>> +=09u64 (*get_mdev_features)(struct mdev_device *mdev); >>>> +=09bool (*set_mdev_feature)(struct mdev_device *mdev); >>>> +=09/* Virtqueue ops */ >>>> +=09int (*set_vq_address)(struct mdev_device *mdev, >>>> +=09=09=09 u16 idx, u64 desc_area, u64 driver_area, >>>> +=09=09=09 u64 device_area); >>>> +=09void (*set_vq_num)(struct mdev_device *mdev, u16 idx, u32 num); >>>> +=09void (*kick_vq)(struct mdev_device *mdev, u16 idx); >>>> +=09void (*set_vq_cb)(struct mdev_device *mdev, u16 idx, >>>> +=09=09=09 struct virtio_mdev_callback *cb); >>>> +=09void (*set_vq_ready)(struct mdev_device *mdev, u16 idx, bool ready= ); >>>> +=09bool (*get_vq_ready)(struct mdev_device *mdev, u16 idx); >>>> +=09int (*set_vq_state)(struct mdev_device *mdev, u16 idx, u64 state); >>>> +=09u64 (*get_vq_state)(struct mdev_device *mdev, u16 idx); >>>> + >>>> +=09/* Virtio device ops */ >>>> +=09u16 (*get_vq_align)(struct mdev_device *mdev); >>>> +=09u64 (*get_features)(struct mdev_device *mdev); >>>> +=09int (*set_features)(struct mdev_device *mdev, u64 features); >>>> +=09void (*set_config_cb)(struct mdev_device *mdev, >>>> +=09=09=09 struct virtio_mdev_callback *cb); >>>> +=09u16 (*get_vq_num_max)(struct mdev_device *mdev); >>>> +=09u32 (*get_device_id)(struct mdev_device *mdev); >>>> +=09u32 (*get_vendor_id)(struct mdev_device *mdev); >>>> +=09u8 (*get_status)(struct mdev_device *mdev); >>>> +=09void (*set_status)(struct mdev_device *mdev, u8 status); >>>> +=09void (*get_config)(struct mdev_device *mdev, unsigned int offset, >>>> +=09=09=09 void *buf, unsigned int len); >>>> +=09void (*set_config)(struct mdev_device *mdev, unsigned int offset, >>>> +=09=09=09 const void *buf, unsigned int len); >>>> +=09u32 (*get_generation)(struct mdev_device *mdev); >>>> +}; >>>> + >>>> +void mdev_set_virtio_ops(struct mdev_device *mdev, >>>> +=09=09=09 const struct mdev_virtio_device_ops *virtio_ops); >>>> + >>>> +#endif From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH V7 4/6] mdev: introduce virtio device and its device ops Date: Tue, 5 Nov 2019 13:22:50 +0800 Message-ID: <970f2107-2677-6578-ce99-65083716d04d@redhat.com> References: <20191104123952.17276-1-jasowang@redhat.com> <20191104123952.17276-5-jasowang@redhat.com> <20191104145024.5e437765@x1.home> <1faf4f36-3f79-2e15-3f61-c406d68240ab@redhat.com> <20191104213920.59d356a3@x1.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20191104213920.59d356a3@x1.home> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alex Williamson Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, mst@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com List-Id: dri-devel@lists.freedesktop.org On 2019/11/5 =E4=B8=8B=E5=8D=8812:39, Alex Williamson wrote: > On Tue, 5 Nov 2019 11:52:41 +0800 > Jason Wang wrote: > >> On 2019/11/5 =E4=B8=8A=E5=8D=885:50, Alex Williamson wrote: >>> On Mon, 4 Nov 2019 20:39:50 +0800 >>> Jason Wang wrote: >>> =20 >>>> This patch implements basic support for mdev driver that supports >>>> virtio transport for kernel virtio driver. >>>> >>>> Signed-off-by: Jason Wang >>>> --- >>>> drivers/vfio/mdev/mdev_core.c | 20 ++++ >>>> drivers/vfio/mdev/mdev_private.h | 2 + >>>> include/linux/mdev.h | 6 ++ >>>> include/linux/mdev_virtio_ops.h | 166 ++++++++++++++++++++++++++++= +++ >>>> 4 files changed, 194 insertions(+) >>>> create mode 100644 include/linux/mdev_virtio_ops.h >>>> >>>> diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_co= re.c >>>> index 8d579d7ed82f..95ee4126ff9c 100644 >>>> --- a/drivers/vfio/mdev/mdev_core.c >>>> +++ b/drivers/vfio/mdev/mdev_core.c >>>> @@ -76,6 +76,26 @@ const struct mdev_vfio_device_ops *mdev_get_vfio_op= s(struct mdev_device *mdev) >>>> } >>>> EXPORT_SYMBOL(mdev_get_vfio_ops); >>>> =20 >>>> +/* Specify the virtio device ops for the mdev device, this >>>> + * must be called during create() callback for virtio mdev device. >>>> + */ >>> Comment style. >> >> Will fix. >> >> >>> =20 >>>> +void mdev_set_virtio_ops(struct mdev_device *mdev, >>>> +=09=09=09 const struct mdev_virtio_device_ops *virtio_ops) >>>> +{ >>>> +=09mdev_set_class(mdev, MDEV_CLASS_ID_VIRTIO); >>>> +=09mdev->virtio_ops =3D virtio_ops; >>>> +} >>>> +EXPORT_SYMBOL(mdev_set_virtio_ops); >>>> + >>>> +/* Get the virtio device ops for the mdev device. */ >>>> +const struct mdev_virtio_device_ops * >>>> +mdev_get_virtio_ops(struct mdev_device *mdev) >>>> +{ >>>> +=09WARN_ON(mdev->class_id !=3D MDEV_CLASS_ID_VIRTIO); >>>> +=09return mdev->virtio_ops; >>>> +} >>>> +EXPORT_SYMBOL(mdev_get_virtio_ops); >>>> + >>>> struct device *mdev_dev(struct mdev_device *mdev) >>>> { >>>> =09return &mdev->dev; >>>> diff --git a/drivers/vfio/mdev/mdev_private.h b/drivers/vfio/mdev/mdev= _private.h >>>> index 411227373625..2c74dd032409 100644 >>>> --- a/drivers/vfio/mdev/mdev_private.h >>>> +++ b/drivers/vfio/mdev/mdev_private.h >>>> @@ -11,6 +11,7 @@ >>>> #define MDEV_PRIVATE_H >>>> =20 >>>> #include >>>> +#include >>>> =20 >>>> int mdev_bus_register(void); >>>> void mdev_bus_unregister(void); >>>> @@ -38,6 +39,7 @@ struct mdev_device { >>>> =09u16 class_id; >>>> =09union { >>>> =09=09const struct mdev_vfio_device_ops *vfio_ops; >>>> +=09=09const struct mdev_virtio_device_ops *virtio_ops; >>>> =09}; >>>> }; >>>> =20 >>>> diff --git a/include/linux/mdev.h b/include/linux/mdev.h >>>> index 9e37506d1987..f3d75a60c2b5 100644 >>>> --- a/include/linux/mdev.h >>>> +++ b/include/linux/mdev.h >>>> @@ -17,6 +17,7 @@ >>>> =20 >>>> struct mdev_device; >>>> struct mdev_vfio_device_ops; >>>> +struct mdev_virtio_device_ops; >>>> =20 >>>> /* >>>> * Called by the parent device driver to set the device which repre= sents >>>> @@ -112,6 +113,10 @@ void mdev_set_class(struct mdev_device *mdev, u16= id); >>>> void mdev_set_vfio_ops(struct mdev_device *mdev, >>>> =09=09 const struct mdev_vfio_device_ops *vfio_ops); >>>> const struct mdev_vfio_device_ops *mdev_get_vfio_ops(struct mdev_de= vice *mdev); >>>> +void mdev_set_virtio_ops(struct mdev_device *mdev, >>>> +=09=09=09 const struct mdev_virtio_device_ops *virtio_ops); >>>> +const struct mdev_virtio_device_ops * >>>> +mdev_get_virtio_ops(struct mdev_device *mdev); >>>> =20 >>>> extern struct bus_type mdev_bus_type; >>>> =20 >>>> @@ -127,6 +132,7 @@ struct mdev_device *mdev_from_dev(struct device *d= ev); >>>> =20 >>>> enum { >>>> =09MDEV_CLASS_ID_VFIO =3D 1, >>>> +=09MDEV_CLASS_ID_VIRTIO =3D 2, >>>> =09/* New entries must be added here */ >>>> }; >>>> =20 >>>> diff --git a/include/linux/mdev_virtio_ops.h b/include/linux/mdev_virt= io_ops.h >>>> new file mode 100644 >>>> index 000000000000..0dcae7fa31e5 >>>> --- /dev/null >>>> +++ b/include/linux/mdev_virtio_ops.h >>>> @@ -0,0 +1,166 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>>> +/* >>>> + * Virtio mediated device driver >>>> + * >>>> + * Copyright 2019, Red Hat Corp. >>>> + * Author: Jason Wang >>>> + */ >>>> +#ifndef MDEV_VIRTIO_OPS_H >>>> +#define MDEV_VIRTIO_OPS_H >>>> + >>>> +#include >>>> +#include >>>> +#include >>>> + >>>> +#define VIRTIO_MDEV_DEVICE_API_STRING=09=09"virtio-mdev" >>>> +#define VIRTIO_MDEV_F_VERSION_1 0x1 >>>> + >>>> +struct virtio_mdev_callback { >>>> +=09irqreturn_t (*callback)(void *data); >>>> +=09void *private; >>>> +}; >>>> + >>>> +/** >>>> + * struct mdev_virtio_device_ops - Structure to be registered for eac= h >>>> + * mdev device to register the device for virtio/vhost drivers. >>>> + * >>>> + * The device ops that is supported by VIRTIO_MDEV_F_VERSION_1, the >>>> + * callbacks are mandatory unless explicity mentioned. >>>> + * >>>> + * @get_mdev_features:=09=09Get a set of bits that demonstrate >>>> + *=09=09=09=09the capability of the mdev device. New >>>> + *=09=09=09=09feature bits must be added when >>>> + *=09=09=09=09introducing new device ops. This >>>> + *=09=09=09=09allows the device ops to be extended >>>> + *=09=09=09=09(one feature could have N new ops). >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns the mdev features (API) support by >>>> + *=09=09=09=09the device. >>> I still don't see the point of VIRTIO_MDEV_F_VERSION_1. In what case >>> would it not be set? >> >> It's a must for current driver implementation. >> >> >>> What would it indicate to the caller if it were >>> not set? The existence of this interface seems to indicate version 1. >> >> The idea is when VIRTIO_MDE_F_VERSION_1 is advertised, driver will >> assume all the mandatory callbacks for this feature were implemented. >> Then there's no need to check the existence of each callback. > But this is redundant to MDEV_CLASS_ID_VIRTIO, which must imply the > struct mdev_virtio_device_ops or else we have no handshake between the > mdev device and the mdev bus driver. Essentially this creates a flag > that says there are no flags, which is useless. I can't see why > checking feature bits here is preferable to checking callbacks. Ok, so I think the point is that we can assume the existence for some=20 callbacks from the start. > >>> I'm also still unclear how device ops gets extended, can you give some >>> examples? Particularly, if feature A and feature B both add device ops >>> callbacks, is the vendor allowed to support B but not A, and does that >>> imply their device ops structure includes callbacks for A but they're >>> unused? >> >> For current API, the answer is yes. So if vendor only support feature B, >> it needs to set the device_ops that support feature A to NULL. > Which is exactly what we expect to happen with get_generation() but we > can't be bothered to add a feature flag for it? The interface is > already self inconsistent. For get_generation(), we can do simply fallback by return zero (like=20 what virito core did). But for other feature, we can not have such=20 fallback easily. > >>> Why doesn't the previous patch take any of this into account >>> for struct mdev_vfio_device_ops? I think this is an internal API, >>> therefore is it worthwhile to include feature and extension support? >> >> I'm not sure if VFIO has the request. In that case new features could be >> extended simply through transport/bus specific way (e.g PCIE capability >> list). But in the case of virtio-mdev, we need invent something on our >> own. If the simple mapping between features and device ops is proved to >> be not sufficient or sub-optimal, we can introduce a more sophisticated >> API. > I think the key is that device ops is not an ABI, if we add new > callbacks we can extend the structures of all the vendor drivers and > the mdev bus driver can either choose to test the callback at runtime > or probe time. I really don't see what we're accomplishing with this > callback. > >>>> + * @get_mdev_features:=09=09Set a set of features that will be >>> s/get/set/ >> >> Will fix. >> >> >>> =20 >>>> + *=09=09=09=09used by the driver. >>>> + *=09=09=09=09@features: features used by the driver >>>> + *=09=09=09=09Returns bollean: whether the features >>> s/bollean/boolean/ >>> >>> How does one provide a set of features to set given this prototype? >>> >>> bool (*set_mdev_feature)(struct mdev_device *mdev); >>> >>> This is starting to look like a grab bag of callbacks, what sort of >>> mdev features would the driver have the ability to set on a device? >> >> Yes, e.g device support A,B,C, but driver will only use B and C. > Can you give a _concrete_ example of such features where the device > needs to be informed of what features the driver will use rather than > simply not using them? Two examples: - dirty page logging by device - control vq support So device can choose to support one of the above features. > There appears to be no use case for this > currently, so I'd suggest dropping it. If such a feature becomes > necessary it can be added as needed since this is an internal > interface. Ok, I think I get your point. I worried about the vhost-mdev but anyway=20 those API is not exposed to user directly. I will drop those in next=20 version. > Also not sure my point above was well conveyed, the > prototype doesn't provide a feature arg in order to set features. The > comment also indicates we can set a set of features (ie. multiple), but > it's not well specified what a failure indicates or why we'd use a > boolean to indicate a failure versus an errno where we could interpret > the return code. Both these callbacks seem like placeholders, which > should be unnecessary as this is simply an internal API between > virtio-mdev vendor drivers and the bus driver. Thanks, I see. Thanks > > Alex > >>> Note that this is not listed as optional, but the sample driver doesn't >>> implement it :-\ >> >> My bad, will fix this. >> >> Thanks >> >> >>> Thanks, >>> >>> Alex >>> =20 >>>> + *=09=09=09=09is accepted by the device. >>>> + * @set_vq_address:=09=09Set the address of virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@desc_area: address of desc area >>>> + *=09=09=09=09@driver_area: address of driver area >>>> + *=09=09=09=09@device_area: address of device area >>>> + *=09=09=09=09Returns integer: success (0) or error (< 0) >>>> + * @set_vq_num:=09=09=09Set the size of virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@num: the size of virtqueue >>>> + * @kick_vq:=09=09=09Kick the virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + * @set_vq_cb:=09=09=09Set the interrupt callback function for >>>> + *=09=09=09=09a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@cb: virtio-mdev interrupt callback structure >>>> + * @set_vq_ready:=09=09Set ready status for a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@ready: ready (true) not ready(false) >>>> + * @get_vq_ready:=09=09Get ready status for a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09Returns boolean: ready (true) or not (false) >>>> + * @set_vq_state:=09=09Set the state for a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09@state: virtqueue state (last_avail_idx) >>>> + *=09=09=09=09Returns integer: success (0) or error (< 0) >>>> + * @get_vq_state:=09=09Get the state for a virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@idx: virtqueue index >>>> + *=09=09=09=09Returns virtqueue state (last_avail_idx) >>>> + * @get_vq_align:=09=09Get the virtqueue align requirement >>>> + *=09=09=09=09for the device >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns virtqueue algin requirement >>>> + * @get_features:=09=09Get virtio features supported by the device >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns the virtio features support by the >>>> + *=09=09=09=09device >>>> + * @set_features:=09=09Set virtio features supported by the driver >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@features: feature support by the driver >>>> + *=09=09=09=09Returns integer: success (0) or error (< 0) >>>> + * @set_config_cb:=09=09Set the config interrupt callback >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@cb: virtio-mdev interrupt callback structure >>>> + * @get_vq_num_max:=09=09Get the max size of virtqueue >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u16: max size of virtqueue >>>> + * @get_device_id:=09=09Get virtio device id >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u32: virtio device id >>>> + * @get_vendor_id:=09=09Get id for the vendor that provides this devi= ce >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u32: virtio vendor id >>>> + * @get_status:=09=09=09Get the device status >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u8: virtio device status >>>> + * @set_status:=09=09=09Set the device status >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@status: virtio device status >>>> + * @get_config:=09=09=09Read from device specific configuration space >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@offset: offset from the beginning of >>>> + *=09=09=09=09configuration space >>>> + *=09=09=09=09@buf: buffer used to read to >>>> + *=09=09=09=09@len: the length to read from >>>> + *=09=09=09=09configration space >>>> + * @set_config:=09=09=09Write to device specific configuration space >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09@offset: offset from the beginning of >>>> + *=09=09=09=09configuration space >>>> + *=09=09=09=09@buf: buffer used to write from >>>> + *=09=09=09=09@len: the length to write to >>>> + *=09=09=09=09configration space >>>> + * @get_generation:=09=09Get device config generaton (optional) >>>> + *=09=09=09=09@mdev: mediated device >>>> + *=09=09=09=09Returns u32: device generation >>>> + */ >>>> +struct mdev_virtio_device_ops { >>>> +=09/* Mdev device ops */ >>>> +=09u64 (*get_mdev_features)(struct mdev_device *mdev); >>>> +=09bool (*set_mdev_feature)(struct mdev_device *mdev); >>>> +=09/* Virtqueue ops */ >>>> +=09int (*set_vq_address)(struct mdev_device *mdev, >>>> +=09=09=09 u16 idx, u64 desc_area, u64 driver_area, >>>> +=09=09=09 u64 device_area); >>>> +=09void (*set_vq_num)(struct mdev_device *mdev, u16 idx, u32 num); >>>> +=09void (*kick_vq)(struct mdev_device *mdev, u16 idx); >>>> +=09void (*set_vq_cb)(struct mdev_device *mdev, u16 idx, >>>> +=09=09=09 struct virtio_mdev_callback *cb); >>>> +=09void (*set_vq_ready)(struct mdev_device *mdev, u16 idx, bool ready= ); >>>> +=09bool (*get_vq_ready)(struct mdev_device *mdev, u16 idx); >>>> +=09int (*set_vq_state)(struct mdev_device *mdev, u16 idx, u64 state); >>>> +=09u64 (*get_vq_state)(struct mdev_device *mdev, u16 idx); >>>> + >>>> +=09/* Virtio device ops */ >>>> +=09u16 (*get_vq_align)(struct mdev_device *mdev); >>>> +=09u64 (*get_features)(struct mdev_device *mdev); >>>> +=09int (*set_features)(struct mdev_device *mdev, u64 features); >>>> +=09void (*set_config_cb)(struct mdev_device *mdev, >>>> +=09=09=09 struct virtio_mdev_callback *cb); >>>> +=09u16 (*get_vq_num_max)(struct mdev_device *mdev); >>>> +=09u32 (*get_device_id)(struct mdev_device *mdev); >>>> +=09u32 (*get_vendor_id)(struct mdev_device *mdev); >>>> +=09u8 (*get_status)(struct mdev_device *mdev); >>>> +=09void (*set_status)(struct mdev_device *mdev, u8 status); >>>> +=09void (*get_config)(struct mdev_device *mdev, unsigned int offset, >>>> +=09=09=09 void *buf, unsigned int len); >>>> +=09void (*set_config)(struct mdev_device *mdev, unsigned int offset, >>>> +=09=09=09 const void *buf, unsigned int len); >>>> +=09u32 (*get_generation)(struct mdev_device *mdev); >>>> +}; >>>> + >>>> +void mdev_set_virtio_ops(struct mdev_device *mdev, >>>> +=09=09=09 const struct mdev_virtio_device_ops *virtio_ops); >>>> + >>>> +#endif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E395ACA9EC7 for ; Tue, 5 Nov 2019 05:24:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2DD720869 for ; Tue, 5 Nov 2019 05:24:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2DD720869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B66F6E8F5; Tue, 5 Nov 2019 05:24:27 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2589E6E8F7 for ; Tue, 5 Nov 2019 05:24:26 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-281-9DP0etJzPRutiF5l4L2myw-1; Tue, 05 Nov 2019 00:24:20 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CEFF8017DD; Tue, 5 Nov 2019 05:24:16 +0000 (UTC) Received: from [10.72.12.252] (ovpn-12-252.pek2.redhat.com [10.72.12.252]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85B7F5D9CD; Tue, 5 Nov 2019 05:22:58 +0000 (UTC) Subject: Re: [PATCH V7 4/6] mdev: introduce virtio device and its device ops To: Alex Williamson References: <20191104123952.17276-1-jasowang@redhat.com> <20191104123952.17276-5-jasowang@redhat.com> <20191104145024.5e437765@x1.home> <1faf4f36-3f79-2e15-3f61-c406d68240ab@redhat.com> <20191104213920.59d356a3@x1.home> From: Jason Wang Message-ID: <970f2107-2677-6578-ce99-65083716d04d@redhat.com> Date: Tue, 5 Nov 2019 13:22:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191104213920.59d356a3@x1.home> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 9DP0etJzPRutiF5l4L2myw-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572931465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=azZWRjG24KLaqLmrGvXAAipfORyjp6MDEKFPlBiuBE8=; b=TRvz41Z4pB9gsiElFeKOellNd69BUlLI/uvRhP9MewmusFycPhxhW92zFkvrrxa2dVi6QH WAuHMBGVA+fmLS/5a7w7MuP2+z9vCr6J5oNDlVgfE/y4pmN9HYWsnOqFRheFhhGKsib/le n+v2Znx1hCmVBSlbfTaUPrasWbaUrY0= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com, kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie, heiko.carstens@de.ibm.com, kevin.tian@intel.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kwankhede@nvidia.com, rob.miller@broadcom.com, linux-s390@vger.kernel.org, sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, cunming.liang@intel.com, zhi.a.wang@intel.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com, xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com, intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com, oberpar@linux.ibm.com, tiwei.bie@intel.com, netdev@vger.kernel.org, cohuck@redhat.com, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191105052250.2HDjL1cOBfLgt_7ApH-o5YXSElpmQ-eqK0BZ-X13MXQ@z> Ck9uIDIwMTkvMTEvNSDkuIvljYgxMjozOSwgQWxleCBXaWxsaWFtc29uIHdyb3RlOgo+IE9uIFR1 ZSwgNSBOb3YgMjAxOSAxMTo1Mjo0MSArMDgwMAo+IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhh dC5jb20+IHdyb3RlOgo+Cj4+IE9uIDIwMTkvMTEvNSDkuIrljYg1OjUwLCBBbGV4IFdpbGxpYW1z b24gd3JvdGU6Cj4+PiBPbiBNb24sICA0IE5vdiAyMDE5IDIwOjM5OjUwICswODAwCj4+PiBKYXNv biBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPj4+ICAgCj4+Pj4gVGhpcyBwYXRj aCBpbXBsZW1lbnRzIGJhc2ljIHN1cHBvcnQgZm9yIG1kZXYgZHJpdmVyIHRoYXQgc3VwcG9ydHMK Pj4+PiB2aXJ0aW8gdHJhbnNwb3J0IGZvciBrZXJuZWwgdmlydGlvIGRyaXZlci4KPj4+Pgo+Pj4+ IFNpZ25lZC1vZmYtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4+Pj4gLS0t Cj4+Pj4gICAgZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMgICAgfCAgMjAgKysrKwo+Pj4+ ICAgIGRyaXZlcnMvdmZpby9tZGV2L21kZXZfcHJpdmF0ZS5oIHwgICAyICsKPj4+PiAgICBpbmNs dWRlL2xpbnV4L21kZXYuaCAgICAgICAgICAgICB8ICAgNiArKwo+Pj4+ICAgIGluY2x1ZGUvbGlu dXgvbWRldl92aXJ0aW9fb3BzLmggIHwgMTY2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKPj4+PiAgICA0IGZpbGVzIGNoYW5nZWQsIDE5NCBpbnNlcnRpb25zKCspCj4+Pj4gICAgY3Jl YXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbWRldl92aXJ0aW9fb3BzLmgKPj4+Pgo+Pj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2NvcmUuYyBiL2RyaXZlcnMvdmZp by9tZGV2L21kZXZfY29yZS5jCj4+Pj4gaW5kZXggOGQ1NzlkN2VkODJmLi45NWVlNDEyNmZmOWMg MTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMKPj4+PiArKysg Yi9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2NvcmUuYwo+Pj4+IEBAIC03Niw2ICs3NiwyNiBAQCBj b25zdCBzdHJ1Y3QgbWRldl92ZmlvX2RldmljZV9vcHMgKm1kZXZfZ2V0X3ZmaW9fb3BzKHN0cnVj dCBtZGV2X2RldmljZSAqbWRldikKPj4+PiAgICB9Cj4+Pj4gICAgRVhQT1JUX1NZTUJPTChtZGV2 X2dldF92ZmlvX29wcyk7Cj4+Pj4gICAgCj4+Pj4gKy8qIFNwZWNpZnkgdGhlIHZpcnRpbyBkZXZp Y2Ugb3BzIGZvciB0aGUgbWRldiBkZXZpY2UsIHRoaXMKPj4+PiArICogbXVzdCBiZSBjYWxsZWQg ZHVyaW5nIGNyZWF0ZSgpIGNhbGxiYWNrIGZvciB2aXJ0aW8gbWRldiBkZXZpY2UuCj4+Pj4gKyAq Lwo+Pj4gQ29tbWVudCBzdHlsZS4KPj4KPj4gV2lsbCBmaXguCj4+Cj4+Cj4+PiAgIAo+Pj4+ICt2 b2lkIG1kZXZfc2V0X3ZpcnRpb19vcHMoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LAo+Pj4+ICsJ CQkgY29uc3Qgc3RydWN0IG1kZXZfdmlydGlvX2RldmljZV9vcHMgKnZpcnRpb19vcHMpCj4+Pj4g K3sKPj4+PiArCW1kZXZfc2V0X2NsYXNzKG1kZXYsIE1ERVZfQ0xBU1NfSURfVklSVElPKTsKPj4+ PiArCW1kZXYtPnZpcnRpb19vcHMgPSB2aXJ0aW9fb3BzOwo+Pj4+ICt9Cj4+Pj4gK0VYUE9SVF9T WU1CT0wobWRldl9zZXRfdmlydGlvX29wcyk7Cj4+Pj4gKwo+Pj4+ICsvKiBHZXQgdGhlIHZpcnRp byBkZXZpY2Ugb3BzIGZvciB0aGUgbWRldiBkZXZpY2UuICovCj4+Pj4gK2NvbnN0IHN0cnVjdCBt ZGV2X3ZpcnRpb19kZXZpY2Vfb3BzICoKPj4+PiArbWRldl9nZXRfdmlydGlvX29wcyhzdHJ1Y3Qg bWRldl9kZXZpY2UgKm1kZXYpCj4+Pj4gK3sKPj4+PiArCVdBUk5fT04obWRldi0+Y2xhc3NfaWQg IT0gTURFVl9DTEFTU19JRF9WSVJUSU8pOwo+Pj4+ICsJcmV0dXJuIG1kZXYtPnZpcnRpb19vcHM7 Cj4+Pj4gK30KPj4+PiArRVhQT1JUX1NZTUJPTChtZGV2X2dldF92aXJ0aW9fb3BzKTsKPj4+PiAr Cj4+Pj4gICAgc3RydWN0IGRldmljZSAqbWRldl9kZXYoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2 KQo+Pj4+ICAgIHsKPj4+PiAgICAJcmV0dXJuICZtZGV2LT5kZXY7Cj4+Pj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvdmZpby9tZGV2L21kZXZfcHJpdmF0ZS5oIGIvZHJpdmVycy92ZmlvL21kZXYvbWRl dl9wcml2YXRlLmgKPj4+PiBpbmRleCA0MTEyMjczNzM2MjUuLjJjNzRkZDAzMjQwOSAxMDA2NDQK Pj4+PiAtLS0gYS9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X3ByaXZhdGUuaAo+Pj4+ICsrKyBiL2Ry aXZlcnMvdmZpby9tZGV2L21kZXZfcHJpdmF0ZS5oCj4+Pj4gQEAgLTExLDYgKzExLDcgQEAKPj4+ PiAgICAjZGVmaW5lIE1ERVZfUFJJVkFURV9ICj4+Pj4gICAgCj4+Pj4gICAgI2luY2x1ZGUgPGxp bnV4L21kZXZfdmZpb19vcHMuaD4KPj4+PiArI2luY2x1ZGUgPGxpbnV4L21kZXZfdmlydGlvX29w cy5oPgo+Pj4+ICAgIAo+Pj4+ICAgIGludCAgbWRldl9idXNfcmVnaXN0ZXIodm9pZCk7Cj4+Pj4g ICAgdm9pZCBtZGV2X2J1c191bnJlZ2lzdGVyKHZvaWQpOwo+Pj4+IEBAIC0zOCw2ICszOSw3IEBA IHN0cnVjdCBtZGV2X2RldmljZSB7Cj4+Pj4gICAgCXUxNiBjbGFzc19pZDsKPj4+PiAgICAJdW5p b24gewo+Pj4+ICAgIAkJY29uc3Qgc3RydWN0IG1kZXZfdmZpb19kZXZpY2Vfb3BzICp2ZmlvX29w czsKPj4+PiArCQljb25zdCBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyAqdmlydGlvX29w czsKPj4+PiAgICAJfTsKPj4+PiAgICB9Owo+Pj4+ICAgIAo+Pj4+IGRpZmYgLS1naXQgYS9pbmNs dWRlL2xpbnV4L21kZXYuaCBiL2luY2x1ZGUvbGludXgvbWRldi5oCj4+Pj4gaW5kZXggOWUzNzUw NmQxOTg3Li5mM2Q3NWE2MGMyYjUgMTAwNjQ0Cj4+Pj4gLS0tIGEvaW5jbHVkZS9saW51eC9tZGV2 LmgKPj4+PiArKysgYi9pbmNsdWRlL2xpbnV4L21kZXYuaAo+Pj4+IEBAIC0xNyw2ICsxNyw3IEBA Cj4+Pj4gICAgCj4+Pj4gICAgc3RydWN0IG1kZXZfZGV2aWNlOwo+Pj4+ICAgIHN0cnVjdCBtZGV2 X3ZmaW9fZGV2aWNlX29wczsKPj4+PiArc3RydWN0IG1kZXZfdmlydGlvX2RldmljZV9vcHM7Cj4+ Pj4gICAgCj4+Pj4gICAgLyoKPj4+PiAgICAgKiBDYWxsZWQgYnkgdGhlIHBhcmVudCBkZXZpY2Ug ZHJpdmVyIHRvIHNldCB0aGUgZGV2aWNlIHdoaWNoIHJlcHJlc2VudHMKPj4+PiBAQCAtMTEyLDYg KzExMywxMCBAQCB2b2lkIG1kZXZfc2V0X2NsYXNzKHN0cnVjdCBtZGV2X2RldmljZSAqbWRldiwg dTE2IGlkKTsKPj4+PiAgICB2b2lkIG1kZXZfc2V0X3ZmaW9fb3BzKHN0cnVjdCBtZGV2X2Rldmlj ZSAqbWRldiwKPj4+PiAgICAJCSAgICAgICBjb25zdCBzdHJ1Y3QgbWRldl92ZmlvX2RldmljZV9v cHMgKnZmaW9fb3BzKTsKPj4+PiAgICBjb25zdCBzdHJ1Y3QgbWRldl92ZmlvX2RldmljZV9vcHMg Km1kZXZfZ2V0X3ZmaW9fb3BzKHN0cnVjdCBtZGV2X2RldmljZSAqbWRldik7Cj4+Pj4gK3ZvaWQg bWRldl9zZXRfdmlydGlvX29wcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsCj4+Pj4gKwkJCSBj b25zdCBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyAqdmlydGlvX29wcyk7Cj4+Pj4gK2Nv bnN0IHN0cnVjdCBtZGV2X3ZpcnRpb19kZXZpY2Vfb3BzICoKPj4+PiArbWRldl9nZXRfdmlydGlv X29wcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICAgIAo+Pj4+ICAgIGV4dGVybiBz dHJ1Y3QgYnVzX3R5cGUgbWRldl9idXNfdHlwZTsKPj4+PiAgICAKPj4+PiBAQCAtMTI3LDYgKzEz Miw3IEBAIHN0cnVjdCBtZGV2X2RldmljZSAqbWRldl9mcm9tX2RldihzdHJ1Y3QgZGV2aWNlICpk ZXYpOwo+Pj4+ICAgIAo+Pj4+ICAgIGVudW0gewo+Pj4+ICAgIAlNREVWX0NMQVNTX0lEX1ZGSU8g PSAxLAo+Pj4+ICsJTURFVl9DTEFTU19JRF9WSVJUSU8gPSAyLAo+Pj4+ICAgIAkvKiBOZXcgZW50 cmllcyBtdXN0IGJlIGFkZGVkIGhlcmUgKi8KPj4+PiAgICB9Owo+Pj4+ICAgIAo+Pj4+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2xpbnV4L21kZXZfdmlydGlvX29wcy5oIGIvaW5jbHVkZS9saW51eC9t ZGV2X3ZpcnRpb19vcHMuaAo+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+Pj4gaW5kZXggMDAw MDAwMDAwMDAwLi4wZGNhZTdmYTMxZTUKPj4+PiAtLS0gL2Rldi9udWxsCj4+Pj4gKysrIGIvaW5j bHVkZS9saW51eC9tZGV2X3ZpcnRpb19vcHMuaAo+Pj4+IEBAIC0wLDAgKzEsMTY2IEBACj4+Pj4g Ky8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wLW9ubHkgKi8KPj4+PiArLyoKPj4+ PiArICogVmlydGlvIG1lZGlhdGVkIGRldmljZSBkcml2ZXIKPj4+PiArICoKPj4+PiArICogQ29w eXJpZ2h0IDIwMTksIFJlZCBIYXQgQ29ycC4KPj4+PiArICogICAgIEF1dGhvcjogSmFzb24gV2Fu ZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4KPj4+PiArICovCj4+Pj4gKyNpZm5kZWYgTURFVl9WSVJU SU9fT1BTX0gKPj4+PiArI2RlZmluZSBNREVWX1ZJUlRJT19PUFNfSAo+Pj4+ICsKPj4+PiArI2lu Y2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+Pj4+ICsjaW5jbHVkZSA8bGludXgvbWRldi5oPgo+ Pj4+ICsjaW5jbHVkZSA8dWFwaS9saW51eC92aG9zdC5oPgo+Pj4+ICsKPj4+PiArI2RlZmluZSBW SVJUSU9fTURFVl9ERVZJQ0VfQVBJX1NUUklORwkJInZpcnRpby1tZGV2Igo+Pj4+ICsjZGVmaW5l IFZJUlRJT19NREVWX0ZfVkVSU0lPTl8xIDB4MQo+Pj4+ICsKPj4+PiArc3RydWN0IHZpcnRpb19t ZGV2X2NhbGxiYWNrIHsKPj4+PiArCWlycXJldHVybl90ICgqY2FsbGJhY2spKHZvaWQgKmRhdGEp Owo+Pj4+ICsJdm9pZCAqcHJpdmF0ZTsKPj4+PiArfTsKPj4+PiArCj4+Pj4gKy8qKgo+Pj4+ICsg KiBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyAtIFN0cnVjdHVyZSB0byBiZSByZWdpc3Rl cmVkIGZvciBlYWNoCj4+Pj4gKyAqIG1kZXYgZGV2aWNlIHRvIHJlZ2lzdGVyIHRoZSBkZXZpY2Ug Zm9yIHZpcnRpby92aG9zdCBkcml2ZXJzLgo+Pj4+ICsgKgo+Pj4+ICsgKiBUaGUgZGV2aWNlIG9w cyB0aGF0IGlzIHN1cHBvcnRlZCBieSBWSVJUSU9fTURFVl9GX1ZFUlNJT05fMSwgdGhlCj4+Pj4g KyAqIGNhbGxiYWNrcyBhcmUgbWFuZGF0b3J5IHVubGVzcyBleHBsaWNpdHkgbWVudGlvbmVkLgo+ Pj4+ICsgKgo+Pj4+ICsgKiBAZ2V0X21kZXZfZmVhdHVyZXM6CQlHZXQgYSBzZXQgb2YgYml0cyB0 aGF0IGRlbW9uc3RyYXRlCj4+Pj4gKyAqCQkJCXRoZSBjYXBhYmlsaXR5IG9mIHRoZSBtZGV2IGRl dmljZS4gTmV3Cj4+Pj4gKyAqCQkJCWZlYXR1cmUgYml0cyBtdXN0IGJlIGFkZGVkIHdoZW4KPj4+ PiArICoJCQkJaW50cm9kdWNpbmcgbmV3IGRldmljZSBvcHMuIFRoaXMKPj4+PiArICoJCQkJYWxs b3dzIHRoZSBkZXZpY2Ugb3BzIHRvIGJlIGV4dGVuZGVkCj4+Pj4gKyAqCQkJCShvbmUgZmVhdHVy ZSBjb3VsZCBoYXZlIE4gbmV3IG9wcykuCj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZp Y2UKPj4+PiArICoJCQkJUmV0dXJucyB0aGUgbWRldiBmZWF0dXJlcyAoQVBJKSBzdXBwb3J0IGJ5 Cj4+Pj4gKyAqCQkJCXRoZSBkZXZpY2UuCj4+PiBJIHN0aWxsIGRvbid0IHNlZSB0aGUgcG9pbnQg b2YgVklSVElPX01ERVZfRl9WRVJTSU9OXzEuICBJbiB3aGF0IGNhc2UKPj4+IHdvdWxkIGl0IG5v dCBiZSBzZXQ/Cj4+Cj4+IEl0J3MgYSBtdXN0IGZvciBjdXJyZW50IGRyaXZlciBpbXBsZW1lbnRh dGlvbi4KPj4KPj4KPj4+IFdoYXQgd291bGQgaXQgaW5kaWNhdGUgdG8gdGhlIGNhbGxlciBpZiBp dCB3ZXJlCj4+PiBub3Qgc2V0PyAgVGhlIGV4aXN0ZW5jZSBvZiB0aGlzIGludGVyZmFjZSBzZWVt cyB0byBpbmRpY2F0ZSB2ZXJzaW9uIDEuCj4+Cj4+IFRoZSBpZGVhIGlzIHdoZW4gVklSVElPX01E RV9GX1ZFUlNJT05fMSBpcyBhZHZlcnRpc2VkLCBkcml2ZXIgd2lsbAo+PiBhc3N1bWUgYWxsIHRo ZSBtYW5kYXRvcnkgY2FsbGJhY2tzIGZvciB0aGlzIGZlYXR1cmUgd2VyZSBpbXBsZW1lbnRlZC4K Pj4gVGhlbiB0aGVyZSdzIG5vIG5lZWQgdG8gY2hlY2sgdGhlIGV4aXN0ZW5jZSBvZiBlYWNoIGNh bGxiYWNrLgo+IEJ1dCB0aGlzIGlzIHJlZHVuZGFudCB0byBNREVWX0NMQVNTX0lEX1ZJUlRJTywg d2hpY2ggbXVzdCBpbXBseSB0aGUKPiBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyBvciBl bHNlIHdlIGhhdmUgbm8gaGFuZHNoYWtlIGJldHdlZW4gdGhlCj4gbWRldiBkZXZpY2UgYW5kIHRo ZSBtZGV2IGJ1cyBkcml2ZXIuICBFc3NlbnRpYWxseSB0aGlzIGNyZWF0ZXMgYSBmbGFnCj4gdGhh dCBzYXlzIHRoZXJlIGFyZSBubyBmbGFncywgd2hpY2ggaXMgdXNlbGVzcy4gIEkgY2FuJ3Qgc2Vl IHdoeQo+IGNoZWNraW5nIGZlYXR1cmUgYml0cyBoZXJlIGlzIHByZWZlcmFibGUgdG8gY2hlY2tp bmcgY2FsbGJhY2tzLgoKCk9rLCBzbyBJIHRoaW5rIHRoZSBwb2ludCBpcyB0aGF0IHdlIGNhbiBh c3N1bWUgdGhlIGV4aXN0ZW5jZSBmb3Igc29tZSAKY2FsbGJhY2tzIGZyb20gdGhlIHN0YXJ0LgoK Cj4KPj4+IEknbSBhbHNvIHN0aWxsIHVuY2xlYXIgaG93IGRldmljZSBvcHMgZ2V0cyBleHRlbmRl ZCwgY2FuIHlvdSBnaXZlIHNvbWUKPj4+IGV4YW1wbGVzPyAgUGFydGljdWxhcmx5LCBpZiBmZWF0 dXJlIEEgYW5kIGZlYXR1cmUgQiBib3RoIGFkZCBkZXZpY2Ugb3BzCj4+PiBjYWxsYmFja3MsIGlz IHRoZSB2ZW5kb3IgYWxsb3dlZCB0byBzdXBwb3J0IEIgYnV0IG5vdCBBLCBhbmQgZG9lcyB0aGF0 Cj4+PiBpbXBseSB0aGVpciBkZXZpY2Ugb3BzIHN0cnVjdHVyZSBpbmNsdWRlcyBjYWxsYmFja3Mg Zm9yIEEgYnV0IHRoZXkncmUKPj4+IHVudXNlZD8KPj4KPj4gRm9yIGN1cnJlbnQgQVBJLCB0aGUg YW5zd2VyIGlzIHllcy4gU28gaWYgdmVuZG9yIG9ubHkgc3VwcG9ydCBmZWF0dXJlIEIsCj4+IGl0 IG5lZWRzIHRvIHNldCB0aGUgZGV2aWNlX29wcyB0aGF0IHN1cHBvcnQgZmVhdHVyZSBBIHRvIE5V TEwuCj4gV2hpY2ggaXMgZXhhY3RseSB3aGF0IHdlIGV4cGVjdCB0byBoYXBwZW4gd2l0aCBnZXRf Z2VuZXJhdGlvbigpIGJ1dCB3ZQo+IGNhbid0IGJlIGJvdGhlcmVkIHRvIGFkZCBhIGZlYXR1cmUg ZmxhZyBmb3IgaXQ/ICBUaGUgaW50ZXJmYWNlIGlzCj4gYWxyZWFkeSBzZWxmIGluY29uc2lzdGVu dC4KCgpGb3IgZ2V0X2dlbmVyYXRpb24oKSwgd2UgY2FuIGRvIHNpbXBseSBmYWxsYmFjayBieSBy ZXR1cm4gemVybyAobGlrZSAKd2hhdCB2aXJpdG8gY29yZSBkaWQpLiBCdXQgZm9yIG90aGVyIGZl YXR1cmUsIHdlIGNhbiBub3QgaGF2ZSBzdWNoIApmYWxsYmFjayBlYXNpbHkuCgoKPgo+Pj4gV2h5 IGRvZXNuJ3QgdGhlIHByZXZpb3VzIHBhdGNoIHRha2UgYW55IG9mIHRoaXMgaW50byBhY2NvdW50 Cj4+PiBmb3Igc3RydWN0IG1kZXZfdmZpb19kZXZpY2Vfb3BzPyAgSSB0aGluayB0aGlzIGlzIGFu IGludGVybmFsIEFQSSwKPj4+IHRoZXJlZm9yZSBpcyBpdCB3b3J0aHdoaWxlIHRvIGluY2x1ZGUg ZmVhdHVyZSBhbmQgZXh0ZW5zaW9uIHN1cHBvcnQ/Cj4+Cj4+IEknbSBub3Qgc3VyZSBpZiBWRklP IGhhcyB0aGUgcmVxdWVzdC4gSW4gdGhhdCBjYXNlIG5ldyBmZWF0dXJlcyBjb3VsZCBiZQo+PiBl eHRlbmRlZCBzaW1wbHkgdGhyb3VnaCB0cmFuc3BvcnQvYnVzIHNwZWNpZmljIHdheSAoZS5nIFBD SUUgY2FwYWJpbGl0eQo+PiBsaXN0KS4gQnV0IGluIHRoZSBjYXNlIG9mIHZpcnRpby1tZGV2LCB3 ZSBuZWVkIGludmVudCBzb21ldGhpbmcgb24gb3VyCj4+IG93bi4gSWYgdGhlIHNpbXBsZSBtYXBw aW5nIGJldHdlZW4gZmVhdHVyZXMgYW5kIGRldmljZSBvcHMgaXMgcHJvdmVkIHRvCj4+IGJlIG5v dCBzdWZmaWNpZW50IG9yIHN1Yi1vcHRpbWFsLCB3ZSBjYW4gaW50cm9kdWNlIGEgbW9yZSBzb3Bo aXN0aWNhdGVkCj4+IEFQSS4KPiBJIHRoaW5rIHRoZSBrZXkgaXMgdGhhdCBkZXZpY2Ugb3BzIGlz IG5vdCBhbiBBQkksIGlmIHdlIGFkZCBuZXcKPiBjYWxsYmFja3Mgd2UgY2FuIGV4dGVuZCB0aGUg c3RydWN0dXJlcyBvZiBhbGwgdGhlIHZlbmRvciBkcml2ZXJzIGFuZAo+IHRoZSBtZGV2IGJ1cyBk cml2ZXIgY2FuIGVpdGhlciBjaG9vc2UgdG8gdGVzdCB0aGUgY2FsbGJhY2sgYXQgcnVudGltZQo+ IG9yIHByb2JlIHRpbWUuICBJIHJlYWxseSBkb24ndCBzZWUgd2hhdCB3ZSdyZSBhY2NvbXBsaXNo aW5nIHdpdGggdGhpcwo+IGNhbGxiYWNrLgo+Cj4+Pj4gKyAqIEBnZXRfbWRldl9mZWF0dXJlczoJ CVNldCBhIHNldCBvZiBmZWF0dXJlcyB0aGF0IHdpbGwgYmUKPj4+IHMvZ2V0L3NldC8KPj4KPj4g V2lsbCBmaXguCj4+Cj4+Cj4+PiAgIAo+Pj4+ICsgKgkJCQl1c2VkIGJ5IHRoZSBkcml2ZXIuCj4+ Pj4gKyAqCQkJCUBmZWF0dXJlczogZmVhdHVyZXMgdXNlZCBieSB0aGUgZHJpdmVyCj4+Pj4gKyAq CQkJCVJldHVybnMgYm9sbGVhbjogd2hldGhlciB0aGUgZmVhdHVyZXMKPj4+IHMvYm9sbGVhbi9i b29sZWFuLwo+Pj4KPj4+IEhvdyBkb2VzIG9uZSBwcm92aWRlIGEgc2V0IG9mIGZlYXR1cmVzIHRv IHNldCBnaXZlbiB0aGlzIHByb3RvdHlwZT8KPj4+Cj4+PiBib29sICgqc2V0X21kZXZfZmVhdHVy ZSkoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2KTsKPj4+Cj4+PiBUaGlzIGlzIHN0YXJ0aW5nIHRv IGxvb2sgbGlrZSBhIGdyYWIgYmFnIG9mIGNhbGxiYWNrcywgd2hhdCBzb3J0IG9mCj4+PiBtZGV2 IGZlYXR1cmVzIHdvdWxkIHRoZSBkcml2ZXIgaGF2ZSB0aGUgYWJpbGl0eSB0byBzZXQgb24gYSBk ZXZpY2U/Cj4+Cj4+IFllcywgZS5nIGRldmljZSBzdXBwb3J0IEEsQixDLCBidXQgZHJpdmVyIHdp bGwgb25seSB1c2UgQiBhbmQgQy4KPiBDYW4geW91IGdpdmUgYSBfY29uY3JldGVfIGV4YW1wbGUg b2Ygc3VjaCBmZWF0dXJlcyB3aGVyZSB0aGUgZGV2aWNlCj4gbmVlZHMgdG8gYmUgaW5mb3JtZWQg b2Ygd2hhdCBmZWF0dXJlcyB0aGUgZHJpdmVyIHdpbGwgdXNlIHJhdGhlciB0aGFuCj4gc2ltcGx5 IG5vdCB1c2luZyB0aGVtPwoKClR3byBleGFtcGxlczoKCi0gZGlydHkgcGFnZSBsb2dnaW5nIGJ5 IGRldmljZQoKLSBjb250cm9sIHZxIHN1cHBvcnQKClNvIGRldmljZSBjYW4gY2hvb3NlIHRvIHN1 cHBvcnQgb25lIG9mIHRoZSBhYm92ZSBmZWF0dXJlcy4KCgo+ICAgVGhlcmUgYXBwZWFycyB0byBi ZSBubyB1c2UgY2FzZSBmb3IgdGhpcwo+IGN1cnJlbnRseSwgc28gSSdkIHN1Z2dlc3QgZHJvcHBp bmcgaXQuICBJZiBzdWNoIGEgZmVhdHVyZSBiZWNvbWVzCj4gbmVjZXNzYXJ5IGl0IGNhbiBiZSBh ZGRlZCBhcyBuZWVkZWQgc2luY2UgdGhpcyBpcyBhbiBpbnRlcm5hbAo+IGludGVyZmFjZS4KCgpP aywgSSB0aGluayBJIGdldCB5b3VyIHBvaW50LiBJIHdvcnJpZWQgYWJvdXQgdGhlIHZob3N0LW1k ZXYgYnV0IGFueXdheSAKdGhvc2UgQVBJIGlzIG5vdCBleHBvc2VkIHRvIHVzZXIgZGlyZWN0bHku IEkgd2lsbCBkcm9wIHRob3NlIGluIG5leHQgCnZlcnNpb24uCgoKPiAgICBBbHNvIG5vdCBzdXJl IG15IHBvaW50IGFib3ZlIHdhcyB3ZWxsIGNvbnZleWVkLCB0aGUKPiBwcm90b3R5cGUgZG9lc24n dCBwcm92aWRlIGEgZmVhdHVyZSBhcmcgaW4gb3JkZXIgdG8gc2V0IGZlYXR1cmVzLiAgVGhlCj4g Y29tbWVudCBhbHNvIGluZGljYXRlcyB3ZSBjYW4gc2V0IGEgc2V0IG9mIGZlYXR1cmVzIChpZS4g bXVsdGlwbGUpLCBidXQKPiBpdCdzIG5vdCB3ZWxsIHNwZWNpZmllZCB3aGF0IGEgZmFpbHVyZSBp bmRpY2F0ZXMgb3Igd2h5IHdlJ2QgdXNlIGEKPiBib29sZWFuIHRvIGluZGljYXRlIGEgZmFpbHVy ZSB2ZXJzdXMgYW4gZXJybm8gd2hlcmUgd2UgY291bGQgaW50ZXJwcmV0Cj4gdGhlIHJldHVybiBj b2RlLiAgQm90aCB0aGVzZSBjYWxsYmFja3Mgc2VlbSBsaWtlIHBsYWNlaG9sZGVycywgd2hpY2gK PiBzaG91bGQgYmUgdW5uZWNlc3NhcnkgYXMgdGhpcyBpcyBzaW1wbHkgYW4gaW50ZXJuYWwgQVBJ IGJldHdlZW4KPiB2aXJ0aW8tbWRldiB2ZW5kb3IgZHJpdmVycyBhbmQgdGhlIGJ1cyBkcml2ZXIu ICBUaGFua3MsCgoKSSBzZWUuCgpUaGFua3MKCgo+Cj4gQWxleAo+Cj4+PiBOb3RlIHRoYXQgdGhp cyBpcyBub3QgbGlzdGVkIGFzIG9wdGlvbmFsLCBidXQgdGhlIHNhbXBsZSBkcml2ZXIgZG9lc24n dAo+Pj4gaW1wbGVtZW50IGl0IDotXAo+Pgo+PiBNeSBiYWQsIHdpbGwgZml4IHRoaXMuCj4+Cj4+ IFRoYW5rcwo+Pgo+Pgo+Pj4gVGhhbmtzLAo+Pj4KPj4+IEFsZXgKPj4+ICAgCj4+Pj4gKyAqCQkJ CWlzIGFjY2VwdGVkIGJ5IHRoZSBkZXZpY2UuCj4+Pj4gKyAqIEBzZXRfdnFfYWRkcmVzczoJCVNl dCB0aGUgYWRkcmVzcyBvZiB2aXJ0cXVldWUKPj4+PiArICoJCQkJQG1kZXY6IG1lZGlhdGVkIGRl dmljZQo+Pj4+ICsgKgkJCQlAaWR4OiB2aXJ0cXVldWUgaW5kZXgKPj4+PiArICoJCQkJQGRlc2Nf YXJlYTogYWRkcmVzcyBvZiBkZXNjIGFyZWEKPj4+PiArICoJCQkJQGRyaXZlcl9hcmVhOiBhZGRy ZXNzIG9mIGRyaXZlciBhcmVhCj4+Pj4gKyAqCQkJCUBkZXZpY2VfYXJlYTogYWRkcmVzcyBvZiBk ZXZpY2UgYXJlYQo+Pj4+ICsgKgkJCQlSZXR1cm5zIGludGVnZXI6IHN1Y2Nlc3MgKDApIG9yIGVy cm9yICg8IDApCj4+Pj4gKyAqIEBzZXRfdnFfbnVtOgkJCVNldCB0aGUgc2l6ZSBvZiB2aXJ0cXVl dWUKPj4+PiArICoJCQkJQG1kZXY6IG1lZGlhdGVkIGRldmljZQo+Pj4+ICsgKgkJCQlAaWR4OiB2 aXJ0cXVldWUgaW5kZXgKPj4+PiArICoJCQkJQG51bTogdGhlIHNpemUgb2YgdmlydHF1ZXVlCj4+ Pj4gKyAqIEBraWNrX3ZxOgkJCUtpY2sgdGhlIHZpcnRxdWV1ZQo+Pj4+ICsgKgkJCQlAbWRldjog bWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBpZHg6IHZpcnRxdWV1ZSBpbmRleAo+Pj4+ICsg KiBAc2V0X3ZxX2NiOgkJCVNldCB0aGUgaW50ZXJydXB0IGNhbGxiYWNrIGZ1bmN0aW9uIGZvcgo+ Pj4+ICsgKgkJCQlhIHZpcnRxdWV1ZQo+Pj4+ICsgKgkJCQlAbWRldjogbWVkaWF0ZWQgZGV2aWNl Cj4+Pj4gKyAqCQkJCUBpZHg6IHZpcnRxdWV1ZSBpbmRleAo+Pj4+ICsgKgkJCQlAY2I6IHZpcnRp by1tZGV2IGludGVycnVwdCBjYWxsYmFjayBzdHJ1Y3R1cmUKPj4+PiArICogQHNldF92cV9yZWFk eToJCVNldCByZWFkeSBzdGF0dXMgZm9yIGEgdmlydHF1ZXVlCj4+Pj4gKyAqCQkJCUBtZGV2OiBt ZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJQGlkeDogdmlydHF1ZXVlIGluZGV4Cj4+Pj4gKyAq CQkJCUByZWFkeTogcmVhZHkgKHRydWUpIG5vdCByZWFkeShmYWxzZSkKPj4+PiArICogQGdldF92 cV9yZWFkeToJCUdldCByZWFkeSBzdGF0dXMgZm9yIGEgdmlydHF1ZXVlCj4+Pj4gKyAqCQkJCUBt ZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJQGlkeDogdmlydHF1ZXVlIGluZGV4Cj4+ Pj4gKyAqCQkJCVJldHVybnMgYm9vbGVhbjogcmVhZHkgKHRydWUpIG9yIG5vdCAoZmFsc2UpCj4+ Pj4gKyAqIEBzZXRfdnFfc3RhdGU6CQlTZXQgdGhlIHN0YXRlIGZvciBhIHZpcnRxdWV1ZQo+Pj4+ ICsgKgkJCQlAbWRldjogbWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBpZHg6IHZpcnRxdWV1 ZSBpbmRleAo+Pj4+ICsgKgkJCQlAc3RhdGU6IHZpcnRxdWV1ZSBzdGF0ZSAobGFzdF9hdmFpbF9p ZHgpCj4+Pj4gKyAqCQkJCVJldHVybnMgaW50ZWdlcjogc3VjY2VzcyAoMCkgb3IgZXJyb3IgKDwg MCkKPj4+PiArICogQGdldF92cV9zdGF0ZToJCUdldCB0aGUgc3RhdGUgZm9yIGEgdmlydHF1ZXVl Cj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJQGlkeDogdmly dHF1ZXVlIGluZGV4Cj4+Pj4gKyAqCQkJCVJldHVybnMgdmlydHF1ZXVlIHN0YXRlIChsYXN0X2F2 YWlsX2lkeCkKPj4+PiArICogQGdldF92cV9hbGlnbjoJCUdldCB0aGUgdmlydHF1ZXVlIGFsaWdu IHJlcXVpcmVtZW50Cj4+Pj4gKyAqCQkJCWZvciB0aGUgZGV2aWNlCj4+Pj4gKyAqCQkJCUBtZGV2 OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJUmV0dXJucyB2aXJ0cXVldWUgYWxnaW4gcmVx dWlyZW1lbnQKPj4+PiArICogQGdldF9mZWF0dXJlczoJCUdldCB2aXJ0aW8gZmVhdHVyZXMgc3Vw cG9ydGVkIGJ5IHRoZSBkZXZpY2UKPj4+PiArICoJCQkJQG1kZXY6IG1lZGlhdGVkIGRldmljZQo+ Pj4+ICsgKgkJCQlSZXR1cm5zIHRoZSB2aXJ0aW8gZmVhdHVyZXMgc3VwcG9ydCBieSB0aGUKPj4+ PiArICoJCQkJZGV2aWNlCj4+Pj4gKyAqIEBzZXRfZmVhdHVyZXM6CQlTZXQgdmlydGlvIGZlYXR1 cmVzIHN1cHBvcnRlZCBieSB0aGUgZHJpdmVyCj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBk ZXZpY2UKPj4+PiArICoJCQkJQGZlYXR1cmVzOiBmZWF0dXJlIHN1cHBvcnQgYnkgdGhlIGRyaXZl cgo+Pj4+ICsgKgkJCQlSZXR1cm5zIGludGVnZXI6IHN1Y2Nlc3MgKDApIG9yIGVycm9yICg8IDAp Cj4+Pj4gKyAqIEBzZXRfY29uZmlnX2NiOgkJU2V0IHRoZSBjb25maWcgaW50ZXJydXB0IGNhbGxi YWNrCj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJQGNiOiB2 aXJ0aW8tbWRldiBpbnRlcnJ1cHQgY2FsbGJhY2sgc3RydWN0dXJlCj4+Pj4gKyAqIEBnZXRfdnFf bnVtX21heDoJCUdldCB0aGUgbWF4IHNpemUgb2YgdmlydHF1ZXVlCj4+Pj4gKyAqCQkJCUBtZGV2 OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJUmV0dXJucyB1MTY6IG1heCBzaXplIG9mIHZp cnRxdWV1ZQo+Pj4+ICsgKiBAZ2V0X2RldmljZV9pZDoJCUdldCB2aXJ0aW8gZGV2aWNlIGlkCj4+ Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJUmV0dXJucyB1MzI6 IHZpcnRpbyBkZXZpY2UgaWQKPj4+PiArICogQGdldF92ZW5kb3JfaWQ6CQlHZXQgaWQgZm9yIHRo ZSB2ZW5kb3IgdGhhdCBwcm92aWRlcyB0aGlzIGRldmljZQo+Pj4+ICsgKgkJCQlAbWRldjogbWVk aWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCVJldHVybnMgdTMyOiB2aXJ0aW8gdmVuZG9yIGlkCj4+ Pj4gKyAqIEBnZXRfc3RhdHVzOgkJCUdldCB0aGUgZGV2aWNlIHN0YXR1cwo+Pj4+ICsgKgkJCQlA bWRldjogbWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCVJldHVybnMgdTg6IHZpcnRpbyBkZXZp Y2Ugc3RhdHVzCj4+Pj4gKyAqIEBzZXRfc3RhdHVzOgkJCVNldCB0aGUgZGV2aWNlIHN0YXR1cwo+ Pj4+ICsgKgkJCQlAbWRldjogbWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBzdGF0dXM6IHZp cnRpbyBkZXZpY2Ugc3RhdHVzCj4+Pj4gKyAqIEBnZXRfY29uZmlnOgkJCVJlYWQgZnJvbSBkZXZp Y2Ugc3BlY2lmaWMgY29uZmlndXJhdGlvbiBzcGFjZQo+Pj4+ICsgKgkJCQlAbWRldjogbWVkaWF0 ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBvZmZzZXQ6IG9mZnNldCBmcm9tIHRoZSBiZWdpbm5pbmcg b2YKPj4+PiArICoJCQkJY29uZmlndXJhdGlvbiBzcGFjZQo+Pj4+ICsgKgkJCQlAYnVmOiBidWZm ZXIgdXNlZCB0byByZWFkIHRvCj4+Pj4gKyAqCQkJCUBsZW46IHRoZSBsZW5ndGggdG8gcmVhZCBm cm9tCj4+Pj4gKyAqCQkJCWNvbmZpZ3JhdGlvbiBzcGFjZQo+Pj4+ICsgKiBAc2V0X2NvbmZpZzoJ CQlXcml0ZSB0byBkZXZpY2Ugc3BlY2lmaWMgY29uZmlndXJhdGlvbiBzcGFjZQo+Pj4+ICsgKgkJ CQlAbWRldjogbWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBvZmZzZXQ6IG9mZnNldCBmcm9t IHRoZSBiZWdpbm5pbmcgb2YKPj4+PiArICoJCQkJY29uZmlndXJhdGlvbiBzcGFjZQo+Pj4+ICsg KgkJCQlAYnVmOiBidWZmZXIgdXNlZCB0byB3cml0ZSBmcm9tCj4+Pj4gKyAqCQkJCUBsZW46IHRo ZSBsZW5ndGggdG8gd3JpdGUgdG8KPj4+PiArICoJCQkJY29uZmlncmF0aW9uIHNwYWNlCj4+Pj4g KyAqIEBnZXRfZ2VuZXJhdGlvbjoJCUdldCBkZXZpY2UgY29uZmlnIGdlbmVyYXRvbiAob3B0aW9u YWwpCj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJUmV0dXJu cyB1MzI6IGRldmljZSBnZW5lcmF0aW9uCj4+Pj4gKyAqLwo+Pj4+ICtzdHJ1Y3QgbWRldl92aXJ0 aW9fZGV2aWNlX29wcyB7Cj4+Pj4gKwkvKiBNZGV2IGRldmljZSBvcHMgKi8KPj4+PiArCXU2NCAo KmdldF9tZGV2X2ZlYXR1cmVzKShzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICsJYm9v bCAoKnNldF9tZGV2X2ZlYXR1cmUpKHN0cnVjdCBtZGV2X2RldmljZSAqbWRldik7Cj4+Pj4gKwkv KiBWaXJ0cXVldWUgb3BzICovCj4+Pj4gKwlpbnQgKCpzZXRfdnFfYWRkcmVzcykoc3RydWN0IG1k ZXZfZGV2aWNlICptZGV2LAo+Pj4+ICsJCQkgICAgICB1MTYgaWR4LCB1NjQgZGVzY19hcmVhLCB1 NjQgZHJpdmVyX2FyZWEsCj4+Pj4gKwkJCSAgICAgIHU2NCBkZXZpY2VfYXJlYSk7Cj4+Pj4gKwl2 b2lkICgqc2V0X3ZxX251bSkoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1MTYgaWR4LCB1MzIg bnVtKTsKPj4+PiArCXZvaWQgKCpraWNrX3ZxKShzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsIHUx NiBpZHgpOwo+Pj4+ICsJdm9pZCAoKnNldF92cV9jYikoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2 LCB1MTYgaWR4LAo+Pj4+ICsJCQkgIHN0cnVjdCB2aXJ0aW9fbWRldl9jYWxsYmFjayAqY2IpOwo+ Pj4+ICsJdm9pZCAoKnNldF92cV9yZWFkeSkoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1MTYg aWR4LCBib29sIHJlYWR5KTsKPj4+PiArCWJvb2wgKCpnZXRfdnFfcmVhZHkpKHN0cnVjdCBtZGV2 X2RldmljZSAqbWRldiwgdTE2IGlkeCk7Cj4+Pj4gKwlpbnQgKCpzZXRfdnFfc3RhdGUpKHN0cnVj dCBtZGV2X2RldmljZSAqbWRldiwgdTE2IGlkeCwgdTY0IHN0YXRlKTsKPj4+PiArCXU2NCAoKmdl dF92cV9zdGF0ZSkoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1MTYgaWR4KTsKPj4+PiArCj4+ Pj4gKwkvKiBWaXJ0aW8gZGV2aWNlIG9wcyAqLwo+Pj4+ICsJdTE2ICgqZ2V0X3ZxX2FsaWduKShz dHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICsJdTY0ICgqZ2V0X2ZlYXR1cmVzKShzdHJ1 Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICsJaW50ICgqc2V0X2ZlYXR1cmVzKShzdHJ1Y3Qg bWRldl9kZXZpY2UgKm1kZXYsIHU2NCBmZWF0dXJlcyk7Cj4+Pj4gKwl2b2lkICgqc2V0X2NvbmZp Z19jYikoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LAo+Pj4+ICsJCQkgICAgICBzdHJ1Y3Qgdmly dGlvX21kZXZfY2FsbGJhY2sgKmNiKTsKPj4+PiArCXUxNiAoKmdldF92cV9udW1fbWF4KShzdHJ1 Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICsJdTMyICgqZ2V0X2RldmljZV9pZCkoc3RydWN0 IG1kZXZfZGV2aWNlICptZGV2KTsKPj4+PiArCXUzMiAoKmdldF92ZW5kb3JfaWQpKHN0cnVjdCBt ZGV2X2RldmljZSAqbWRldik7Cj4+Pj4gKwl1OCAoKmdldF9zdGF0dXMpKHN0cnVjdCBtZGV2X2Rl dmljZSAqbWRldik7Cj4+Pj4gKwl2b2lkICgqc2V0X3N0YXR1cykoc3RydWN0IG1kZXZfZGV2aWNl ICptZGV2LCB1OCBzdGF0dXMpOwo+Pj4+ICsJdm9pZCAoKmdldF9jb25maWcpKHN0cnVjdCBtZGV2 X2RldmljZSAqbWRldiwgdW5zaWduZWQgaW50IG9mZnNldCwKPj4+PiArCQkJICAgdm9pZCAqYnVm LCB1bnNpZ25lZCBpbnQgbGVuKTsKPj4+PiArCXZvaWQgKCpzZXRfY29uZmlnKShzdHJ1Y3QgbWRl dl9kZXZpY2UgKm1kZXYsIHVuc2lnbmVkIGludCBvZmZzZXQsCj4+Pj4gKwkJCSAgIGNvbnN0IHZv aWQgKmJ1ZiwgdW5zaWduZWQgaW50IGxlbik7Cj4+Pj4gKwl1MzIgKCpnZXRfZ2VuZXJhdGlvbiko c3RydWN0IG1kZXZfZGV2aWNlICptZGV2KTsKPj4+PiArfTsKPj4+PiArCj4+Pj4gK3ZvaWQgbWRl dl9zZXRfdmlydGlvX29wcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsCj4+Pj4gKwkJCSBjb25z dCBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyAqdmlydGlvX29wcyk7Cj4+Pj4gKwo+Pj4+ ICsjZW5kaWYKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC90FCA9EC7 for ; Tue, 5 Nov 2019 05:24:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACC062084D for ; Tue, 5 Nov 2019 05:24:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACC062084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DD166E8F8; Tue, 5 Nov 2019 05:24:28 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0ECFF6E8F5 for ; Tue, 5 Nov 2019 05:24:25 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-281-9DP0etJzPRutiF5l4L2myw-1; Tue, 05 Nov 2019 00:24:20 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CEFF8017DD; Tue, 5 Nov 2019 05:24:16 +0000 (UTC) Received: from [10.72.12.252] (ovpn-12-252.pek2.redhat.com [10.72.12.252]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85B7F5D9CD; Tue, 5 Nov 2019 05:22:58 +0000 (UTC) To: Alex Williamson References: <20191104123952.17276-1-jasowang@redhat.com> <20191104123952.17276-5-jasowang@redhat.com> <20191104145024.5e437765@x1.home> <1faf4f36-3f79-2e15-3f61-c406d68240ab@redhat.com> <20191104213920.59d356a3@x1.home> From: Jason Wang Message-ID: <970f2107-2677-6578-ce99-65083716d04d@redhat.com> Date: Tue, 5 Nov 2019 13:22:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191104213920.59d356a3@x1.home> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 9DP0etJzPRutiF5l4L2myw-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572931465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=azZWRjG24KLaqLmrGvXAAipfORyjp6MDEKFPlBiuBE8=; b=TRvz41Z4pB9gsiElFeKOellNd69BUlLI/uvRhP9MewmusFycPhxhW92zFkvrrxa2dVi6QH WAuHMBGVA+fmLS/5a7w7MuP2+z9vCr6J5oNDlVgfE/y4pmN9HYWsnOqFRheFhhGKsib/le n+v2Znx1hCmVBSlbfTaUPrasWbaUrY0= Subject: Re: [Intel-gfx] [PATCH V7 4/6] mdev: introduce virtio device and its device ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com, kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie, heiko.carstens@de.ibm.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kwankhede@nvidia.com, rob.miller@broadcom.com, linux-s390@vger.kernel.org, sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, cunming.liang@intel.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, intel-gfx@lists.freedesktop.org, xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com, intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com, oberpar@linux.ibm.com, tiwei.bie@intel.com, netdev@vger.kernel.org, cohuck@redhat.com, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191105052250.hXmb2w5XSA1_SzB6cjqrShagR02vXlHzaXHdLA0NIkY@z> Ck9uIDIwMTkvMTEvNSDkuIvljYgxMjozOSwgQWxleCBXaWxsaWFtc29uIHdyb3RlOgo+IE9uIFR1 ZSwgNSBOb3YgMjAxOSAxMTo1Mjo0MSArMDgwMAo+IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhh dC5jb20+IHdyb3RlOgo+Cj4+IE9uIDIwMTkvMTEvNSDkuIrljYg1OjUwLCBBbGV4IFdpbGxpYW1z b24gd3JvdGU6Cj4+PiBPbiBNb24sICA0IE5vdiAyMDE5IDIwOjM5OjUwICswODAwCj4+PiBKYXNv biBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3cm90ZToKPj4+ICAgCj4+Pj4gVGhpcyBwYXRj aCBpbXBsZW1lbnRzIGJhc2ljIHN1cHBvcnQgZm9yIG1kZXYgZHJpdmVyIHRoYXQgc3VwcG9ydHMK Pj4+PiB2aXJ0aW8gdHJhbnNwb3J0IGZvciBrZXJuZWwgdmlydGlvIGRyaXZlci4KPj4+Pgo+Pj4+ IFNpZ25lZC1vZmYtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4+Pj4gLS0t Cj4+Pj4gICAgZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMgICAgfCAgMjAgKysrKwo+Pj4+ ICAgIGRyaXZlcnMvdmZpby9tZGV2L21kZXZfcHJpdmF0ZS5oIHwgICAyICsKPj4+PiAgICBpbmNs dWRlL2xpbnV4L21kZXYuaCAgICAgICAgICAgICB8ICAgNiArKwo+Pj4+ICAgIGluY2x1ZGUvbGlu dXgvbWRldl92aXJ0aW9fb3BzLmggIHwgMTY2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKPj4+PiAgICA0IGZpbGVzIGNoYW5nZWQsIDE5NCBpbnNlcnRpb25zKCspCj4+Pj4gICAgY3Jl YXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbWRldl92aXJ0aW9fb3BzLmgKPj4+Pgo+Pj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2NvcmUuYyBiL2RyaXZlcnMvdmZp by9tZGV2L21kZXZfY29yZS5jCj4+Pj4gaW5kZXggOGQ1NzlkN2VkODJmLi45NWVlNDEyNmZmOWMg MTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMKPj4+PiArKysg Yi9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X2NvcmUuYwo+Pj4+IEBAIC03Niw2ICs3NiwyNiBAQCBj b25zdCBzdHJ1Y3QgbWRldl92ZmlvX2RldmljZV9vcHMgKm1kZXZfZ2V0X3ZmaW9fb3BzKHN0cnVj dCBtZGV2X2RldmljZSAqbWRldikKPj4+PiAgICB9Cj4+Pj4gICAgRVhQT1JUX1NZTUJPTChtZGV2 X2dldF92ZmlvX29wcyk7Cj4+Pj4gICAgCj4+Pj4gKy8qIFNwZWNpZnkgdGhlIHZpcnRpbyBkZXZp Y2Ugb3BzIGZvciB0aGUgbWRldiBkZXZpY2UsIHRoaXMKPj4+PiArICogbXVzdCBiZSBjYWxsZWQg ZHVyaW5nIGNyZWF0ZSgpIGNhbGxiYWNrIGZvciB2aXJ0aW8gbWRldiBkZXZpY2UuCj4+Pj4gKyAq Lwo+Pj4gQ29tbWVudCBzdHlsZS4KPj4KPj4gV2lsbCBmaXguCj4+Cj4+Cj4+PiAgIAo+Pj4+ICt2 b2lkIG1kZXZfc2V0X3ZpcnRpb19vcHMoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LAo+Pj4+ICsJ CQkgY29uc3Qgc3RydWN0IG1kZXZfdmlydGlvX2RldmljZV9vcHMgKnZpcnRpb19vcHMpCj4+Pj4g K3sKPj4+PiArCW1kZXZfc2V0X2NsYXNzKG1kZXYsIE1ERVZfQ0xBU1NfSURfVklSVElPKTsKPj4+ PiArCW1kZXYtPnZpcnRpb19vcHMgPSB2aXJ0aW9fb3BzOwo+Pj4+ICt9Cj4+Pj4gK0VYUE9SVF9T WU1CT0wobWRldl9zZXRfdmlydGlvX29wcyk7Cj4+Pj4gKwo+Pj4+ICsvKiBHZXQgdGhlIHZpcnRp byBkZXZpY2Ugb3BzIGZvciB0aGUgbWRldiBkZXZpY2UuICovCj4+Pj4gK2NvbnN0IHN0cnVjdCBt ZGV2X3ZpcnRpb19kZXZpY2Vfb3BzICoKPj4+PiArbWRldl9nZXRfdmlydGlvX29wcyhzdHJ1Y3Qg bWRldl9kZXZpY2UgKm1kZXYpCj4+Pj4gK3sKPj4+PiArCVdBUk5fT04obWRldi0+Y2xhc3NfaWQg IT0gTURFVl9DTEFTU19JRF9WSVJUSU8pOwo+Pj4+ICsJcmV0dXJuIG1kZXYtPnZpcnRpb19vcHM7 Cj4+Pj4gK30KPj4+PiArRVhQT1JUX1NZTUJPTChtZGV2X2dldF92aXJ0aW9fb3BzKTsKPj4+PiAr Cj4+Pj4gICAgc3RydWN0IGRldmljZSAqbWRldl9kZXYoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2 KQo+Pj4+ICAgIHsKPj4+PiAgICAJcmV0dXJuICZtZGV2LT5kZXY7Cj4+Pj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvdmZpby9tZGV2L21kZXZfcHJpdmF0ZS5oIGIvZHJpdmVycy92ZmlvL21kZXYvbWRl dl9wcml2YXRlLmgKPj4+PiBpbmRleCA0MTEyMjczNzM2MjUuLjJjNzRkZDAzMjQwOSAxMDA2NDQK Pj4+PiAtLS0gYS9kcml2ZXJzL3ZmaW8vbWRldi9tZGV2X3ByaXZhdGUuaAo+Pj4+ICsrKyBiL2Ry aXZlcnMvdmZpby9tZGV2L21kZXZfcHJpdmF0ZS5oCj4+Pj4gQEAgLTExLDYgKzExLDcgQEAKPj4+ PiAgICAjZGVmaW5lIE1ERVZfUFJJVkFURV9ICj4+Pj4gICAgCj4+Pj4gICAgI2luY2x1ZGUgPGxp bnV4L21kZXZfdmZpb19vcHMuaD4KPj4+PiArI2luY2x1ZGUgPGxpbnV4L21kZXZfdmlydGlvX29w cy5oPgo+Pj4+ICAgIAo+Pj4+ICAgIGludCAgbWRldl9idXNfcmVnaXN0ZXIodm9pZCk7Cj4+Pj4g ICAgdm9pZCBtZGV2X2J1c191bnJlZ2lzdGVyKHZvaWQpOwo+Pj4+IEBAIC0zOCw2ICszOSw3IEBA IHN0cnVjdCBtZGV2X2RldmljZSB7Cj4+Pj4gICAgCXUxNiBjbGFzc19pZDsKPj4+PiAgICAJdW5p b24gewo+Pj4+ICAgIAkJY29uc3Qgc3RydWN0IG1kZXZfdmZpb19kZXZpY2Vfb3BzICp2ZmlvX29w czsKPj4+PiArCQljb25zdCBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyAqdmlydGlvX29w czsKPj4+PiAgICAJfTsKPj4+PiAgICB9Owo+Pj4+ICAgIAo+Pj4+IGRpZmYgLS1naXQgYS9pbmNs dWRlL2xpbnV4L21kZXYuaCBiL2luY2x1ZGUvbGludXgvbWRldi5oCj4+Pj4gaW5kZXggOWUzNzUw NmQxOTg3Li5mM2Q3NWE2MGMyYjUgMTAwNjQ0Cj4+Pj4gLS0tIGEvaW5jbHVkZS9saW51eC9tZGV2 LmgKPj4+PiArKysgYi9pbmNsdWRlL2xpbnV4L21kZXYuaAo+Pj4+IEBAIC0xNyw2ICsxNyw3IEBA Cj4+Pj4gICAgCj4+Pj4gICAgc3RydWN0IG1kZXZfZGV2aWNlOwo+Pj4+ICAgIHN0cnVjdCBtZGV2 X3ZmaW9fZGV2aWNlX29wczsKPj4+PiArc3RydWN0IG1kZXZfdmlydGlvX2RldmljZV9vcHM7Cj4+ Pj4gICAgCj4+Pj4gICAgLyoKPj4+PiAgICAgKiBDYWxsZWQgYnkgdGhlIHBhcmVudCBkZXZpY2Ug ZHJpdmVyIHRvIHNldCB0aGUgZGV2aWNlIHdoaWNoIHJlcHJlc2VudHMKPj4+PiBAQCAtMTEyLDYg KzExMywxMCBAQCB2b2lkIG1kZXZfc2V0X2NsYXNzKHN0cnVjdCBtZGV2X2RldmljZSAqbWRldiwg dTE2IGlkKTsKPj4+PiAgICB2b2lkIG1kZXZfc2V0X3ZmaW9fb3BzKHN0cnVjdCBtZGV2X2Rldmlj ZSAqbWRldiwKPj4+PiAgICAJCSAgICAgICBjb25zdCBzdHJ1Y3QgbWRldl92ZmlvX2RldmljZV9v cHMgKnZmaW9fb3BzKTsKPj4+PiAgICBjb25zdCBzdHJ1Y3QgbWRldl92ZmlvX2RldmljZV9vcHMg Km1kZXZfZ2V0X3ZmaW9fb3BzKHN0cnVjdCBtZGV2X2RldmljZSAqbWRldik7Cj4+Pj4gK3ZvaWQg bWRldl9zZXRfdmlydGlvX29wcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsCj4+Pj4gKwkJCSBj b25zdCBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyAqdmlydGlvX29wcyk7Cj4+Pj4gK2Nv bnN0IHN0cnVjdCBtZGV2X3ZpcnRpb19kZXZpY2Vfb3BzICoKPj4+PiArbWRldl9nZXRfdmlydGlv X29wcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICAgIAo+Pj4+ICAgIGV4dGVybiBz dHJ1Y3QgYnVzX3R5cGUgbWRldl9idXNfdHlwZTsKPj4+PiAgICAKPj4+PiBAQCAtMTI3LDYgKzEz Miw3IEBAIHN0cnVjdCBtZGV2X2RldmljZSAqbWRldl9mcm9tX2RldihzdHJ1Y3QgZGV2aWNlICpk ZXYpOwo+Pj4+ICAgIAo+Pj4+ICAgIGVudW0gewo+Pj4+ICAgIAlNREVWX0NMQVNTX0lEX1ZGSU8g PSAxLAo+Pj4+ICsJTURFVl9DTEFTU19JRF9WSVJUSU8gPSAyLAo+Pj4+ICAgIAkvKiBOZXcgZW50 cmllcyBtdXN0IGJlIGFkZGVkIGhlcmUgKi8KPj4+PiAgICB9Owo+Pj4+ICAgIAo+Pj4+IGRpZmYg LS1naXQgYS9pbmNsdWRlL2xpbnV4L21kZXZfdmlydGlvX29wcy5oIGIvaW5jbHVkZS9saW51eC9t ZGV2X3ZpcnRpb19vcHMuaAo+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4+Pj4gaW5kZXggMDAw MDAwMDAwMDAwLi4wZGNhZTdmYTMxZTUKPj4+PiAtLS0gL2Rldi9udWxsCj4+Pj4gKysrIGIvaW5j bHVkZS9saW51eC9tZGV2X3ZpcnRpb19vcHMuaAo+Pj4+IEBAIC0wLDAgKzEsMTY2IEBACj4+Pj4g Ky8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wLW9ubHkgKi8KPj4+PiArLyoKPj4+ PiArICogVmlydGlvIG1lZGlhdGVkIGRldmljZSBkcml2ZXIKPj4+PiArICoKPj4+PiArICogQ29w eXJpZ2h0IDIwMTksIFJlZCBIYXQgQ29ycC4KPj4+PiArICogICAgIEF1dGhvcjogSmFzb24gV2Fu ZyA8amFzb3dhbmdAcmVkaGF0LmNvbT4KPj4+PiArICovCj4+Pj4gKyNpZm5kZWYgTURFVl9WSVJU SU9fT1BTX0gKPj4+PiArI2RlZmluZSBNREVWX1ZJUlRJT19PUFNfSAo+Pj4+ICsKPj4+PiArI2lu Y2x1ZGUgPGxpbnV4L2ludGVycnVwdC5oPgo+Pj4+ICsjaW5jbHVkZSA8bGludXgvbWRldi5oPgo+ Pj4+ICsjaW5jbHVkZSA8dWFwaS9saW51eC92aG9zdC5oPgo+Pj4+ICsKPj4+PiArI2RlZmluZSBW SVJUSU9fTURFVl9ERVZJQ0VfQVBJX1NUUklORwkJInZpcnRpby1tZGV2Igo+Pj4+ICsjZGVmaW5l IFZJUlRJT19NREVWX0ZfVkVSU0lPTl8xIDB4MQo+Pj4+ICsKPj4+PiArc3RydWN0IHZpcnRpb19t ZGV2X2NhbGxiYWNrIHsKPj4+PiArCWlycXJldHVybl90ICgqY2FsbGJhY2spKHZvaWQgKmRhdGEp Owo+Pj4+ICsJdm9pZCAqcHJpdmF0ZTsKPj4+PiArfTsKPj4+PiArCj4+Pj4gKy8qKgo+Pj4+ICsg KiBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyAtIFN0cnVjdHVyZSB0byBiZSByZWdpc3Rl cmVkIGZvciBlYWNoCj4+Pj4gKyAqIG1kZXYgZGV2aWNlIHRvIHJlZ2lzdGVyIHRoZSBkZXZpY2Ug Zm9yIHZpcnRpby92aG9zdCBkcml2ZXJzLgo+Pj4+ICsgKgo+Pj4+ICsgKiBUaGUgZGV2aWNlIG9w cyB0aGF0IGlzIHN1cHBvcnRlZCBieSBWSVJUSU9fTURFVl9GX1ZFUlNJT05fMSwgdGhlCj4+Pj4g KyAqIGNhbGxiYWNrcyBhcmUgbWFuZGF0b3J5IHVubGVzcyBleHBsaWNpdHkgbWVudGlvbmVkLgo+ Pj4+ICsgKgo+Pj4+ICsgKiBAZ2V0X21kZXZfZmVhdHVyZXM6CQlHZXQgYSBzZXQgb2YgYml0cyB0 aGF0IGRlbW9uc3RyYXRlCj4+Pj4gKyAqCQkJCXRoZSBjYXBhYmlsaXR5IG9mIHRoZSBtZGV2IGRl dmljZS4gTmV3Cj4+Pj4gKyAqCQkJCWZlYXR1cmUgYml0cyBtdXN0IGJlIGFkZGVkIHdoZW4KPj4+ PiArICoJCQkJaW50cm9kdWNpbmcgbmV3IGRldmljZSBvcHMuIFRoaXMKPj4+PiArICoJCQkJYWxs b3dzIHRoZSBkZXZpY2Ugb3BzIHRvIGJlIGV4dGVuZGVkCj4+Pj4gKyAqCQkJCShvbmUgZmVhdHVy ZSBjb3VsZCBoYXZlIE4gbmV3IG9wcykuCj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZp Y2UKPj4+PiArICoJCQkJUmV0dXJucyB0aGUgbWRldiBmZWF0dXJlcyAoQVBJKSBzdXBwb3J0IGJ5 Cj4+Pj4gKyAqCQkJCXRoZSBkZXZpY2UuCj4+PiBJIHN0aWxsIGRvbid0IHNlZSB0aGUgcG9pbnQg b2YgVklSVElPX01ERVZfRl9WRVJTSU9OXzEuICBJbiB3aGF0IGNhc2UKPj4+IHdvdWxkIGl0IG5v dCBiZSBzZXQ/Cj4+Cj4+IEl0J3MgYSBtdXN0IGZvciBjdXJyZW50IGRyaXZlciBpbXBsZW1lbnRh dGlvbi4KPj4KPj4KPj4+IFdoYXQgd291bGQgaXQgaW5kaWNhdGUgdG8gdGhlIGNhbGxlciBpZiBp dCB3ZXJlCj4+PiBub3Qgc2V0PyAgVGhlIGV4aXN0ZW5jZSBvZiB0aGlzIGludGVyZmFjZSBzZWVt cyB0byBpbmRpY2F0ZSB2ZXJzaW9uIDEuCj4+Cj4+IFRoZSBpZGVhIGlzIHdoZW4gVklSVElPX01E RV9GX1ZFUlNJT05fMSBpcyBhZHZlcnRpc2VkLCBkcml2ZXIgd2lsbAo+PiBhc3N1bWUgYWxsIHRo ZSBtYW5kYXRvcnkgY2FsbGJhY2tzIGZvciB0aGlzIGZlYXR1cmUgd2VyZSBpbXBsZW1lbnRlZC4K Pj4gVGhlbiB0aGVyZSdzIG5vIG5lZWQgdG8gY2hlY2sgdGhlIGV4aXN0ZW5jZSBvZiBlYWNoIGNh bGxiYWNrLgo+IEJ1dCB0aGlzIGlzIHJlZHVuZGFudCB0byBNREVWX0NMQVNTX0lEX1ZJUlRJTywg d2hpY2ggbXVzdCBpbXBseSB0aGUKPiBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyBvciBl bHNlIHdlIGhhdmUgbm8gaGFuZHNoYWtlIGJldHdlZW4gdGhlCj4gbWRldiBkZXZpY2UgYW5kIHRo ZSBtZGV2IGJ1cyBkcml2ZXIuICBFc3NlbnRpYWxseSB0aGlzIGNyZWF0ZXMgYSBmbGFnCj4gdGhh dCBzYXlzIHRoZXJlIGFyZSBubyBmbGFncywgd2hpY2ggaXMgdXNlbGVzcy4gIEkgY2FuJ3Qgc2Vl IHdoeQo+IGNoZWNraW5nIGZlYXR1cmUgYml0cyBoZXJlIGlzIHByZWZlcmFibGUgdG8gY2hlY2tp bmcgY2FsbGJhY2tzLgoKCk9rLCBzbyBJIHRoaW5rIHRoZSBwb2ludCBpcyB0aGF0IHdlIGNhbiBh c3N1bWUgdGhlIGV4aXN0ZW5jZSBmb3Igc29tZSAKY2FsbGJhY2tzIGZyb20gdGhlIHN0YXJ0LgoK Cj4KPj4+IEknbSBhbHNvIHN0aWxsIHVuY2xlYXIgaG93IGRldmljZSBvcHMgZ2V0cyBleHRlbmRl ZCwgY2FuIHlvdSBnaXZlIHNvbWUKPj4+IGV4YW1wbGVzPyAgUGFydGljdWxhcmx5LCBpZiBmZWF0 dXJlIEEgYW5kIGZlYXR1cmUgQiBib3RoIGFkZCBkZXZpY2Ugb3BzCj4+PiBjYWxsYmFja3MsIGlz IHRoZSB2ZW5kb3IgYWxsb3dlZCB0byBzdXBwb3J0IEIgYnV0IG5vdCBBLCBhbmQgZG9lcyB0aGF0 Cj4+PiBpbXBseSB0aGVpciBkZXZpY2Ugb3BzIHN0cnVjdHVyZSBpbmNsdWRlcyBjYWxsYmFja3Mg Zm9yIEEgYnV0IHRoZXkncmUKPj4+IHVudXNlZD8KPj4KPj4gRm9yIGN1cnJlbnQgQVBJLCB0aGUg YW5zd2VyIGlzIHllcy4gU28gaWYgdmVuZG9yIG9ubHkgc3VwcG9ydCBmZWF0dXJlIEIsCj4+IGl0 IG5lZWRzIHRvIHNldCB0aGUgZGV2aWNlX29wcyB0aGF0IHN1cHBvcnQgZmVhdHVyZSBBIHRvIE5V TEwuCj4gV2hpY2ggaXMgZXhhY3RseSB3aGF0IHdlIGV4cGVjdCB0byBoYXBwZW4gd2l0aCBnZXRf Z2VuZXJhdGlvbigpIGJ1dCB3ZQo+IGNhbid0IGJlIGJvdGhlcmVkIHRvIGFkZCBhIGZlYXR1cmUg ZmxhZyBmb3IgaXQ/ICBUaGUgaW50ZXJmYWNlIGlzCj4gYWxyZWFkeSBzZWxmIGluY29uc2lzdGVu dC4KCgpGb3IgZ2V0X2dlbmVyYXRpb24oKSwgd2UgY2FuIGRvIHNpbXBseSBmYWxsYmFjayBieSBy ZXR1cm4gemVybyAobGlrZSAKd2hhdCB2aXJpdG8gY29yZSBkaWQpLiBCdXQgZm9yIG90aGVyIGZl YXR1cmUsIHdlIGNhbiBub3QgaGF2ZSBzdWNoIApmYWxsYmFjayBlYXNpbHkuCgoKPgo+Pj4gV2h5 IGRvZXNuJ3QgdGhlIHByZXZpb3VzIHBhdGNoIHRha2UgYW55IG9mIHRoaXMgaW50byBhY2NvdW50 Cj4+PiBmb3Igc3RydWN0IG1kZXZfdmZpb19kZXZpY2Vfb3BzPyAgSSB0aGluayB0aGlzIGlzIGFu IGludGVybmFsIEFQSSwKPj4+IHRoZXJlZm9yZSBpcyBpdCB3b3J0aHdoaWxlIHRvIGluY2x1ZGUg ZmVhdHVyZSBhbmQgZXh0ZW5zaW9uIHN1cHBvcnQ/Cj4+Cj4+IEknbSBub3Qgc3VyZSBpZiBWRklP IGhhcyB0aGUgcmVxdWVzdC4gSW4gdGhhdCBjYXNlIG5ldyBmZWF0dXJlcyBjb3VsZCBiZQo+PiBl eHRlbmRlZCBzaW1wbHkgdGhyb3VnaCB0cmFuc3BvcnQvYnVzIHNwZWNpZmljIHdheSAoZS5nIFBD SUUgY2FwYWJpbGl0eQo+PiBsaXN0KS4gQnV0IGluIHRoZSBjYXNlIG9mIHZpcnRpby1tZGV2LCB3 ZSBuZWVkIGludmVudCBzb21ldGhpbmcgb24gb3VyCj4+IG93bi4gSWYgdGhlIHNpbXBsZSBtYXBw aW5nIGJldHdlZW4gZmVhdHVyZXMgYW5kIGRldmljZSBvcHMgaXMgcHJvdmVkIHRvCj4+IGJlIG5v dCBzdWZmaWNpZW50IG9yIHN1Yi1vcHRpbWFsLCB3ZSBjYW4gaW50cm9kdWNlIGEgbW9yZSBzb3Bo aXN0aWNhdGVkCj4+IEFQSS4KPiBJIHRoaW5rIHRoZSBrZXkgaXMgdGhhdCBkZXZpY2Ugb3BzIGlz IG5vdCBhbiBBQkksIGlmIHdlIGFkZCBuZXcKPiBjYWxsYmFja3Mgd2UgY2FuIGV4dGVuZCB0aGUg c3RydWN0dXJlcyBvZiBhbGwgdGhlIHZlbmRvciBkcml2ZXJzIGFuZAo+IHRoZSBtZGV2IGJ1cyBk cml2ZXIgY2FuIGVpdGhlciBjaG9vc2UgdG8gdGVzdCB0aGUgY2FsbGJhY2sgYXQgcnVudGltZQo+ IG9yIHByb2JlIHRpbWUuICBJIHJlYWxseSBkb24ndCBzZWUgd2hhdCB3ZSdyZSBhY2NvbXBsaXNo aW5nIHdpdGggdGhpcwo+IGNhbGxiYWNrLgo+Cj4+Pj4gKyAqIEBnZXRfbWRldl9mZWF0dXJlczoJ CVNldCBhIHNldCBvZiBmZWF0dXJlcyB0aGF0IHdpbGwgYmUKPj4+IHMvZ2V0L3NldC8KPj4KPj4g V2lsbCBmaXguCj4+Cj4+Cj4+PiAgIAo+Pj4+ICsgKgkJCQl1c2VkIGJ5IHRoZSBkcml2ZXIuCj4+ Pj4gKyAqCQkJCUBmZWF0dXJlczogZmVhdHVyZXMgdXNlZCBieSB0aGUgZHJpdmVyCj4+Pj4gKyAq CQkJCVJldHVybnMgYm9sbGVhbjogd2hldGhlciB0aGUgZmVhdHVyZXMKPj4+IHMvYm9sbGVhbi9i b29sZWFuLwo+Pj4KPj4+IEhvdyBkb2VzIG9uZSBwcm92aWRlIGEgc2V0IG9mIGZlYXR1cmVzIHRv IHNldCBnaXZlbiB0aGlzIHByb3RvdHlwZT8KPj4+Cj4+PiBib29sICgqc2V0X21kZXZfZmVhdHVy ZSkoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2KTsKPj4+Cj4+PiBUaGlzIGlzIHN0YXJ0aW5nIHRv IGxvb2sgbGlrZSBhIGdyYWIgYmFnIG9mIGNhbGxiYWNrcywgd2hhdCBzb3J0IG9mCj4+PiBtZGV2 IGZlYXR1cmVzIHdvdWxkIHRoZSBkcml2ZXIgaGF2ZSB0aGUgYWJpbGl0eSB0byBzZXQgb24gYSBk ZXZpY2U/Cj4+Cj4+IFllcywgZS5nIGRldmljZSBzdXBwb3J0IEEsQixDLCBidXQgZHJpdmVyIHdp bGwgb25seSB1c2UgQiBhbmQgQy4KPiBDYW4geW91IGdpdmUgYSBfY29uY3JldGVfIGV4YW1wbGUg b2Ygc3VjaCBmZWF0dXJlcyB3aGVyZSB0aGUgZGV2aWNlCj4gbmVlZHMgdG8gYmUgaW5mb3JtZWQg b2Ygd2hhdCBmZWF0dXJlcyB0aGUgZHJpdmVyIHdpbGwgdXNlIHJhdGhlciB0aGFuCj4gc2ltcGx5 IG5vdCB1c2luZyB0aGVtPwoKClR3byBleGFtcGxlczoKCi0gZGlydHkgcGFnZSBsb2dnaW5nIGJ5 IGRldmljZQoKLSBjb250cm9sIHZxIHN1cHBvcnQKClNvIGRldmljZSBjYW4gY2hvb3NlIHRvIHN1 cHBvcnQgb25lIG9mIHRoZSBhYm92ZSBmZWF0dXJlcy4KCgo+ICAgVGhlcmUgYXBwZWFycyB0byBi ZSBubyB1c2UgY2FzZSBmb3IgdGhpcwo+IGN1cnJlbnRseSwgc28gSSdkIHN1Z2dlc3QgZHJvcHBp bmcgaXQuICBJZiBzdWNoIGEgZmVhdHVyZSBiZWNvbWVzCj4gbmVjZXNzYXJ5IGl0IGNhbiBiZSBh ZGRlZCBhcyBuZWVkZWQgc2luY2UgdGhpcyBpcyBhbiBpbnRlcm5hbAo+IGludGVyZmFjZS4KCgpP aywgSSB0aGluayBJIGdldCB5b3VyIHBvaW50LiBJIHdvcnJpZWQgYWJvdXQgdGhlIHZob3N0LW1k ZXYgYnV0IGFueXdheSAKdGhvc2UgQVBJIGlzIG5vdCBleHBvc2VkIHRvIHVzZXIgZGlyZWN0bHku IEkgd2lsbCBkcm9wIHRob3NlIGluIG5leHQgCnZlcnNpb24uCgoKPiAgICBBbHNvIG5vdCBzdXJl IG15IHBvaW50IGFib3ZlIHdhcyB3ZWxsIGNvbnZleWVkLCB0aGUKPiBwcm90b3R5cGUgZG9lc24n dCBwcm92aWRlIGEgZmVhdHVyZSBhcmcgaW4gb3JkZXIgdG8gc2V0IGZlYXR1cmVzLiAgVGhlCj4g Y29tbWVudCBhbHNvIGluZGljYXRlcyB3ZSBjYW4gc2V0IGEgc2V0IG9mIGZlYXR1cmVzIChpZS4g bXVsdGlwbGUpLCBidXQKPiBpdCdzIG5vdCB3ZWxsIHNwZWNpZmllZCB3aGF0IGEgZmFpbHVyZSBp bmRpY2F0ZXMgb3Igd2h5IHdlJ2QgdXNlIGEKPiBib29sZWFuIHRvIGluZGljYXRlIGEgZmFpbHVy ZSB2ZXJzdXMgYW4gZXJybm8gd2hlcmUgd2UgY291bGQgaW50ZXJwcmV0Cj4gdGhlIHJldHVybiBj b2RlLiAgQm90aCB0aGVzZSBjYWxsYmFja3Mgc2VlbSBsaWtlIHBsYWNlaG9sZGVycywgd2hpY2gK PiBzaG91bGQgYmUgdW5uZWNlc3NhcnkgYXMgdGhpcyBpcyBzaW1wbHkgYW4gaW50ZXJuYWwgQVBJ IGJldHdlZW4KPiB2aXJ0aW8tbWRldiB2ZW5kb3IgZHJpdmVycyBhbmQgdGhlIGJ1cyBkcml2ZXIu ICBUaGFua3MsCgoKSSBzZWUuCgpUaGFua3MKCgo+Cj4gQWxleAo+Cj4+PiBOb3RlIHRoYXQgdGhp cyBpcyBub3QgbGlzdGVkIGFzIG9wdGlvbmFsLCBidXQgdGhlIHNhbXBsZSBkcml2ZXIgZG9lc24n dAo+Pj4gaW1wbGVtZW50IGl0IDotXAo+Pgo+PiBNeSBiYWQsIHdpbGwgZml4IHRoaXMuCj4+Cj4+ IFRoYW5rcwo+Pgo+Pgo+Pj4gVGhhbmtzLAo+Pj4KPj4+IEFsZXgKPj4+ICAgCj4+Pj4gKyAqCQkJ CWlzIGFjY2VwdGVkIGJ5IHRoZSBkZXZpY2UuCj4+Pj4gKyAqIEBzZXRfdnFfYWRkcmVzczoJCVNl dCB0aGUgYWRkcmVzcyBvZiB2aXJ0cXVldWUKPj4+PiArICoJCQkJQG1kZXY6IG1lZGlhdGVkIGRl dmljZQo+Pj4+ICsgKgkJCQlAaWR4OiB2aXJ0cXVldWUgaW5kZXgKPj4+PiArICoJCQkJQGRlc2Nf YXJlYTogYWRkcmVzcyBvZiBkZXNjIGFyZWEKPj4+PiArICoJCQkJQGRyaXZlcl9hcmVhOiBhZGRy ZXNzIG9mIGRyaXZlciBhcmVhCj4+Pj4gKyAqCQkJCUBkZXZpY2VfYXJlYTogYWRkcmVzcyBvZiBk ZXZpY2UgYXJlYQo+Pj4+ICsgKgkJCQlSZXR1cm5zIGludGVnZXI6IHN1Y2Nlc3MgKDApIG9yIGVy cm9yICg8IDApCj4+Pj4gKyAqIEBzZXRfdnFfbnVtOgkJCVNldCB0aGUgc2l6ZSBvZiB2aXJ0cXVl dWUKPj4+PiArICoJCQkJQG1kZXY6IG1lZGlhdGVkIGRldmljZQo+Pj4+ICsgKgkJCQlAaWR4OiB2 aXJ0cXVldWUgaW5kZXgKPj4+PiArICoJCQkJQG51bTogdGhlIHNpemUgb2YgdmlydHF1ZXVlCj4+ Pj4gKyAqIEBraWNrX3ZxOgkJCUtpY2sgdGhlIHZpcnRxdWV1ZQo+Pj4+ICsgKgkJCQlAbWRldjog bWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBpZHg6IHZpcnRxdWV1ZSBpbmRleAo+Pj4+ICsg KiBAc2V0X3ZxX2NiOgkJCVNldCB0aGUgaW50ZXJydXB0IGNhbGxiYWNrIGZ1bmN0aW9uIGZvcgo+ Pj4+ICsgKgkJCQlhIHZpcnRxdWV1ZQo+Pj4+ICsgKgkJCQlAbWRldjogbWVkaWF0ZWQgZGV2aWNl Cj4+Pj4gKyAqCQkJCUBpZHg6IHZpcnRxdWV1ZSBpbmRleAo+Pj4+ICsgKgkJCQlAY2I6IHZpcnRp by1tZGV2IGludGVycnVwdCBjYWxsYmFjayBzdHJ1Y3R1cmUKPj4+PiArICogQHNldF92cV9yZWFk eToJCVNldCByZWFkeSBzdGF0dXMgZm9yIGEgdmlydHF1ZXVlCj4+Pj4gKyAqCQkJCUBtZGV2OiBt ZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJQGlkeDogdmlydHF1ZXVlIGluZGV4Cj4+Pj4gKyAq CQkJCUByZWFkeTogcmVhZHkgKHRydWUpIG5vdCByZWFkeShmYWxzZSkKPj4+PiArICogQGdldF92 cV9yZWFkeToJCUdldCByZWFkeSBzdGF0dXMgZm9yIGEgdmlydHF1ZXVlCj4+Pj4gKyAqCQkJCUBt ZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJQGlkeDogdmlydHF1ZXVlIGluZGV4Cj4+ Pj4gKyAqCQkJCVJldHVybnMgYm9vbGVhbjogcmVhZHkgKHRydWUpIG9yIG5vdCAoZmFsc2UpCj4+ Pj4gKyAqIEBzZXRfdnFfc3RhdGU6CQlTZXQgdGhlIHN0YXRlIGZvciBhIHZpcnRxdWV1ZQo+Pj4+ ICsgKgkJCQlAbWRldjogbWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBpZHg6IHZpcnRxdWV1 ZSBpbmRleAo+Pj4+ICsgKgkJCQlAc3RhdGU6IHZpcnRxdWV1ZSBzdGF0ZSAobGFzdF9hdmFpbF9p ZHgpCj4+Pj4gKyAqCQkJCVJldHVybnMgaW50ZWdlcjogc3VjY2VzcyAoMCkgb3IgZXJyb3IgKDwg MCkKPj4+PiArICogQGdldF92cV9zdGF0ZToJCUdldCB0aGUgc3RhdGUgZm9yIGEgdmlydHF1ZXVl Cj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJQGlkeDogdmly dHF1ZXVlIGluZGV4Cj4+Pj4gKyAqCQkJCVJldHVybnMgdmlydHF1ZXVlIHN0YXRlIChsYXN0X2F2 YWlsX2lkeCkKPj4+PiArICogQGdldF92cV9hbGlnbjoJCUdldCB0aGUgdmlydHF1ZXVlIGFsaWdu IHJlcXVpcmVtZW50Cj4+Pj4gKyAqCQkJCWZvciB0aGUgZGV2aWNlCj4+Pj4gKyAqCQkJCUBtZGV2 OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJUmV0dXJucyB2aXJ0cXVldWUgYWxnaW4gcmVx dWlyZW1lbnQKPj4+PiArICogQGdldF9mZWF0dXJlczoJCUdldCB2aXJ0aW8gZmVhdHVyZXMgc3Vw cG9ydGVkIGJ5IHRoZSBkZXZpY2UKPj4+PiArICoJCQkJQG1kZXY6IG1lZGlhdGVkIGRldmljZQo+ Pj4+ICsgKgkJCQlSZXR1cm5zIHRoZSB2aXJ0aW8gZmVhdHVyZXMgc3VwcG9ydCBieSB0aGUKPj4+ PiArICoJCQkJZGV2aWNlCj4+Pj4gKyAqIEBzZXRfZmVhdHVyZXM6CQlTZXQgdmlydGlvIGZlYXR1 cmVzIHN1cHBvcnRlZCBieSB0aGUgZHJpdmVyCj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBk ZXZpY2UKPj4+PiArICoJCQkJQGZlYXR1cmVzOiBmZWF0dXJlIHN1cHBvcnQgYnkgdGhlIGRyaXZl cgo+Pj4+ICsgKgkJCQlSZXR1cm5zIGludGVnZXI6IHN1Y2Nlc3MgKDApIG9yIGVycm9yICg8IDAp Cj4+Pj4gKyAqIEBzZXRfY29uZmlnX2NiOgkJU2V0IHRoZSBjb25maWcgaW50ZXJydXB0IGNhbGxi YWNrCj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJQGNiOiB2 aXJ0aW8tbWRldiBpbnRlcnJ1cHQgY2FsbGJhY2sgc3RydWN0dXJlCj4+Pj4gKyAqIEBnZXRfdnFf bnVtX21heDoJCUdldCB0aGUgbWF4IHNpemUgb2YgdmlydHF1ZXVlCj4+Pj4gKyAqCQkJCUBtZGV2 OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJUmV0dXJucyB1MTY6IG1heCBzaXplIG9mIHZp cnRxdWV1ZQo+Pj4+ICsgKiBAZ2V0X2RldmljZV9pZDoJCUdldCB2aXJ0aW8gZGV2aWNlIGlkCj4+ Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJUmV0dXJucyB1MzI6 IHZpcnRpbyBkZXZpY2UgaWQKPj4+PiArICogQGdldF92ZW5kb3JfaWQ6CQlHZXQgaWQgZm9yIHRo ZSB2ZW5kb3IgdGhhdCBwcm92aWRlcyB0aGlzIGRldmljZQo+Pj4+ICsgKgkJCQlAbWRldjogbWVk aWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCVJldHVybnMgdTMyOiB2aXJ0aW8gdmVuZG9yIGlkCj4+ Pj4gKyAqIEBnZXRfc3RhdHVzOgkJCUdldCB0aGUgZGV2aWNlIHN0YXR1cwo+Pj4+ICsgKgkJCQlA bWRldjogbWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCVJldHVybnMgdTg6IHZpcnRpbyBkZXZp Y2Ugc3RhdHVzCj4+Pj4gKyAqIEBzZXRfc3RhdHVzOgkJCVNldCB0aGUgZGV2aWNlIHN0YXR1cwo+ Pj4+ICsgKgkJCQlAbWRldjogbWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBzdGF0dXM6IHZp cnRpbyBkZXZpY2Ugc3RhdHVzCj4+Pj4gKyAqIEBnZXRfY29uZmlnOgkJCVJlYWQgZnJvbSBkZXZp Y2Ugc3BlY2lmaWMgY29uZmlndXJhdGlvbiBzcGFjZQo+Pj4+ICsgKgkJCQlAbWRldjogbWVkaWF0 ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBvZmZzZXQ6IG9mZnNldCBmcm9tIHRoZSBiZWdpbm5pbmcg b2YKPj4+PiArICoJCQkJY29uZmlndXJhdGlvbiBzcGFjZQo+Pj4+ICsgKgkJCQlAYnVmOiBidWZm ZXIgdXNlZCB0byByZWFkIHRvCj4+Pj4gKyAqCQkJCUBsZW46IHRoZSBsZW5ndGggdG8gcmVhZCBm cm9tCj4+Pj4gKyAqCQkJCWNvbmZpZ3JhdGlvbiBzcGFjZQo+Pj4+ICsgKiBAc2V0X2NvbmZpZzoJ CQlXcml0ZSB0byBkZXZpY2Ugc3BlY2lmaWMgY29uZmlndXJhdGlvbiBzcGFjZQo+Pj4+ICsgKgkJ CQlAbWRldjogbWVkaWF0ZWQgZGV2aWNlCj4+Pj4gKyAqCQkJCUBvZmZzZXQ6IG9mZnNldCBmcm9t IHRoZSBiZWdpbm5pbmcgb2YKPj4+PiArICoJCQkJY29uZmlndXJhdGlvbiBzcGFjZQo+Pj4+ICsg KgkJCQlAYnVmOiBidWZmZXIgdXNlZCB0byB3cml0ZSBmcm9tCj4+Pj4gKyAqCQkJCUBsZW46IHRo ZSBsZW5ndGggdG8gd3JpdGUgdG8KPj4+PiArICoJCQkJY29uZmlncmF0aW9uIHNwYWNlCj4+Pj4g KyAqIEBnZXRfZ2VuZXJhdGlvbjoJCUdldCBkZXZpY2UgY29uZmlnIGdlbmVyYXRvbiAob3B0aW9u YWwpCj4+Pj4gKyAqCQkJCUBtZGV2OiBtZWRpYXRlZCBkZXZpY2UKPj4+PiArICoJCQkJUmV0dXJu cyB1MzI6IGRldmljZSBnZW5lcmF0aW9uCj4+Pj4gKyAqLwo+Pj4+ICtzdHJ1Y3QgbWRldl92aXJ0 aW9fZGV2aWNlX29wcyB7Cj4+Pj4gKwkvKiBNZGV2IGRldmljZSBvcHMgKi8KPj4+PiArCXU2NCAo KmdldF9tZGV2X2ZlYXR1cmVzKShzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICsJYm9v bCAoKnNldF9tZGV2X2ZlYXR1cmUpKHN0cnVjdCBtZGV2X2RldmljZSAqbWRldik7Cj4+Pj4gKwkv KiBWaXJ0cXVldWUgb3BzICovCj4+Pj4gKwlpbnQgKCpzZXRfdnFfYWRkcmVzcykoc3RydWN0IG1k ZXZfZGV2aWNlICptZGV2LAo+Pj4+ICsJCQkgICAgICB1MTYgaWR4LCB1NjQgZGVzY19hcmVhLCB1 NjQgZHJpdmVyX2FyZWEsCj4+Pj4gKwkJCSAgICAgIHU2NCBkZXZpY2VfYXJlYSk7Cj4+Pj4gKwl2 b2lkICgqc2V0X3ZxX251bSkoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1MTYgaWR4LCB1MzIg bnVtKTsKPj4+PiArCXZvaWQgKCpraWNrX3ZxKShzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsIHUx NiBpZHgpOwo+Pj4+ICsJdm9pZCAoKnNldF92cV9jYikoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2 LCB1MTYgaWR4LAo+Pj4+ICsJCQkgIHN0cnVjdCB2aXJ0aW9fbWRldl9jYWxsYmFjayAqY2IpOwo+ Pj4+ICsJdm9pZCAoKnNldF92cV9yZWFkeSkoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1MTYg aWR4LCBib29sIHJlYWR5KTsKPj4+PiArCWJvb2wgKCpnZXRfdnFfcmVhZHkpKHN0cnVjdCBtZGV2 X2RldmljZSAqbWRldiwgdTE2IGlkeCk7Cj4+Pj4gKwlpbnQgKCpzZXRfdnFfc3RhdGUpKHN0cnVj dCBtZGV2X2RldmljZSAqbWRldiwgdTE2IGlkeCwgdTY0IHN0YXRlKTsKPj4+PiArCXU2NCAoKmdl dF92cV9zdGF0ZSkoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LCB1MTYgaWR4KTsKPj4+PiArCj4+ Pj4gKwkvKiBWaXJ0aW8gZGV2aWNlIG9wcyAqLwo+Pj4+ICsJdTE2ICgqZ2V0X3ZxX2FsaWduKShz dHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICsJdTY0ICgqZ2V0X2ZlYXR1cmVzKShzdHJ1 Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICsJaW50ICgqc2V0X2ZlYXR1cmVzKShzdHJ1Y3Qg bWRldl9kZXZpY2UgKm1kZXYsIHU2NCBmZWF0dXJlcyk7Cj4+Pj4gKwl2b2lkICgqc2V0X2NvbmZp Z19jYikoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2LAo+Pj4+ICsJCQkgICAgICBzdHJ1Y3Qgdmly dGlvX21kZXZfY2FsbGJhY2sgKmNiKTsKPj4+PiArCXUxNiAoKmdldF92cV9udW1fbWF4KShzdHJ1 Y3QgbWRldl9kZXZpY2UgKm1kZXYpOwo+Pj4+ICsJdTMyICgqZ2V0X2RldmljZV9pZCkoc3RydWN0 IG1kZXZfZGV2aWNlICptZGV2KTsKPj4+PiArCXUzMiAoKmdldF92ZW5kb3JfaWQpKHN0cnVjdCBt ZGV2X2RldmljZSAqbWRldik7Cj4+Pj4gKwl1OCAoKmdldF9zdGF0dXMpKHN0cnVjdCBtZGV2X2Rl dmljZSAqbWRldik7Cj4+Pj4gKwl2b2lkICgqc2V0X3N0YXR1cykoc3RydWN0IG1kZXZfZGV2aWNl ICptZGV2LCB1OCBzdGF0dXMpOwo+Pj4+ICsJdm9pZCAoKmdldF9jb25maWcpKHN0cnVjdCBtZGV2 X2RldmljZSAqbWRldiwgdW5zaWduZWQgaW50IG9mZnNldCwKPj4+PiArCQkJICAgdm9pZCAqYnVm LCB1bnNpZ25lZCBpbnQgbGVuKTsKPj4+PiArCXZvaWQgKCpzZXRfY29uZmlnKShzdHJ1Y3QgbWRl dl9kZXZpY2UgKm1kZXYsIHVuc2lnbmVkIGludCBvZmZzZXQsCj4+Pj4gKwkJCSAgIGNvbnN0IHZv aWQgKmJ1ZiwgdW5zaWduZWQgaW50IGxlbik7Cj4+Pj4gKwl1MzIgKCpnZXRfZ2VuZXJhdGlvbiko c3RydWN0IG1kZXZfZGV2aWNlICptZGV2KTsKPj4+PiArfTsKPj4+PiArCj4+Pj4gK3ZvaWQgbWRl dl9zZXRfdmlydGlvX29wcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsCj4+Pj4gKwkJCSBjb25z dCBzdHJ1Y3QgbWRldl92aXJ0aW9fZGV2aWNlX29wcyAqdmlydGlvX29wcyk7Cj4+Pj4gKwo+Pj4+ ICsjZW5kaWYKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==