All of lore.kernel.org
 help / color / mirror / Atom feed
From: Auger Eric <eric.auger@redhat.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>,
	Laszlo Ersek <lersek@redhat.com>,
	eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
	qemu-arm@nongnu.org, peter.maydell@linaro.org
Cc: wei@redhat.com, liujinsong <liu.jinsong@huawei.com>,
	drjones@redhat.com, ard.biesheuvel@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: Add virt-3.0 machine type
Date: Thu, 31 May 2018 08:23:33 +0200	[thread overview]
Message-ID: <9711bb05-d02a-5c23-6494-951ce6783923@redhat.com> (raw)
In-Reply-To: <5B0F52F6.8060006@huawei.com>

Hi Shannon,

On 05/31/2018 03:42 AM, Shannon Zhao wrote:
> 
> 
> On 2018/5/31 0:18, Laszlo Ersek wrote:
>> +    vms->highmem_ecam &= vms->highmem && (!firmware_loaded || aarch64);
>>> +
> Does it need a info log here to tell user that even though you enable
> the highmem_ecam but due to some other reasons it's disabled.
> 
> Also, if user enables highmem_ecam but finally it can't enable, does it
> need to error out?

highmem_ecam is not a user settable option. highmem is. highmem_ecam is
computed based on the machine type capability to support this feature,
the fact highmem is set and we don't have an aarch32 FW being used.

Thanks

Eric
> 
> Thanks,
> 

  reply	other threads:[~2018-05-31  6:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 14:26 [Qemu-devel] [PATCH 0/2] ARM virt: Support up to 256 PCIe buses Eric Auger
2018-05-30 14:26 ` [Qemu-devel] [PATCH 1/2] hw/arm/virt: Add a new 256MB ECAM region Eric Auger
2018-05-30 16:11   ` Laszlo Ersek
2018-05-31  6:55     ` Auger Eric
2018-05-31  8:41       ` Laszlo Ersek
2018-05-31  8:50         ` Auger Eric
2018-05-30 14:26 ` [Qemu-devel] [PATCH 2/2] hw/arm/virt: Add virt-3.0 machine type Eric Auger
2018-05-30 16:18   ` Laszlo Ersek
2018-05-31  1:42     ` Shannon Zhao
2018-05-31  6:23       ` Auger Eric [this message]
2018-05-31  6:52     ` Auger Eric
2018-06-15 12:37   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9711bb05-d02a-5c23-6494-951ce6783923@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=lersek@redhat.com \
    --cc=liu.jinsong@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wei@redhat.com \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.