From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957A6C433F5 for ; Mon, 20 Sep 2021 08:04:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DEC260F93 for ; Mon, 20 Sep 2021 08:04:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3DEC260F93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CD0989D56; Mon, 20 Sep 2021 08:04:38 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id F080689D56; Mon, 20 Sep 2021 08:04:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="223128994" X-IronPort-AV: E=Sophos;i="5.85,307,1624345200"; d="scan'208";a="223128994" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 01:04:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,307,1624345200"; d="scan'208";a="612380727" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 20 Sep 2021 01:04:36 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 20 Sep 2021 01:04:35 -0700 Received: from bgsmsx604.gar.corp.intel.com (10.67.234.6) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 20 Sep 2021 01:04:34 -0700 Received: from bgsmsx604.gar.corp.intel.com ([10.67.234.6]) by BGSMSX604.gar.corp.intel.com ([10.67.234.6]) with mapi id 15.01.2242.012; Mon, 20 Sep 2021 13:34:32 +0530 From: "Gupta, Anshuman" To: "Nikula, Jani" , "De Marchi, Lucas" CC: "Auld, Matthew" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" Subject: RE: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization Thread-Topic: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization Thread-Index: AQHXL3uUZJb5Qa4rAEOKCneFU4maiarnbHmAgMJkIoCAA1owAIAAXUjg Date: Mon, 20 Sep 2021 08:04:32 +0000 Message-ID: <97159e5b7e8f4ef49b773be085b886be@intel.com> References: <20210412090526.30547-1-matthew.auld@intel.com> <20210412090526.30547-15-matthew.auld@intel.com> <87im3hh8sy.fsf@intel.com> <20210918043019.hhol5fgwbi2ogod2@ldmartin-desk2> <87czp3vgl9.fsf@intel.com> In-Reply-To: <87czp3vgl9.fsf@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action x-originating-ip: [10.223.10.1] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > -----Original Message----- > From: Nikula, Jani > Sent: Monday, September 20, 2021 1:12 PM > To: De Marchi, Lucas > Cc: Auld, Matthew ; intel-gfx@lists.freedesktop.o= rg; > dri-devel@lists.freedesktop.org; Gupta, Anshuman > > Subject: Re: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization >=20 > On Fri, 17 Sep 2021, Lucas De Marchi wrote: > > On Mon, May 17, 2021 at 02:57:33PM +0300, Jani Nikula wrote: > >>On Mon, 12 Apr 2021, Matthew Auld wrote: > >>> From: Anshuman Gupta > >>> > >>> Sanitize OPROM header, CPD signature and OPROM PCI version. > >>> OPROM_HEADER, EXPANSION_ROM_HEADER and OPROM_MEU_BLOB > structures and > >>> PCI struct offsets are provided by GSC counterparts. > >>> These are yet to be Documented in B.Spec. > >>> After successful sanitization, extract VBT from opregion image. > >> > >>So I don't understand what the point is with two consecutive patches > >>where the latter rewrites a lot of the former. > > > > I actually wonder what's the point of this. Getting it from spi is > > already the fallback and looks much more complex. Yes, it's pretty > > detailed and document the format pretty well, but it still looks more > > complex than the initial code. Do you see additional benefit in this > > one? Getting opregion image from spi is needed to get the intel_opregion and its= mailboxes on discrete card. >=20 > The commit message doesn't really explain much. Anshuman? I will get rework of the patches and float it again. Thanks, Anshuman Gupta. >=20 > BR, > Jani. >=20 >=20 > -- > Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B518EC433EF for ; Mon, 20 Sep 2021 08:04:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 426FE60F93 for ; Mon, 20 Sep 2021 08:04:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 426FE60F93 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2CD26E40F; Mon, 20 Sep 2021 08:04:38 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id F080689D56; Mon, 20 Sep 2021 08:04:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="223128994" X-IronPort-AV: E=Sophos;i="5.85,307,1624345200"; d="scan'208";a="223128994" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 01:04:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,307,1624345200"; d="scan'208";a="612380727" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 20 Sep 2021 01:04:36 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 20 Sep 2021 01:04:35 -0700 Received: from bgsmsx604.gar.corp.intel.com (10.67.234.6) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 20 Sep 2021 01:04:34 -0700 Received: from bgsmsx604.gar.corp.intel.com ([10.67.234.6]) by BGSMSX604.gar.corp.intel.com ([10.67.234.6]) with mapi id 15.01.2242.012; Mon, 20 Sep 2021 13:34:32 +0530 From: "Gupta, Anshuman" To: "Nikula, Jani" , "De Marchi, Lucas" CC: "Auld, Matthew" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" Thread-Topic: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization Thread-Index: AQHXL3uUZJb5Qa4rAEOKCneFU4maiarnbHmAgMJkIoCAA1owAIAAXUjg Date: Mon, 20 Sep 2021 08:04:32 +0000 Message-ID: <97159e5b7e8f4ef49b773be085b886be@intel.com> References: <20210412090526.30547-1-matthew.auld@intel.com> <20210412090526.30547-15-matthew.auld@intel.com> <87im3hh8sy.fsf@intel.com> <20210918043019.hhol5fgwbi2ogod2@ldmartin-desk2> <87czp3vgl9.fsf@intel.com> In-Reply-To: <87czp3vgl9.fsf@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action x-originating-ip: [10.223.10.1] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > -----Original Message----- > From: Nikula, Jani > Sent: Monday, September 20, 2021 1:12 PM > To: De Marchi, Lucas > Cc: Auld, Matthew ; intel-gfx@lists.freedesktop.o= rg; > dri-devel@lists.freedesktop.org; Gupta, Anshuman > > Subject: Re: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization >=20 > On Fri, 17 Sep 2021, Lucas De Marchi wrote: > > On Mon, May 17, 2021 at 02:57:33PM +0300, Jani Nikula wrote: > >>On Mon, 12 Apr 2021, Matthew Auld wrote: > >>> From: Anshuman Gupta > >>> > >>> Sanitize OPROM header, CPD signature and OPROM PCI version. > >>> OPROM_HEADER, EXPANSION_ROM_HEADER and OPROM_MEU_BLOB > structures and > >>> PCI struct offsets are provided by GSC counterparts. > >>> These are yet to be Documented in B.Spec. > >>> After successful sanitization, extract VBT from opregion image. > >> > >>So I don't understand what the point is with two consecutive patches > >>where the latter rewrites a lot of the former. > > > > I actually wonder what's the point of this. Getting it from spi is > > already the fallback and looks much more complex. Yes, it's pretty > > detailed and document the format pretty well, but it still looks more > > complex than the initial code. Do you see additional benefit in this > > one? Getting opregion image from spi is needed to get the intel_opregion and its= mailboxes on discrete card. >=20 > The commit message doesn't really explain much. Anshuman? I will get rework of the patches and float it again. Thanks, Anshuman Gupta. >=20 > BR, > Jani. >=20 >=20 > -- > Jani Nikula, Intel Open Source Graphics Center