From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752601AbdCBP33 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Mar 2017 10:29:29 -0500
Received: from foss.arm.com ([217.140.101.70]:60734 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751648AbdCBP3X (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Mar 2017 10:29:23 -0500
Subject: Re: [PATCH v1] irqdomain: add empty irq_domain_check_msi_remap
To: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        alex.williamson@redhat.com
References: <20170302151147.25909-1-yousaf.kaukab@suse.com>
Cc: eric.auger@redhat.com, will.deacon@arm.com
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <9715ebce-0510-d348-2ef4-c679ae950bc3@arm.com>
Date: Thu, 2 Mar 2017 15:19:49 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170302151147.25909-1-yousaf.kaukab@suse.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/03/17 15:11, Mian Yousaf Kaukab wrote:
> Fix following build error for s390:
> drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_attach_group':
> drivers/vfio/vfio_iommu_type1.c:1290:25: error: implicit declaration of function 'irq_domain_check_msi_remap'
> 
> Signed-off-by: Mian Yousaf Kaukab <yousaf.kaukab@suse.com>
> ---
> History:
> v1:
>  -Return false instead of true as suggested by Marc and Eric.
>  -Drop 2/2
> 
>  include/linux/irqdomain.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index 188eced6813e..9f3616085423 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -524,6 +524,10 @@ static inline struct irq_domain *irq_find_matching_fwnode(
>  {
>  	return NULL;
>  }
> +static inline bool irq_domain_check_msi_remap(void)
> +{
> +	return false;
> +}
>  #endif /* !CONFIG_IRQ_DOMAIN */
>  
>  #endif /* _LINUX_IRQDOMAIN_H */
> 

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

I'll queue that now.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...