From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH REBASED 1/1] btrfs-progs: inspect-dump-tree: Allow '-b|--block' to be specified multiple times
Date: Fri, 1 Jun 2018 09:54:46 +0300 [thread overview]
Message-ID: <9718afcd-3eca-2ce9-b8a1-b05d07c987b3@suse.com> (raw)
In-Reply-To: <20180601051526.19564-2-wqu@suse.com>
On 1.06.2018 08:15, Qu Wenruo wrote:
> Reuse extent-cache facility to record multiple bytenr so '-b|--block'
> can be specified multiple times.
>
> Despite that, add a sector size alignment check before we try to print a
> tree block.
> (Please note that, nodesize alignment check is not suitable here as meta
> chunk start bytenr could be unaligned to nodesize)
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Just one minor misspell but otherwise LGTM:
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> Documentation/btrfs-inspect-internal.asciidoc | 2 +-
> cmds-inspect-dump-tree.c | 109 +++++++++++++++---
> 2 files changed, 91 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/btrfs-inspect-internal.asciidoc b/Documentation/btrfs-inspect-internal.asciidoc
> index e2db64660b9a..ba8529f57660 100644
> --- a/Documentation/btrfs-inspect-internal.asciidoc
> +++ b/Documentation/btrfs-inspect-internal.asciidoc
> @@ -86,7 +86,7 @@ the respective tree root block offset
> -u|--uuid::::
> print only the uuid tree information, empty output if the tree does not exist
> -b <block_num>::::
> -print info of the specified block only
> +print info of the specified block only, can be specified multiple times.
> --follow::::
> use with '-b', print all children tree blocks of '<block_num>'
> -t <tree_id>::::
> diff --git a/cmds-inspect-dump-tree.c b/cmds-inspect-dump-tree.c
> index 92a2a45b267e..abb9a2bcc7cb 100644
> --- a/cmds-inspect-dump-tree.c
> +++ b/cmds-inspect-dump-tree.c
> @@ -198,11 +198,92 @@ const char * const cmd_inspect_dump_tree_usage[] = {
> "-R|--backups same as --roots plus print backup root info",
> "-u|--uuid print only the uuid tree",
> "-b|--block <block_num> print info from the specified block only",
> + " can be specified multile times",
nit: s/multile/multiple
next prev parent reply other threads:[~2018-06-01 6:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 5:15 [PATCH REBASED 0/1] btrfs-progs: dump-tree: allow -b multiple times Qu Wenruo
2018-06-01 5:15 ` [PATCH REBASED 1/1] btrfs-progs: inspect-dump-tree: Allow '-b|--block' to be specified " Qu Wenruo
2018-06-01 6:54 ` Nikolay Borisov [this message]
2018-06-01 8:27 ` [PATCH v1.1] " Qu Wenruo
2019-03-05 14:57 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9718afcd-3eca-2ce9-b8a1-b05d07c987b3@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.