From: Jan Kiszka <jan.kiszka@siemens.com>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai@xenomai.org
Subject: Re: [PATCH Dovetail 13/13] cobalt/syscall: pipeline: abstract syscall entry points
Date: Mon, 11 Jan 2021 13:11:00 +0100 [thread overview]
Message-ID: <973f1ccb-1050-2c69-c03a-7e22f10eda6f@siemens.com> (raw)
In-Reply-To: <87im86l6l7.fsf@xenomai.org>
On 09.01.21 11:58, Philippe Gerum wrote:
>
> Jan Kiszka <jan.kiszka@siemens.com> writes:
>
>> On 02.01.21 10:33, Philippe Gerum wrote:
>>> From: Philippe Gerum <rpm@xenomai.org>
>>>
>>> The I-pipe and Dovetail differ only marginally with respect to syscall
>>> handling. Abstract only the few details we need to cope with both
>>> interfaces.
>>>
>>> No functional change is introduced.
>>>
>>> Signed-off-by: Philippe Gerum <rpm@xenomai.org>
>>> ---
>>> .../cobalt/kernel/ipipe/pipeline/kevents.h | 3 ++
>>> .../cobalt/kernel/ipipe/pipeline/pipeline.h | 2 ++
>>> include/cobalt/kernel/sched.h | 2 --
>>> kernel/cobalt/ipipe/Makefile | 2 +-
>>> kernel/cobalt/ipipe/syscall.c | 29 +++++++++++++++++++
>>> kernel/cobalt/posix/process.h | 3 --
>>> kernel/cobalt/posix/syscall.c | 28 ++++--------------
>>> kernel/cobalt/posix/syscall.h | 7 +++++
>>> 8 files changed, 47 insertions(+), 29 deletions(-)
>>> create mode 100644 kernel/cobalt/ipipe/syscall.c
>>>
>>> diff --git a/include/cobalt/kernel/ipipe/pipeline/kevents.h b/include/cobalt/kernel/ipipe/pipeline/kevents.h
>>> index 30425a96b..2f186a57e 100644
>>> --- a/include/cobalt/kernel/ipipe/pipeline/kevents.h
>>> +++ b/include/cobalt/kernel/ipipe/pipeline/kevents.h
>>> @@ -7,6 +7,9 @@
>>> #ifndef _COBALT_KERNEL_IPIPE_KEVENTS_H
>>> #define _COBALT_KERNEL_IPIPE_KEVENTS_H
>>>
>>> +#define KEVENT_PROPAGATE 0
>>> +#define KEVENT_STOP 1
>>> +
>>> struct cobalt_process;
>>> struct cobalt_thread;
>>>
>>> diff --git a/include/cobalt/kernel/ipipe/pipeline/pipeline.h b/include/cobalt/kernel/ipipe/pipeline/pipeline.h
>>> index 0ffc9b00b..fb0465fb2 100644
>>> --- a/include/cobalt/kernel/ipipe/pipeline/pipeline.h
>>> +++ b/include/cobalt/kernel/ipipe/pipeline/pipeline.h
>>> @@ -11,6 +11,8 @@
>>>
>>> #include <pipeline/machine.h>
>>>
>>> +#define xnsched_realtime_domain cobalt_pipeline.domain
>>> +
>>
>> Why not use the chance and call also this xnsched_primary_domain?
>
> Agreed on the reasoning. However I'll push that change on top top of my
> current patch queue, without affecting this intermediate patch only for
> a cosmetic change, not to cause useless merge conflicts - I have several
> other series of changes pending for kernel/cobalt/ipipe/{init, intr}.c
> typically.
>
OK. All now applied (with v2 of patch 7).
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2021-01-11 12:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 9:33 [PATCH Dovetail 00/13] Keep on abstracting the pipeline interface Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 01/13] cobalt/thread: pipeline: abstract threadinfo accessor Philippe Gerum
2021-01-08 9:02 ` Jan Kiszka
2021-01-02 9:33 ` [PATCH Dovetail 02/13] cobalt/apc: pipeline: abstract interface for deferred routine calls Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 03/13] cobalt/trace: pipeline: abstract trace calls Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 04/13] cobalt/lock: pipeline: abstract hard lock API Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 05/13] cobalt/kernel: pipeline: abstract execution stage predicates Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 06/13] cobalt/sched, clock: pipeline: abstract IPI management Philippe Gerum
2021-01-08 9:40 ` Jan Kiszka
2021-01-02 9:33 ` [PATCH Dovetail 07/13] cobalt/clock: pipeline: make HOSTRT depend on IPIPE Philippe Gerum
2021-01-07 13:52 ` Jan Kiszka
2021-01-09 10:45 ` Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 08/13] cobalt/build: pipeline: select IPIPE layer only if present Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 09/13] cobalt/clock: pipeline: abstract clock, timer access services Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 10/13] cobalt/wrappers: pipeline: abstract pipeline-related bits Philippe Gerum
2021-01-07 13:56 ` Jan Kiszka
2021-01-11 12:59 ` Jan Kiszka
2021-01-02 9:33 ` [PATCH Dovetail 11/13] cobalt/timer: pipeline: abstract tick management Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 12/13] cobalt/debug: pipeline: abstract panic prep call Philippe Gerum
2021-01-02 9:33 ` [PATCH Dovetail 13/13] cobalt/syscall: pipeline: abstract syscall entry points Philippe Gerum
2021-01-07 14:08 ` Jan Kiszka
2021-01-09 10:58 ` Philippe Gerum
2021-01-11 12:11 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=973f1ccb-1050-2c69-c03a-7e22f10eda6f@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=rpm@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.