All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] staging: rtlwifi: silence underflow warning
@ 2017-09-29  7:51 Dan Carpenter
  2017-09-29  7:52   ` Dan Carpenter
  2017-09-29 15:38 ` [PATCH 1/2] staging: " Larry Finger
  0 siblings, 2 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-09-29  7:51 UTC (permalink / raw)
  To: kernel-janitors

I'm not totally certain that it's necessary to put an upper limit here.
I think it happens at lower levels.  But if we are going to do that then
we should have a lower bound as well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c
index 43b8b9efe25f..b55e18304a60 100644
--- a/drivers/staging/rtlwifi/core.c
+++ b/drivers/staging/rtlwifi/core.c
@@ -412,7 +412,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
 	for (i = 0; i < wow->n_patterns; i++) {
 		memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
 		memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
-		if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
+		if (patterns[i].pattern_len < 0 ||
+		    patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
 			RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
 				 "Pattern[%d] is too long\n", i);
 			continue;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] rtlwifi: silence underflow warning
  2017-09-29  7:51 [PATCH 1/2] staging: rtlwifi: silence underflow warning Dan Carpenter
@ 2017-09-29  7:52   ` Dan Carpenter
  2017-09-29 15:38 ` [PATCH 1/2] staging: " Larry Finger
  1 sibling, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-09-29  7:52 UTC (permalink / raw)
  To: Larry Finger; +Cc: Chaoming Li, Kalle Valo, linux-wireless, kernel-janitors

My static checker complains that we have an upper bound but no lower
bound.  I suspect neither are really required but it doesn't hurt to add
a check for negatives.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
index c53cbf3d52bd..294a6b43d1bc 100644
--- a/drivers/net/wireless/realtek/rtlwifi/core.c
+++ b/drivers/net/wireless/realtek/rtlwifi/core.c
@@ -453,7 +453,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
 	for (i = 0; i < wow->n_patterns; i++) {
 		memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
 		memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
-		if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
+		if (patterns[i].pattern_len < 0 ||
+		    patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
 			RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
 				 "Pattern[%d] is too long\n", i);
 			continue;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] rtlwifi: silence underflow warning
@ 2017-09-29  7:52   ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-09-29  7:52 UTC (permalink / raw)
  To: Larry Finger; +Cc: Chaoming Li, Kalle Valo, linux-wireless, kernel-janitors

My static checker complains that we have an upper bound but no lower
bound.  I suspect neither are really required but it doesn't hurt to add
a check for negatives.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
index c53cbf3d52bd..294a6b43d1bc 100644
--- a/drivers/net/wireless/realtek/rtlwifi/core.c
+++ b/drivers/net/wireless/realtek/rtlwifi/core.c
@@ -453,7 +453,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
 	for (i = 0; i < wow->n_patterns; i++) {
 		memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
 		memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
-		if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
+		if (patterns[i].pattern_len < 0 ||
+		    patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
 			RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
 				 "Pattern[%d] is too long\n", i);
 			continue;

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] staging: rtlwifi: silence underflow warning
  2017-09-29  7:51 [PATCH 1/2] staging: rtlwifi: silence underflow warning Dan Carpenter
  2017-09-29  7:52   ` Dan Carpenter
@ 2017-09-29 15:38 ` Larry Finger
  1 sibling, 0 replies; 6+ messages in thread
From: Larry Finger @ 2017-09-29 15:38 UTC (permalink / raw)
  To: kernel-janitors

On 09/29/2017 02:51 AM, Dan Carpenter wrote:
> I'm not totally certain that it's necessary to put an upper limit here.
> I think it happens at lower levels.  But if we are going to do that then
> we should have a lower bound as well.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c
> index 43b8b9efe25f..b55e18304a60 100644
> --- a/drivers/staging/rtlwifi/core.c
> +++ b/drivers/staging/rtlwifi/core.c
> @@ -412,7 +412,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
>   	for (i = 0; i < wow->n_patterns; i++) {
>   		memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
>   		memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
> -		if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
> +		if (patterns[i].pattern_len < 0 ||
> +		    patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
>   			RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
>   				 "Pattern[%d] is too long\n", i);
>   			continue;

In principle, both patches are correct, but perhaps the debug message should be 
something like
'"Pattern[%d] has bad length of %d\n", i, patterns[i].pattern_len'

Larry


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [2/2] rtlwifi: silence underflow warning
  2017-09-29  7:52   ` Dan Carpenter
@ 2017-10-10  8:20     ` Kalle Valo
  -1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2017-10-10  8:20 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Larry Finger, Chaoming Li, linux-wireless, kernel-janitors

Dan Carpenter <dan.carpenter@oracle.com> wrote:

> My static checker complains that we have an upper bound but no lower
> bound.  I suspect neither are really required but it doesn't hurt to add
> a check for negatives.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
> index c53cbf3d52bd..294a6b43d1bc 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -453,7 +453,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
>  	for (i = 0; i < wow->n_patterns; i++) {
>  		memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
>  		memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
> -		if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
> +		if (patterns[i].pattern_len < 0 ||
> +		    patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
>  			RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
>  				 "Pattern[%d] is too long\n", i);
>  			continue;

Patch applied to wireless-drivers-next.git, thanks.

64e79426c204 rtlwifi: silence underflow warning

-- 
https://patchwork.kernel.org/patch/9977201/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [2/2] rtlwifi: silence underflow warning
@ 2017-10-10  8:20     ` Kalle Valo
  0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2017-10-10  8:20 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Larry Finger, Chaoming Li, linux-wireless, kernel-janitors

Dan Carpenter <dan.carpenter@oracle.com> wrote:

> My static checker complains that we have an upper bound but no lower
> bound.  I suspect neither are really required but it doesn't hurt to add
> a check for negatives.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c
> index c53cbf3d52bd..294a6b43d1bc 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/core.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/core.c
> @@ -453,7 +453,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
>  	for (i = 0; i < wow->n_patterns; i++) {
>  		memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
>  		memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
> -		if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
> +		if (patterns[i].pattern_len < 0 ||
> +		    patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
>  			RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
>  				 "Pattern[%d] is too long\n", i);
>  			continue;

Patch applied to wireless-drivers-next.git, thanks.

64e79426c204 rtlwifi: silence underflow warning

-- 
https://patchwork.kernel.org/patch/9977201/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-10  8:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29  7:51 [PATCH 1/2] staging: rtlwifi: silence underflow warning Dan Carpenter
2017-09-29  7:52 ` [PATCH 2/2] " Dan Carpenter
2017-09-29  7:52   ` Dan Carpenter
2017-10-10  8:20   ` [2/2] " Kalle Valo
2017-10-10  8:20     ` Kalle Valo
2017-09-29 15:38 ` [PATCH 1/2] staging: " Larry Finger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.