* [PATCH] Revert "media: staging/imx: Allow driver to build if COMPILE_TEST is enabled"
@ 2019-06-05 20:53 Fabio Estevam
2019-06-06 0:58 ` Randy Dunlap
2019-06-06 10:52 ` Hans Verkuil
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2019-06-05 20:53 UTC (permalink / raw)
To: hverkuil-cisco
Cc: slongerbeam, p.zabel, rdunlap, linux-media, mchehab, javierm,
Fabio Estevam
Commit 020bc7354a6e ("media: staging/imx: Allow driver to build
if COMPILE_TEST is enabled") incorrectly assumed that the imx media
driver had no build time dependency with IMX_IPUV3_CORE.
Building on x86_64 without IMX_IPUV3_CORE causes lots of build errors
such as:
ld: drivers/staging/media/imx/imx-media-internal-sd.o: in function `imx_media_register_ipu_internal_subdevs':
imx-media-internal-sd.c:(.text+0xd1): undefined reference to `ipu_get_num'
ld: drivers/staging/media/imx/imx-ic-common.o: in function `imx_media_ic_register':
imx-ic-common.c:(.text+0xec): undefined reference to `ipu_get_num'
All these definitions come from the imx ipu3 core driver, so make
sure that imx media depends on IMX_IPUV3_CORE.
This reverts commit 020bc7354a6ebec980e0aedf5bedf57b42f93aca.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/staging/media/imx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
index ad3d7df6bb3c..4c726345dc25 100644
--- a/drivers/staging/media/imx/Kconfig
+++ b/drivers/staging/media/imx/Kconfig
@@ -2,7 +2,7 @@
config VIDEO_IMX_MEDIA
tristate "i.MX5/6 V4L2 media core driver"
depends on ARCH_MXC || COMPILE_TEST
- depends on MEDIA_CONTROLLER && VIDEO_V4L2 && (IMX_IPUV3_CORE || COMPILE_TEST)
+ depends on MEDIA_CONTROLLER && VIDEO_V4L2 && IMX_IPUV3_CORE
depends on VIDEO_V4L2_SUBDEV_API
depends on HAS_DMA
select VIDEOBUF2_DMA_CONTIG
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "media: staging/imx: Allow driver to build if COMPILE_TEST is enabled"
2019-06-05 20:53 [PATCH] Revert "media: staging/imx: Allow driver to build if COMPILE_TEST is enabled" Fabio Estevam
@ 2019-06-06 0:58 ` Randy Dunlap
2019-06-06 10:52 ` Hans Verkuil
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2019-06-06 0:58 UTC (permalink / raw)
To: Fabio Estevam, hverkuil-cisco
Cc: slongerbeam, p.zabel, linux-media, mchehab, javierm
On 6/5/19 1:53 PM, Fabio Estevam wrote:
> Commit 020bc7354a6e ("media: staging/imx: Allow driver to build
> if COMPILE_TEST is enabled") incorrectly assumed that the imx media
> driver had no build time dependency with IMX_IPUV3_CORE.
>
> Building on x86_64 without IMX_IPUV3_CORE causes lots of build errors
> such as:
>
> ld: drivers/staging/media/imx/imx-media-internal-sd.o: in function `imx_media_register_ipu_internal_subdevs':
> imx-media-internal-sd.c:(.text+0xd1): undefined reference to `ipu_get_num'
> ld: drivers/staging/media/imx/imx-ic-common.o: in function `imx_media_ic_register':
> imx-ic-common.c:(.text+0xec): undefined reference to `ipu_get_num'
>
> All these definitions come from the imx ipu3 core driver, so make
> sure that imx media depends on IMX_IPUV3_CORE.
>
> This reverts commit 020bc7354a6ebec980e0aedf5bedf57b42f93aca.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/staging/media/imx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index ad3d7df6bb3c..4c726345dc25 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -2,7 +2,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
> depends on ARCH_MXC || COMPILE_TEST
> - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && (IMX_IPUV3_CORE || COMPILE_TEST)
> + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && IMX_IPUV3_CORE
> depends on VIDEO_V4L2_SUBDEV_API
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "media: staging/imx: Allow driver to build if COMPILE_TEST is enabled"
2019-06-05 20:53 [PATCH] Revert "media: staging/imx: Allow driver to build if COMPILE_TEST is enabled" Fabio Estevam
2019-06-06 0:58 ` Randy Dunlap
@ 2019-06-06 10:52 ` Hans Verkuil
1 sibling, 0 replies; 3+ messages in thread
From: Hans Verkuil @ 2019-06-06 10:52 UTC (permalink / raw)
To: Fabio Estevam
Cc: slongerbeam, p.zabel, rdunlap, linux-media, mchehab, javierm
On 6/5/19 10:53 PM, Fabio Estevam wrote:
> Commit 020bc7354a6e ("media: staging/imx: Allow driver to build
> if COMPILE_TEST is enabled") incorrectly assumed that the imx media
> driver had no build time dependency with IMX_IPUV3_CORE.
>
> Building on x86_64 without IMX_IPUV3_CORE causes lots of build errors
> such as:
>
> ld: drivers/staging/media/imx/imx-media-internal-sd.o: in function `imx_media_register_ipu_internal_subdevs':
> imx-media-internal-sd.c:(.text+0xd1): undefined reference to `ipu_get_num'
> ld: drivers/staging/media/imx/imx-ic-common.o: in function `imx_media_ic_register':
> imx-ic-common.c:(.text+0xec): undefined reference to `ipu_get_num'
>
> All these definitions come from the imx ipu3 core driver, so make
> sure that imx media depends on IMX_IPUV3_CORE.
>
> This reverts commit 020bc7354a6ebec980e0aedf5bedf57b42f93aca.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/staging/media/imx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index ad3d7df6bb3c..4c726345dc25 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -2,7 +2,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
> depends on ARCH_MXC || COMPILE_TEST
> - depends on MEDIA_CONTROLLER && VIDEO_V4L2 && (IMX_IPUV3_CORE || COMPILE_TEST)
> + depends on MEDIA_CONTROLLER && VIDEO_V4L2 && IMX_IPUV3_CORE
Can this driver just select IMX_IPUV3_CORE? IMX_IPUV3_CORE can handle
TEST_COMPILE, so that might work.
Regards,
Hans
> depends on VIDEO_V4L2_SUBDEV_API
> depends on HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-06 10:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 20:53 [PATCH] Revert "media: staging/imx: Allow driver to build if COMPILE_TEST is enabled" Fabio Estevam
2019-06-06 0:58 ` Randy Dunlap
2019-06-06 10:52 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.