From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v8 2/6] net/i40e: add dynamic device
 personalization processing
Date: Thu, 30 Mar 2017 15:08:16 +0100
Message-ID: <9759dd67-45eb-4054-f51c-054a628878a0@intel.com>
References: <1490798651-116457-1-git-send-email-beilei.xing@intel.com>
 <1490842311-96705-1-git-send-email-beilei.xing@intel.com>
 <1490842311-96705-3-git-send-email-beilei.xing@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: helin.zhang@intel.com, dev@dpdk.org
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 5AE46101B
 for <dev@dpdk.org>; Thu, 30 Mar 2017 16:08:29 +0200 (CEST)
In-Reply-To: <1490842311-96705-3-git-send-email-beilei.xing@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/30/2017 3:51 AM, Beilei Xing wrote:
> Add support for loading a dynamic device personalization
> profile.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

<...>

> diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h
> index 3ca49a4..94dd92e 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.h
> +++ b/drivers/net/i40e/rte_pmd_i40e.h
> @@ -65,6 +65,43 @@ struct rte_pmd_i40e_mb_event_param {
>  	uint16_t msglen;   /**< length of the message */
>  };
>  
> +enum rte_pmd_i40e_package_op {

This is generating a doxygen warning [1], can you please address this in
a separate patch?

Meanwhile some of the bellowing doxygen comments are not very detailed.
Please feel free to update them at will in patch.

Thanks,
ferruh

[1]
net/i40e/rte_pmd_i40e.h:68: warning: Member rte_pmd_i40e_package_op
(enumeration) of file rte_pmd_i40e.h is not documented.

> +	RTE_PMD_I40E_PKG_OP_UNDEFINED = 0,
> +	RTE_PMD_I40E_PKG_OP_WR_ADD,   /**< load package and add to info list */
> +	RTE_PMD_I40E_PKG_OP_MAX = 32
> +};
> +
> +#define RTE_PMD_I40E_DDP_NAME_SIZE 32
> +
> +/**
> + * Dynamic device personalization version
> + */
> +struct rte_pmd_i40e_ddp_version {
> +	uint8_t major;
> +	uint8_t minor;
> +	uint8_t update;
> +	uint8_t draft;
> +};
> +
> +/**
> + * Structure of profile information
> + */
> +struct rte_pmd_i40e_profile_info {
> +	uint32_t track_id;
> +	struct rte_pmd_i40e_ddp_version version;
> +	uint8_t owner;
> +	uint8_t reserved[7];
> +	uint8_t name[RTE_PMD_I40E_DDP_NAME_SIZE];
> +};
> +
> +/**
> + * Structure of profile information list
> + */
> +struct rte_pmd_i40e_profile_list {
> +	uint32_t p_count;
> +	struct rte_pmd_i40e_profile_info p_info[1];
> +};

<...>