All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Zhao <shannon.zhaosl@gmail.com>
To: Eric Auger <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, stefanb@linux.ibm.com,
	peter.maydell@linaro.org, qemu-devel@nongnu.org,
	qemu-arm@nongnu.org, imammedo@redhat.com, mst@redhat.com
Cc: marcandre.lureau@redhat.com, drjones@redhat.com,
	gshan@redhat.com, lersek@redhat.com, ardb@kernel.org
Subject: Re: [PATCH v2 3/3] arm/acpi: Add the TPM2.0 device under the DSDT
Date: Fri, 8 May 2020 23:24:07 +0800	[thread overview]
Message-ID: <976a1479-4443-da02-2ad8-1e1570742caa@gmail.com> (raw)
In-Reply-To: <20200505144419.29174-4-eric.auger@redhat.com>

Hi,

On 2020/5/5 22:44, Eric Auger wrote:
> +static void acpi_dsdt_add_tpm(Aml *scope, VirtMachineState *vms)
> +{
> +    hwaddr pbus_base = vms->memmap[VIRT_PLATFORM_BUS].base;
> +    PlatformBusDevice *pbus = PLATFORM_BUS_DEVICE(vms->platform_bus_dev);
> +    MemoryRegion *sbdev_mr;
> +    SysBusDevice *sbdev;
> +    hwaddr tpm_base;
> +
> +    sbdev = (SysBusDevice *)object_dynamic_cast(OBJECT(tpm_find()),
> +                                                TYPE_SYS_BUS_DEVICE);

Does it need to check the tpm version like you do in previous patch?

tpm_get_version(tpm_find()) == TPM_VERSION_2_0

Thanks,
Shannon


  reply	other threads:[~2020-05-08 15:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 14:44 [PATCH v2 0/3] vTPM/aarch64 ACPI support Eric Auger
2020-05-05 14:44 ` [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part Eric Auger
2020-05-05 16:17   ` Stefan Berger
2020-05-06  6:33   ` Andrew Jones
2020-05-06  9:50     ` Auger Eric
2020-05-12 14:10       ` Igor Mammedov
2020-05-12 14:56         ` Auger Eric
2020-05-06  9:58     ` Michael S. Tsirkin
2020-05-12 14:14       ` Igor Mammedov
2020-05-12 15:59         ` Auger Eric
2020-05-14  9:53           ` Igor Mammedov
2020-05-05 14:44 ` [PATCH v2 2/3] arm/acpi: TPM2 ACPI table support Eric Auger
2020-05-05 16:16   ` Stefan Berger
2020-05-12 14:27   ` Igor Mammedov
2020-05-12 16:06     ` Auger Eric
2020-05-05 14:44 ` [PATCH v2 3/3] arm/acpi: Add the TPM2.0 device under the DSDT Eric Auger
2020-05-08 15:24   ` Shannon Zhao [this message]
2020-05-08 15:25     ` Ard Biesheuvel
2020-05-08 19:15       ` Stefan Berger
2020-05-12 14:57   ` Igor Mammedov
2020-05-05 16:19 ` [PATCH v2 0/3] vTPM/aarch64 ACPI support Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=976a1479-4443-da02-2ad8-1e1570742caa@gmail.com \
    --to=shannon.zhaosl@gmail.com \
    --cc=ardb@kernel.org \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=gshan@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.