Re: [Buildroot] [PATCH 1/1] package/mtd: update lib{mtd, ubi}.h path

[Arnout Vandecappelle <arnout@mind.be>]

On 18/07/2021 14:51, Yann E. MORIN wrote:
> Thomas, All,
> 
> On 2021-07-18 14:00 +0200, Thomas Petazzoni spake thusly:
>> On Sun, 18 Jul 2021 10:34:12 +0200
>> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>>
>>> Update lib{mtd,ubi}.h path to fix the following build failure raised
>>> since bump of swupdate to version 2021.04 in commit
>>> 2c6b0359c3b819fadb4437b2d780e95c32fdab21:
>>>
>>> In file included from corelib/mtd-interface.c:21:
>>> include/flash.h:13:10: fatal error: libmtd.h: No such file or directory
>>>    13 | #include <libmtd.h>
>>>       |          ^~~~~~~~~~
>>>
>>> This build failure is raised because of
>>> https://github.com/sbabic/swupdate/commit/0c672866d4a9fe8f0808b5d8a0afb95c13c4c138
>>>
>>> Fixes:
>>>  - http://autobuild.buildroot.org/results/d475bdb341d2afecf12e404dfa093e58221b9882
>>>
>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>>> ---
>>>  package/mtd/mtd.mk | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Isn't there a chance for this to break other packages? Is it just
>> swupdate that is using the MTD headers?
> 
> Currently, in Buildroot, we havea few packages that depend on the 'mtd'
> package;
> 
>   - fs/kffs2/
>   - fs/ubifs/
>       both want the mtd tools
> 
>   - busybox
>       installs mtd applets
> 
>   - swupdate
>       needs the headers
> 
> There are a few other refrences to '\<mtd\>', but none are about a build
> dependency.
> 
> So, for Buildroot, only swupsdate seems to be impacted, indeed.
> 
> Still, using headers internal to another package is not nice from
> swupdate...

 Well, you could argue that it is not nice of mtd-utils to have a very useful
library but not export it :-)

 Since there isn't really any other way of fixing this other than mesing with
symlinks, I've applied the patch to master, thanks.

 Regards,
 Arnout
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot