All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Kroon <jacob.kroon@gmail.com>
To: Martin Jansa <martin.jansa@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] sstate.bbclass: use tabs for indentation
Date: Mon, 16 Dec 2019 11:41:53 +0100	[thread overview]
Message-ID: <978a0738-d342-9b5e-8a46-e9cb46c5df54@gmail.com> (raw)
In-Reply-To: <20191216095620.3747-1-Martin.Jansa@gmail.com>

On 12/16/19 10:56 AM, Martin Jansa wrote:
> * it's terrible, but this is what oe-core wants and it's better than mixing tabs and spaces in the same function
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>   meta/classes/sstate.bbclass | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> index 14de791c81..18e3492674 100644
> --- a/meta/classes/sstate.bbclass
> +++ b/meta/classes/sstate.bbclass
> @@ -753,13 +753,13 @@ sstate_create_package () {
>   		return
>   	fi
>   
> -        mkdir -p `dirname ${SSTATE_PKG}`
> +	mkdir -p `dirname ${SSTATE_PKG}`
>   	TFILE=`mktemp ${SSTATE_PKG}.XXXXXXXX`
>   
> -        # Use pigz if available
> -        OPT="-czS"
> -        if [ -x "$(command -v pigz)" ]; then
> -            OPT="-I pigz -cS"
> +	# Use pigz if available
> +	OPT="-czS"
> +	if [ -x "$(command -v pigz)" ]; then
> +		OPT="-I pigz -cS"
>           fi
>   

Nice cleanup. Doesn't this final 'fi' still look funky though ?

>   	# Need to handle empty directories
> 


  reply	other threads:[~2019-12-16 10:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  9:56 [PATCH] sstate.bbclass: use tabs for indentation Martin Jansa
2019-12-16 10:41 ` Jacob Kroon [this message]
2019-12-16 10:58   ` Martin Jansa
2019-12-16 10:56 ` [PATCHv2] " Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=978a0738-d342-9b5e-8a46-e9cb46c5df54@gmail.com \
    --to=jacob.kroon@gmail.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.