From: Paolo Bonzini <pbonzini@redhat.com>
To: P J P <ppandit@redhat.com>, Qemu Developers <qemu-devel@nongnu.org>
Cc: Li Qiang <liqiang6-s@360.cn>, Laszlo Ersek <lersek@redhat.com>,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH v3] scsi: esp: check length before dma read
Date: Wed, 15 Jun 2016 18:36:51 +0200 [thread overview]
Message-ID: <97a65801-e94d-9ea8-80f4-4caa4a8cf4a4@redhat.com> (raw)
In-Reply-To: <1466007376-27333-1-git-send-email-ppandit@redhat.com>
On 15/06/2016 18:16, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> While doing DMA read into ESP command buffer 's->cmdbuf', the
> length parameter could exceed the buffer size. Add check to avoid
> OOB access. Also increase the command buffer size to 32, which
> is maximum when 's->do_cmd' is set.
Actually, the commit message is wrong. The length parameter cannot
exceed the buffer size anymore. Can you do a v4 with the corrected
commit message and an assert that avoids overflows like in Laszlo's
proposal? I think this:
assert (s->cmdlen <= sizeof(s->cmdbuf) &&
len <= sizeof(s->cmdbuf) - s->cmdlen);
would do.
Thanks,
Paolo
next prev parent reply other threads:[~2016-06-15 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 16:16 [Qemu-devel] [PATCH v3] scsi: esp: check length before dma read P J P
2016-06-15 16:34 ` Paolo Bonzini
2016-06-15 16:36 ` Paolo Bonzini [this message]
2016-06-15 17:18 ` P J P
2016-06-15 18:27 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a65801-e94d-9ea8-80f4-4caa4a8cf4a4@redhat.com \
--to=pbonzini@redhat.com \
--cc=lersek@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.