From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D447AC48BD4 for ; Tue, 25 Jun 2019 07:04:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2B362054F for ; Tue, 25 Jun 2019 07:04:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729756AbfFYHEV (ORCPT ); Tue, 25 Jun 2019 03:04:21 -0400 Received: from skedge04.snt-world.com ([91.208.41.69]:47050 "EHLO skedge04.snt-world.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729705AbfFYHEP (ORCPT ); Tue, 25 Jun 2019 03:04:15 -0400 Received: from sntmail12r.snt-is.com (unknown [10.203.32.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge04.snt-world.com (Postfix) with ESMTPS id 4605767A7D4; Tue, 25 Jun 2019 09:04:07 +0200 (CEST) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail12r.snt-is.com (10.203.32.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 25 Jun 2019 09:04:06 +0200 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1713.004; Tue, 25 Jun 2019 09:04:06 +0200 From: Schrempf Frieder To: liaoweixiong CC: Greg KH , Vignesh Raghavendra , Boris Brezillon , "Richard Weinberger" , "linux-kernel@vger.kernel.org" , Chuanhong Guo , "Marek Vasut" , "linux-mtd@lists.infradead.org" , Miquel Raynal , "stable@vger.kernel.org" , Brian Norris , David Woodhouse Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Thread-Topic: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Thread-Index: AQHVKvG5vIRdXk03g0+SrXGJtaID9aarjwGAgABB7wA= Date: Tue, 25 Jun 2019 07:04:06 +0000 Message-ID: <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> <20190625030807.GA11074@kroah.com> In-Reply-To: <20190625030807.GA11074@kroah.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-Type: text/plain; charset="utf-8" Content-ID: <82C2E515EE53D0458A0A48579DDDDAF9@snt-world.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 4605767A7D4.ADE8A X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: bbrezillon@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, gch981213@gmail.com, gregkh@linuxfoundation.org, liaoweixiong@allwinnertech.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, marek.vasut@gmail.com, miquel.raynal@bootlin.com, richard@nod.at, stable@vger.kernel.org, vigneshr@ti.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgbGlhb3dlaXhpb25nLA0KDQpPbiAyNS4wNi4xOSAwNTowOCwgR3JlZyBLSCB3cm90ZToNCj4g T24gVHVlLCBKdW4gMjUsIDIwMTkgYXQgMDk6MDI6MjlBTSArMDgwMCwgbGlhb3dlaXhpb25nIHdy b3RlOg0KPj4gSW4gY2FzZSBvZiB0aGUgbGFzdCBwYWdlIGNvbnRhaW5pbmcgYml0ZmxpcHMgKHJl dCA+IDApLA0KPj4gc3BpbmFuZF9tdGRfcmVhZCgpIHdpbGwgcmV0dXJuIHRoYXQgbnVtYmVyIG9m IGJpdGZsaXBzIGZvciB0aGUgbGFzdA0KPj4gcGFnZS4gQnV0IHRvIG1lIGl0IGxvb2tzIGxpa2Ug aXQgc2hvdWxkIGluc3RlYWQgcmV0dXJuIG1heF9iaXRmbGlwcyBsaWtlDQo+PiBpdCBkb2VzIHdo ZW4gdGhlIGxhc3QgcGFnZSByZWFkIHJldHVybnMgd2l0aCAwLg0KPj4NCj4+IFNpZ25lZC1vZmYt Ynk6IGxpYW93ZWl4aW9uZyA8bGlhb3dlaXhpb25nQGFsbHdpbm5lcnRlY2guY29tPg0KPj4gUmV2 aWV3ZWQtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGNvbGxhYm9yYS5jb20+ DQo+PiBSZXZpZXdlZC1ieTogRnJpZWRlciBTY2hyZW1wZiA8ZnJpZWRlci5zY2hyZW1wZkBrb250 cm9uLmRlPg0KPj4gRml4ZXM6IDc1MjlkZjQ2NTI0OCAoIm10ZDogbmFuZDogQWRkIGNvcmUgaW5m cmFzdHJ1Y3R1cmUgdG8gc3VwcG9ydCBTUEkgTkFORHMiKQ0KPj4gLS0tDQo+PiAgIGRyaXZlcnMv bXRkL25hbmQvc3BpL2NvcmUuYyB8IDIgKy0NCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiA8Zm9ybWxldHRlcj4NCj4gDQo+IFRoaXMgaXMg bm90IHRoZSBjb3JyZWN0IHdheSB0byBzdWJtaXQgcGF0Y2hlcyBmb3IgaW5jbHVzaW9uIGluIHRo ZQ0KPiBzdGFibGUga2VybmVsIHRyZWUuICBQbGVhc2UgcmVhZDoNCj4gICAgICBodHRwczovL3d3 dy5rZXJuZWwub3JnL2RvYy9odG1sL2xhdGVzdC9wcm9jZXNzL3N0YWJsZS1rZXJuZWwtcnVsZXMu aHRtbA0KPiBmb3IgaG93IHRvIGRvIHRoaXMgcHJvcGVybHkuDQo+IA0KPiA8L2Zvcm1sZXR0ZXI+ DQoNCkZZSSwgeW91IHNob3VsZCBub3Qgc2VuZCB0aGUgcGF0Y2ggdG8gc3RhYmxlQHZnZXIua2Vy bmVsLm9yZywgYnV0IA0KaW5zdGVhZCwgYXMgSSBzYWlkIGluIG15IG90aGVyIHJlcGx5LCBhZGQg dGhlIHRhZyAiQ2M6IA0Kc3RhYmxlQHZnZXIua2VybmVsLm9yZyIuIFNlZSAiT3B0aW9uIDEiIGlu IHRoZSBkb2N1bWVudCBHcmVnIHJlZmVycmVkIHRvLg0KDQpUaGFua3MsDQpGcmllZGVy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD6D6C48BD5 for ; Tue, 25 Jun 2019 07:05:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C7932054F for ; Tue, 25 Jun 2019 07:05:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="laEAZ1SS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C7932054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pa8lUgIYD+CKKAi+NtoDC3KkQzLGrFQcr7v72mn5bW0=; b=laEAZ1SSbfXB3I 9TL9ROkJJeOqbOo5IiBF2e/GUVyrgZmU5/vUrh8BAJuHkmdnzt85sR45U0wryztUAME24f7/CNgf1 WkL7PuW+rkndvjZkYvZ61TzKUITMt6gRO4pJBJYId8fFc/0lfxYWoNvMVsNGz2bvYGPRMW93ITQ2C Fog/nlmomEr7w4i60YJHa+rtNN0gsr9qribGKGg36G00xCjS73KU2dXswV1sngau33zyfEcqQkAXt 56i+mXIHU2XEXAvYpmIdVAaHtVtaQLADcAZjEe95ODl4jYPThoMVY20jNevbehokY0Iwr3gUaHP63 s7xAPws+g2N6HX+RnQCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hffWC-0002O9-Ga; Tue, 25 Jun 2019 07:05:28 +0000 Received: from skedge04.snt-world.com ([91.208.41.69]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hffV2-0000ZQ-Qa for linux-mtd@lists.infradead.org; Tue, 25 Jun 2019 07:04:19 +0000 Received: from sntmail12r.snt-is.com (unknown [10.203.32.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by skedge04.snt-world.com (Postfix) with ESMTPS id 4605767A7D4; Tue, 25 Jun 2019 09:04:07 +0200 (CEST) Received: from sntmail12r.snt-is.com (10.203.32.182) by sntmail12r.snt-is.com (10.203.32.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 25 Jun 2019 09:04:06 +0200 Received: from sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305]) by sntmail12r.snt-is.com ([fe80::e551:8750:7bba:3305%3]) with mapi id 15.01.1713.004; Tue, 25 Jun 2019 09:04:06 +0200 From: Schrempf Frieder To: liaoweixiong Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Thread-Topic: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Thread-Index: AQHVKvG5vIRdXk03g0+SrXGJtaID9aarjwGAgABB7wA= Date: Tue, 25 Jun 2019 07:04:06 +0000 Message-ID: <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> <20190625030807.GA11074@kroah.com> In-Reply-To: <20190625030807.GA11074@kroah.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.9.193] x-c2processedorg: 51b406b7-48a2-4d03-b652-521f56ac89f3 Content-ID: <82C2E515EE53D0458A0A48579DDDDAF9@snt-world.com> MIME-Version: 1.0 X-SnT-MailScanner-Information: Please contact the ISP for more information X-SnT-MailScanner-ID: 4605767A7D4.ADE8A X-SnT-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-SnT-MailScanner-SpamCheck: X-SnT-MailScanner-From: frieder.schrempf@kontron.de X-SnT-MailScanner-To: bbrezillon@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, gch981213@gmail.com, gregkh@linuxfoundation.org, liaoweixiong@allwinnertech.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, marek.vasut@gmail.com, miquel.raynal@bootlin.com, richard@nod.at, stable@vger.kernel.org, vigneshr@ti.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_000417_201711_3C05EDD0 X-CRM114-Status: GOOD ( 16.56 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Boris Brezillon , Richard Weinberger , Miquel Raynal , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Marek Vasut , "linux-mtd@lists.infradead.org" , Greg KH , Brian Norris , Chuanhong Guo , David Woodhouse Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi liaoweixiong, On 25.06.19 05:08, Greg KH wrote: > On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: >> In case of the last page containing bitflips (ret > 0), >> spinand_mtd_read() will return that number of bitflips for the last >> page. But to me it looks like it should instead return max_bitflips like >> it does when the last page read returns with 0. >> >> Signed-off-by: liaoweixiong >> Reviewed-by: Boris Brezillon >> Reviewed-by: Frieder Schrempf >> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") >> --- >> drivers/mtd/nand/spi/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. > > FYI, you should not send the patch to stable@vger.kernel.org, but instead, as I said in my other reply, add the tag "Cc: stable@vger.kernel.org". See "Option 1" in the document Greg referred to. Thanks, Frieder ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/