Am 15.11.22 um 21:35 schrieb kernel test robot: > Hi Thomas, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on 2cc304afd4967ceffd14940ff73a8beb31778f90] > > url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-fb-helper-Remove-damage-worker/20221115-195958 > base: 2cc304afd4967ceffd14940ff73a8beb31778f90 > patch link: https://lore.kernel.org/r/20221115115819.23088-6-tzimmermann%40suse.de > patch subject: [PATCH v2 5/6] drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer > config: x86_64-allyesconfig > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/c0dd62358bb8a66ecb8953704180291cf6834572 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Thomas-Zimmermann/drm-fb-helper-Remove-damage-worker/20221115-195958 > git checkout c0dd62358bb8a66ecb8953704180291cf6834572 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > drivers/gpu/drm/drm_fb_helper.c: In function 'drm_fb_helper_damage': >>> drivers/gpu/drm/drm_fb_helper.c:602:28: warning: unused variable 'dev' [-Wunused-variable] > 602 | struct drm_device *dev = helper->dev; > | ^~~ If nothing else comes in, this will be fixed while merging the patch. > > > vim +/dev +602 drivers/gpu/drm/drm_fb_helper.c > > 598 > 599 static void drm_fb_helper_damage(struct drm_fb_helper *helper, u32 x, u32 y, > 600 u32 width, u32 height) > 601 { > > 602 struct drm_device *dev = helper->dev; > 603 struct fb_info *info = helper->info; > 604 > 605 drm_fb_helper_add_damage_clip(helper, x, y, width, height); > 606 > 607 /* > 608 * The current fbdev emulation only flushes buffers if a damage > 609 * update is necessary. And we can assume that deferred I/O has > 610 * been enabled as damage updates require deferred I/O for mmap. > 611 */ > 612 fb_deferred_io_schedule_flush(info); > 613 } > 614 > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev