From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA11AC433ED for ; Fri, 14 May 2021 16:17:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9118F61353 for ; Fri, 14 May 2021 16:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233266AbhENQSX (ORCPT ); Fri, 14 May 2021 12:18:23 -0400 Received: from foss.arm.com ([217.140.110.172]:52058 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233418AbhENQSP (ORCPT ); Fri, 14 May 2021 12:18:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B6AD1764; Fri, 14 May 2021 09:17:04 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 302443F73B; Fri, 14 May 2021 09:17:02 -0700 (PDT) Subject: Re: [PATCH 3/3] arm64, topology: enable use of init_cpu_capacity_cppc() To: Ionela Voinescu , Sudeep Holla , "Rafael J . Wysocki" , Thomas Gleixner , Ingo Molnar , Giovanni Gherdovich , Catalin Marinas , Will Deacon , Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210514095339.12979-1-ionela.voinescu@arm.com> <20210514095339.12979-4-ionela.voinescu@arm.com> From: Dietmar Eggemann Message-ID: <97b515ea-3daa-5252-ca6b-1acacb0e5ade@arm.com> Date: Fri, 14 May 2021 18:17:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210514095339.12979-4-ionela.voinescu@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 14/05/2021 11:53, Ionela Voinescu wrote: [...] > +#ifdef CONFIG_ACPI_CPPC_LIB > +#define arch_init_invariance_cppc init_cpu_capacity_cppc > +#endif The prefix `topology_` was meant to indicate that those functions come from drivers/base/arch_topology.c. You probably refrained from it since topology_init_cpu_capacity_cppc() is a pretty long function name ... Still more consistent though. [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC61C433B4 for ; Fri, 14 May 2021 16:18:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DAC061454 for ; Fri, 14 May 2021 16:18:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DAC061454 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KCbzC2Pm2dcah7tIQYV8ODq5NV8Th/P5hOsjIdZX56Q=; b=UQow/7/Vm49v4gs3RNCJQiMDV vbDxG5dFZ1+/oD6RkEA8S4pwoj1m+54UcalgD1V9T/hc+Q6QVNx9ZpmzqKCf2kJlXQBc60jaF7hOA 928ZOiWZmQilLECzImWp5qkPzt1C5a4AeQFuSnRykF+9qzgxckI/HmT6ho2WQfF5Ay8ERDpEvgKwM jKCBpRHvUg0tBAFBYKCng+TllLRSntvsmHv+O/6VMeuQUoVeeTgab9b4wuxbpr5IPNWvMqQu6hsRi 5lAKVc2zwteg6oUl2knsxocxC27jiWII70wJ/cByVpwaw7m4dxNMZ6lcNeHr2GMwuEc1LeplQ/00I jeEg+Bw6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhaVC-008Sg8-El; Fri, 14 May 2021 16:17:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhaUw-008Sdl-DT for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 16:17:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=snH36Ka7oAduFGMo8DhdqHmrvdgmH+FUXTx2juX3nmY=; b=YdGbxN9q2mqHDBC512kumx4cOX C/R5cs4XRBqEFC/A8x9BnT0stkyRYsaWow+B0bJ4Uh7b0WyLB2VgxwF5CNH569G9EVvxMtPsqjYQV 9bNYgMDQicxsOr+crunzK1xnB56lnL9N8rc0jR7J8K99J/XYoPBzlQX6DOvNe//3PLnjzqo94P2hV QJXykS7PzepKs+ZNjokI1g0QUU5k6rYxMiEs4b35F9suvpceSzSD5gWninJDdYK/jnnRoMzQgj14e nIyCl23xgo4GZT2ZrsFCIxkenCJBrhxqOrxtamIGVNR6U4E+pj5dgSJYaQ2O2YGYEjIWKjoO7ox78 n0MxpM7g==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhaUt-00C6ff-Rs for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 16:17:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B6AD1764; Fri, 14 May 2021 09:17:04 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 302443F73B; Fri, 14 May 2021 09:17:02 -0700 (PDT) Subject: Re: [PATCH 3/3] arm64, topology: enable use of init_cpu_capacity_cppc() To: Ionela Voinescu , Sudeep Holla , "Rafael J . Wysocki" , Thomas Gleixner , Ingo Molnar , Giovanni Gherdovich , Catalin Marinas , Will Deacon , Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210514095339.12979-1-ionela.voinescu@arm.com> <20210514095339.12979-4-ionela.voinescu@arm.com> From: Dietmar Eggemann Message-ID: <97b515ea-3daa-5252-ca6b-1acacb0e5ade@arm.com> Date: Fri, 14 May 2021 18:17:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210514095339.12979-4-ionela.voinescu@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_091707_973975_9907A792 X-CRM114-Status: UNSURE ( 7.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/05/2021 11:53, Ionela Voinescu wrote: [...] > +#ifdef CONFIG_ACPI_CPPC_LIB > +#define arch_init_invariance_cppc init_cpu_capacity_cppc > +#endif The prefix `topology_` was meant to indicate that those functions come from drivers/base/arch_topology.c. You probably refrained from it since topology_init_cpu_capacity_cppc() is a pretty long function name ... Still more consistent though. [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel