All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Gu <guwen@linux.alibaba.com>
To: Karsten Graul <kgraul@linux.ibm.com>,
	dust.li@linux.alibaba.com, davem@davemloft.net, kuba@kernel.org
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net/smc: Reset conn->lgr when link group registration fails
Date: Thu, 6 Jan 2022 10:09:46 +0800	[thread overview]
Message-ID: <97c7381e-c618-a074-b1bf-5c59644f35f0@linux.alibaba.com> (raw)
In-Reply-To: <6e2ae46c-5407-ca6a-3353-69e76f10d913@linux.ibm.com>

Thanks for your suggestion.

On 2022/1/5 9:25 pm, Karsten Graul wrote:

> It might look cleaner with the following changes:
> - adopt smc_lgr_cleanup_early() to take only an lgr as parameter and remove the call to smc_conn_free()
> - change smc_conn_abort() (which is the only caller of smc_lgr_cleanup_early() right now), always
>    call smc_conn_free() and if (local_first) additionally call smc_lgr_cleanup_early()
>    (hold a local copy of the lgr for this call)
> - finally call smc_lgr_cleanup_early(lgr) from smc_conn_create()
> 
> This should be the same processing, but the smc_conn_free() is moved to smc_conn_abort() where
> it looks to be a better place for this call. And smc_lgr_cleanup_early() takes only care of an lgr.
> 

I think those are very good changes, making smc_lgr_cleanup_early() processing link group only and
more reusable.

> What do you think? Did I miss something?
I think it is better and complete. I will improve the patch and test it, then send a v4.

Thanks,
Wen Gu

      reply	other threads:[~2022-01-06  2:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05  6:28 [PATCH net v3] net/smc: Reset conn->lgr when link group registration fails Wen Gu
2022-01-05  7:54 ` dust.li
2022-01-05  8:55   ` Wen Gu
2022-01-05 13:25     ` Karsten Graul
2022-01-06  2:09       ` Wen Gu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97c7381e-c618-a074-b1bf-5c59644f35f0@linux.alibaba.com \
    --to=guwen@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=dust.li@linux.alibaba.com \
    --cc=kgraul@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.