From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D7AC43331 for ; Mon, 30 Mar 2020 11:46:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C14E52073B for ; Mon, 30 Mar 2020 11:46:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qxld/Tko" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C14E52073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=naewpBmeCFFXHxAdUeBdPH/UA1IpCWVIJgLb20a/aXo=; b=qxld/Tko1GNBxL Bh/eKc/rLTXL+fYZXj10BmhOT3kdRQrhWP1FrBvfdDfMOr/MWNjH2hDIiwZh9S4nA2nl+Zqbk++6T mnosBLWnu+v2izkl/qnF8iHM149QnB72ZSD3IgJF/4Ps4CquU/n/KUCao7QwF3BTJIunJ2whpLUcr qDhSpCSpijWAIgBFvc42aHAnTOicfF56MzMp89EdkR5jtStdr4YT+4OLhi0x3xb98QwPPMUj9b12b z9n052R1h0PFrW11cUy5Ub5TVn0MHH6aOkwojyu5qVjJidX2AiK+XeEK5KGPnZpGHF1VwiUzR6U9f Dlo/1It7FtUsZGLgLo8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIsrl-0006ul-Jb; Mon, 30 Mar 2020 11:46:05 +0000 Received: from mail-out.m-online.net ([212.18.0.10]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jIsri-0006uH-Ho for linux-arm-kernel@lists.infradead.org; Mon, 30 Mar 2020 11:46:04 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 48rVyw1Sgtz1rvRr; Mon, 30 Mar 2020 13:46:00 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 48rVyw0gK3z1qqkP; Mon, 30 Mar 2020 13:46:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id MwHV6kv_ihNA; Mon, 30 Mar 2020 13:45:58 +0200 (CEST) X-Auth-Info: gT0Gk3tvCGkrHnFSE/Y6h4e1a8LDrg9q705hb0Ns4as= Received: from [IPv6:::1] (unknown [195.140.253.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 30 Mar 2020 13:45:58 +0200 (CEST) Subject: Re: [Linux-stm32] [PATCH 07/22] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 To: Ahmad Fatoum , Patrice CHOTARD , "linux-arm-kernel@lists.infradead.org" References: <20200328171144.51888-1-marex@denx.de> <20200328171144.51888-8-marex@denx.de> <0fb89d25-feb0-2eb0-9e83-d7f8c76f8b9e@st.com> <82dcf412-119b-0de2-0c50-f6877a82a812@pengutronix.de> <310aa3a3-09ce-42ef-d1ea-b653163d1d72@pengutronix.de> From: Marek Vasut Message-ID: <97d13a84-8220-aa7f-3ee6-df474cca3882@denx.de> Date: Mon, 30 Mar 2020 13:45:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <310aa3a3-09ce-42ef-d1ea-b653163d1d72@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200330_044602_886269_720245C6 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Coquelin , Patrick DELAUNAY , "linux-stm32@st-md-mailman.stormreply.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/30/20 1:37 PM, Ahmad Fatoum wrote: > Hi Marek, Hi, > On 3/30/20 1:22 PM, Marek Vasut wrote: >> On 3/30/20 1:17 PM, Ahmad Fatoum wrote: >>> Hello Patrice, >> >> Hi, >> >>> On 3/30/20 1:11 PM, Patrice CHOTARD wrote: >>>> For your information, another submitted patch uses the same pinctrl sdmmc2_d47_pins_b node with different muxing (SDMMC2_D5) >>>> >>>> see https://lore.kernel.org/patchwork/patch/1216452/ >>>> >>>> I haven't checked other muxing if there are other conflict. >>> >>> (author of linked patch here) >>> >>> I don't like the central stm32mp15-pinctrl.dtsi. I'd have preferred if each >>> file defined the pinctrl groups it is using. >> >> I'm not a big fan of that either, because this is gonna be a >> combinatorial explosion of various pinmux options. But if you have each >> board define it's pinmux, it's also gonna become a massive amount of >> duplication (like iMX). So I cannot tell which one is better ... > > Mhm. A middle ground could be keeping stm32mp15-pinctrl, but only for the > official ST eval kits as HW designers are expected to copy off those and have > board specifics in the board/SoM device tree? Then you should call it stm32mp1-something-st-eval-pinmux.dtsi , otherwise it's gonna be confusing. > If it has to be either one or the other, I prefer duplication in the device > tree. When the HW misses pull ups or needs to adjust slew rates, you probably > don't want a new, slightly different, pinctrl group in the stm32mp15-pinctrl.dtsi > for each variant. That's a valid point, but then you can override those in the boards' pinmux node for a specific pinmux entry too. > So you are left with doctoring around with overrides and /delete-property/, > while just duplicating the node with the correct properties would've been > better for readability IMO. That is true, but how many of such cases do we have so far ? Maybe it's better to cross that bridge when (if) we come to it. -- Best regards, Marek Vasut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel