From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Date: Sat, 25 Jan 2020 20:52:36 +0100 Subject: [PATCH] board: tbs2910: Add support for generic distro configuration In-Reply-To: <20200125014240.18126-1-GNUtoo@cyberdimension.org> References: <20200125014240.18126-1-GNUtoo@cyberdimension.org> Message-ID: <97d6009f-a53f-ed2a-8159-ffecd25c9cd1@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Denis, thanks for your patch. In general I think it could be a good idea to support distroboot on this board, especially if we can maintain compatibility with the existing boot procedure. However, since this board repeatedly has size problems with the u-boot binary, we carefully need to check binary size. More questions inline. On 25.01.20 02:42, Denis 'GNUtoo' Carikli wrote: > This keeps the compatibility with the old bootcmd. > > Signed-off-by: Denis 'GNUtoo' Carikli > --- > include/configs/tbs2910.h | 39 ++++++++++++++++++++++++++++++--------- > 1 file changed, 30 insertions(+), 9 deletions(-) > > diff --git a/include/configs/tbs2910.h b/include/configs/tbs2910.h > index b598fca1ec..8867918f37 100644 > --- a/include/configs/tbs2910.h > +++ b/include/configs/tbs2910.h > @@ -8,6 +8,26 @@ > #ifndef __TBS2910_CONFIG_H > #define __TBS2910_CONFIG_H > > +#define CONFIG_BOOTCOMMAND \ > + "mmc rescan; " \ > + "if run bootcmd_up1; then " \ > + "run bootcmd_up2; " \ > + "else " \ > + "run bootcmd_mmc || run distro_bootcmd; " \ > + "fi" > + Why do you define CONFIG_BOOTCOMMAND here instead of modifying the existing one? > +#ifndef CONFIG_SPL_BUILD There in no SPL for tbs2910. So this is not required. > +#define BOOT_TARGET_DEVICES(func) \ > + func(MMC, mmc, 0) \ > + func(MMC, mmc, 1) \ > + func(MMC, mmc, 2) \ > + func(SATA, sata, 0) \ > + func(USB, usb, 0) \ > + func(PXE, pxe, na) \ > + func(DHCP, dhcp, na) > +#include > +#endif > + > #include "mx6_common.h" > > /* General configuration */ > @@ -80,6 +100,13 @@ > #define CONFIG_BOARD_SIZE_LIMIT 392192 /* (CONFIG_ENV_OFFSET - 1024) */ > > #define CONFIG_EXTRA_ENV_SETTINGS \ > + "fdt_addr=0x13000000\0" \ > + "fdt_addr_r=0x13000000\0" \ > + "initrd_high=0xffffffff\0" \ This should not be defined. Usually we want to relocate the initrd. Regards, Soeren > + "kernel_addr_r=0x10008000\0" \ > + "pxefile_addr_r=0x10008000\0" \ > + "ramdisk_addr_r=0x18000000\0" \ > + "scriptaddr=0x14000000\0" \ > "bootargs_mmc1=console=ttymxc0,115200 di0_primary console=tty1\0" \ > "bootargs_mmc2=video=mxcfb0:dev=hdmi,1920x1080M at 60 " \ > "video=mxcfb1:off video=mxcfb2:off fbmem=28M\0" \ > @@ -102,14 +129,8 @@ > "setenv stderr serial,vga\0" \ > "stderr=serial,vga\0" \ > "stdin=serial,usbkbd\0" \ > - "stdout=serial,vga\0" > - > -#define CONFIG_BOOTCOMMAND \ > - "mmc rescan; " \ > - "if run bootcmd_up1; then " \ > - "run bootcmd_up2; " \ > - "else " \ > - "run bootcmd_mmc; " \ > - "fi" > + "stdout=serial,vga\0" \ > + "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \ > + BOOTENV > > #endif /* __TBS2910_CONFIG_H * */