From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304B0C433DB for ; Mon, 11 Jan 2021 11:18:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7370224B1 for ; Mon, 11 Jan 2021 11:18:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729568AbhAKLS3 (ORCPT ); Mon, 11 Jan 2021 06:18:29 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:43340 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729549AbhAKLS3 (ORCPT ); Mon, 11 Jan 2021 06:18:29 -0500 Received: from tarshish.tkos.co.il (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 23C644407ED; Mon, 11 Jan 2021 13:17:46 +0200 (IST) From: Baruch Siach To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: Baruch Siach , Andrew Lunn , Gregory Clement , Russell King , Sebastian Hesselbarth , Thomas Petazzoni , Chris Packham , Sascha Hauer , Ralph Sennhauser , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/5] gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX Date: Mon, 11 Jan 2021 13:17:05 +0200 Message-Id: <97e5ed4dfc4385a99c585f7980210f9dd7c6ee3d.1610362661.git.baruch@tkos.co.il> X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org PWM on/off registers are limited to UINT_MAX. However the state period and duty_cycle fields are ns values of type u64. There is no reason to limit them to UINT_MAX. Reported-by: Uwe Kleine-König Signed-off-by: Baruch Siach --- drivers/gpio/gpio-mvebu.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index 6fc64846eda3..eb7456fa6d86 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -669,9 +669,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip, regmap_read(mvpwm->regs, mvebu_pwmreg_blink_on_duration(mvpwm), &u); val = (unsigned long long) u * NSEC_PER_SEC; val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate); - if (val > UINT_MAX) - state->duty_cycle = UINT_MAX; - else if (val) + if (val) state->duty_cycle = val; else state->duty_cycle = 1; @@ -681,9 +679,7 @@ static void mvebu_pwm_get_state(struct pwm_chip *chip, val += (unsigned long long) u; /* period = on + off duration */ val *= NSEC_PER_SEC; val = DIV_ROUND_UP_ULL(val, mvpwm->clk_rate); - if (val > UINT_MAX) - state->period = UINT_MAX; - else if (val) + if (val) state->period = val; else state->period = 1; -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDBCC433E0 for ; Mon, 11 Jan 2021 11:19:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96C9421D7F for ; Mon, 11 Jan 2021 11:19:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96C9421D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tkos.co.il Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cRZhAVBPg8HTqBfqpDcMNFkYLpg9YjFQJaBwtRnp4Y0=; b=d4F8wOxl6unbkMhvUsQE0tA9l WyQkm0KaiTriAWm/SrnHmB3dyv78oqWtwpNUcOAjUE3mLJJWK1/vTsVBTXX8+vlK2uhTSB7pYggxu sA6QKEYDH0k3skaakvPEYkF5xSJX8tCPIQZR8FNr4hQQ5yypSTBq2LWnMY+xBz5G+ukyvc7AQDJay kMs8NxXeo0t0RhkBNgx6aSyu9rD8i1YaPZ+/KJ1xhjzz/k937BcQhTqP71OO8R1zg8d/8vCUouwMF 3XwcoqGBItPHGBSiqjmEzZwq8ek3ym28uLknnc/T7i44Z9gPsL5FGJHnkvs0FgC3PObiNu+TwlpjB icNbOzNdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyvCy-0001sH-Kj; Mon, 11 Jan 2021 11:18:00 +0000 Received: from guitar.tcltek.co.il ([192.115.133.116] helo=mx.tkos.co.il) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kyvCn-0001pA-75 for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 11:17:50 +0000 Received: from tarshish.tkos.co.il (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 23C644407ED; Mon, 11 Jan 2021 13:17:46 +0200 (IST) From: Baruch Siach To: Thierry Reding , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Lee Jones , Linus Walleij , Bartosz Golaszewski Subject: [PATCH 4/5] gpio: mvebu: don't limit pwm period/duty_cycle to UINT_MAX Date: Mon, 11 Jan 2021 13:17:05 +0200 Message-Id: <97e5ed4dfc4385a99c585f7980210f9dd7c6ee3d.1610362661.git.baruch@tkos.co.il> X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_061749_493614_88BCECDC X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Baruch Siach , linux-pwm@vger.kernel.org, Gregory Clement , Russell King , linux-gpio@vger.kernel.org, Chris Packham , Thomas Petazzoni , Ralph Sennhauser , Sascha Hauer , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UFdNIG9uL29mZiByZWdpc3RlcnMgYXJlIGxpbWl0ZWQgdG8gVUlOVF9NQVguIEhvd2V2ZXIgdGhl IHN0YXRlIHBlcmlvZAphbmQgZHV0eV9jeWNsZSBmaWVsZHMgYXJlIG5zIHZhbHVlcyBvZiB0eXBl IHU2NC4gVGhlcmUgaXMgbm8gcmVhc29uIHRvCmxpbWl0IHRoZW0gdG8gVUlOVF9NQVguCgpSZXBv cnRlZC1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5k ZT4KU2lnbmVkLW9mZi1ieTogQmFydWNoIFNpYWNoIDxiYXJ1Y2hAdGtvcy5jby5pbD4KLS0tCiBk cml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jIHwgOCArKy0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwaW8v Z3Bpby1tdmVidS5jIGIvZHJpdmVycy9ncGlvL2dwaW8tbXZlYnUuYwppbmRleCA2ZmM2NDg0NmVk YTMuLmViNzQ1NmZhNmQ4NiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncGlvL2dwaW8tbXZlYnUuYwor KysgYi9kcml2ZXJzL2dwaW8vZ3Bpby1tdmVidS5jCkBAIC02NjksOSArNjY5LDcgQEAgc3RhdGlj IHZvaWQgbXZlYnVfcHdtX2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsCiAJcmVnbWFw X3JlYWQobXZwd20tPnJlZ3MsIG12ZWJ1X3B3bXJlZ19ibGlua19vbl9kdXJhdGlvbihtdnB3bSks ICZ1KTsKIAl2YWwgPSAodW5zaWduZWQgbG9uZyBsb25nKSB1ICogTlNFQ19QRVJfU0VDOwogCXZh bCA9IERJVl9ST1VORF9VUF9VTEwodmFsLCBtdnB3bS0+Y2xrX3JhdGUpOwotCWlmICh2YWwgPiBV SU5UX01BWCkKLQkJc3RhdGUtPmR1dHlfY3ljbGUgPSBVSU5UX01BWDsKLQllbHNlIGlmICh2YWwp CisJaWYgKHZhbCkKIAkJc3RhdGUtPmR1dHlfY3ljbGUgPSB2YWw7CiAJZWxzZQogCQlzdGF0ZS0+ ZHV0eV9jeWNsZSA9IDE7CkBAIC02ODEsOSArNjc5LDcgQEAgc3RhdGljIHZvaWQgbXZlYnVfcHdt X2dldF9zdGF0ZShzdHJ1Y3QgcHdtX2NoaXAgKmNoaXAsCiAJdmFsICs9ICh1bnNpZ25lZCBsb25n IGxvbmcpIHU7IC8qIHBlcmlvZCA9IG9uICsgb2ZmIGR1cmF0aW9uICovCiAJdmFsICo9IE5TRUNf UEVSX1NFQzsKIAl2YWwgPSBESVZfUk9VTkRfVVBfVUxMKHZhbCwgbXZwd20tPmNsa19yYXRlKTsK LQlpZiAodmFsID4gVUlOVF9NQVgpCi0JCXN0YXRlLT5wZXJpb2QgPSBVSU5UX01BWDsKLQllbHNl IGlmICh2YWwpCisJaWYgKHZhbCkKIAkJc3RhdGUtPnBlcmlvZCA9IHZhbDsKIAllbHNlCiAJCXN0 YXRlLT5wZXJpb2QgPSAxOwotLSAKMi4yOS4yCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=