All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc
Date: Fri, 19 Oct 2018 13:51:44 +0200	[thread overview]
Message-ID: <97ec9ea1-839d-ab27-a691-5d3c02d76563@redhat.com> (raw)
In-Reply-To: <20181019104326.28052-1-alex.bennee@linaro.org>

On 19/10/2018 12:43, Alex Bennée wrote:
> The purpose of the code is to use the designated compiler for building
> the targets test cases. This is not actually host_cc which will still
> be cc even when we are cross compiling. As the tests for $cpu all use
> $cc we should do the same.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  configure | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/configure b/configure
> index 9138af37f8..d6605bd633 100755
> --- a/configure
> +++ b/configure
> @@ -717,37 +717,37 @@ case "$cpu" in
>    ppc|ppc64|s390|s390x|sparc64|x32)
>      cpu="$cpu"
>      supported_cpu="yes"
> -    eval "cross_cc_${cpu}=\$host_cc"
> +    eval "cross_cc_${cpu}=\$cc"
>    ;;
>    i386|i486|i586|i686|i86pc|BePC)
>      cpu="i386"
>      supported_cpu="yes"
> -    cross_cc_i386=$host_cc
> +    cross_cc_i386=$cc
>    ;;
>    x86_64|amd64)
>      cpu="x86_64"
>      supported_cpu="yes"
> -    cross_cc_x86_64=$host_cc
> +    cross_cc_x86_64=$cc
>    ;;
>    armv*b|armv*l|arm)
>      cpu="arm"
>      supported_cpu="yes"
> -    cross_cc_arm=$host_cc
> +    cross_cc_arm=$cc
>    ;;
>    aarch64)
>      cpu="aarch64"
>      supported_cpu="yes"
> -    cross_cc_aarch64=$host_cc
> +    cross_cc_aarch64=$cc
>    ;;
>    mips*)
>      cpu="mips"
>      supported_cpu="yes"
> -    cross_cc_mips=$host_cc
> +    cross_cc_mips=$cc
>    ;;
>    sparc|sun4[cdmuv])
>      cpu="sparc"
>      supported_cpu="yes"
> -    cross_cc_sparc=$host_cc
> +    cross_cc_sparc=$cc
>    ;;
>    *)
>      # This will result in either an error or falling back to TCI later
> 

  parent reply	other threads:[~2018-10-19 11:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 10:43 [Qemu-devel] [PATCH] configure: set cross_cc_FOO from cc, not host_cc Alex Bennée
2018-10-19 11:49 ` Thomas Huth
2018-10-19 11:51 ` Philippe Mathieu-Daudé [this message]
2018-10-19 16:56 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97ec9ea1-839d-ab27-a691-5d3c02d76563@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.