* [PATCH] hw/display/macfb: Classify the "nubus-macfb" as display device
@ 2021-05-31 7:32 Thomas Huth
2021-05-31 8:12 ` Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2021-05-31 7:32 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Laurent Vivier
The "nubus-macfb" currently shows up as uncategorized device in
the output of "-device help". Put it into the display category
to fix this ugliness.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/display/macfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index ff8bdb846b..d8183b9bbd 100644
--- a/hw/display/macfb.c
+++ b/hw/display/macfb.c
@@ -450,6 +450,7 @@ static void macfb_nubus_class_init(ObjectClass *klass, void *data)
dc->desc = "Nubus Macintosh framebuffer";
dc->reset = macfb_nubus_reset;
dc->vmsd = &vmstate_macfb;
+ set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
device_class_set_props(dc, macfb_nubus_properties);
}
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/display/macfb: Classify the "nubus-macfb" as display device
2021-05-31 7:32 [PATCH] hw/display/macfb: Classify the "nubus-macfb" as display device Thomas Huth
@ 2021-05-31 8:12 ` Laurent Vivier
2021-05-31 8:52 ` Philippe Mathieu-Daudé
2021-06-05 19:22 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-05-31 8:12 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial
Le 31/05/2021 à 09:32, Thomas Huth a écrit :
> The "nubus-macfb" currently shows up as uncategorized device in
> the output of "-device help". Put it into the display category
> to fix this ugliness.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/display/macfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/macfb.c b/hw/display/macfb.c
> index ff8bdb846b..d8183b9bbd 100644
> --- a/hw/display/macfb.c
> +++ b/hw/display/macfb.c
> @@ -450,6 +450,7 @@ static void macfb_nubus_class_init(ObjectClass *klass, void *data)
> dc->desc = "Nubus Macintosh framebuffer";
> dc->reset = macfb_nubus_reset;
> dc->vmsd = &vmstate_macfb;
> + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> device_class_set_props(dc, macfb_nubus_properties);
> }
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/display/macfb: Classify the "nubus-macfb" as display device
2021-05-31 7:32 [PATCH] hw/display/macfb: Classify the "nubus-macfb" as display device Thomas Huth
2021-05-31 8:12 ` Laurent Vivier
@ 2021-05-31 8:52 ` Philippe Mathieu-Daudé
2021-06-05 19:22 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-31 8:52 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial, Laurent Vivier
On 5/31/21 9:32 AM, Thomas Huth wrote:
> The "nubus-macfb" currently shows up as uncategorized device in
> the output of "-device help". Put it into the display category
> to fix this ugliness.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/display/macfb.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/display/macfb: Classify the "nubus-macfb" as display device
2021-05-31 7:32 [PATCH] hw/display/macfb: Classify the "nubus-macfb" as display device Thomas Huth
2021-05-31 8:12 ` Laurent Vivier
2021-05-31 8:52 ` Philippe Mathieu-Daudé
@ 2021-06-05 19:22 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-06-05 19:22 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial
Le 31/05/2021 à 09:32, Thomas Huth a écrit :
> The "nubus-macfb" currently shows up as uncategorized device in
> the output of "-device help". Put it into the display category
> to fix this ugliness.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/display/macfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/macfb.c b/hw/display/macfb.c
> index ff8bdb846b..d8183b9bbd 100644
> --- a/hw/display/macfb.c
> +++ b/hw/display/macfb.c
> @@ -450,6 +450,7 @@ static void macfb_nubus_class_init(ObjectClass *klass, void *data)
> dc->desc = "Nubus Macintosh framebuffer";
> dc->reset = macfb_nubus_reset;
> dc->vmsd = &vmstate_macfb;
> + set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> device_class_set_props(dc, macfb_nubus_properties);
> }
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-05 19:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 7:32 [PATCH] hw/display/macfb: Classify the "nubus-macfb" as display device Thomas Huth
2021-05-31 8:12 ` Laurent Vivier
2021-05-31 8:52 ` Philippe Mathieu-Daudé
2021-06-05 19:22 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.