All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Daniel Wagner <dwagner@suse.de>
Cc: linux-nvme@lists.infradead.org
Subject: Re: crash at nvme_tcp_init_iter with header digest enabled
Date: Mon, 5 Sep 2022 13:53:00 +0300	[thread overview]
Message-ID: <9803c44c-e7dd-ba06-2195-9287f8890884@grimberg.me> (raw)
In-Reply-To: <20220905102612.xur4ul2bhade6ccv@carbon.lan>


>>> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
>>> index e82dcfcda29b..3e3ebde4eff5 100644
>>> --- a/drivers/nvme/host/tcp.c
>>> +++ b/drivers/nvme/host/tcp.c
>>> @@ -1229,7 +1229,7 @@ static void nvme_tcp_io_work(struct work_struct *w)
>>>                   else if (unlikely(result < 0))
>>>                           return;
>>>
>>> -               if (!pending)
>>> +               if (!pending || !queue->rd_enabled)
>>>                           return;
>>>
>>>           } while (!time_after(jiffies, deadline)); /* quota is exhausted */
>>> -- 
>>
>> Daniel, any input here?
> 
> I haven't heard anything from our customer yet. Let me ping them again.

Most likely it should address the issue, but the proposed patch is a fix
regardless.

Will send it as a proper patch, would love to get your reviewed-by, and
when you hear from your customer, you can add Tested-by tag.


      reply	other threads:[~2022-09-05 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  7:51 crash at nvme_tcp_init_iter with header digest enabled Daniel Wagner
2022-08-28 12:09 ` Sagi Grimberg
2022-09-05  9:46   ` Sagi Grimberg
2022-09-05 10:26     ` Daniel Wagner
2022-09-05 10:53       ` Sagi Grimberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9803c44c-e7dd-ba06-2195-9287f8890884@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=dwagner@suse.de \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.