All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Enhancements for TI INA219/220 current/voltage monitors
@ 2017-04-12  3:01 Stefan Brüns
  2017-04-14 14:45 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Brüns @ 2017-04-12  3:01 UTC (permalink / raw)
  To: linux-iio
  Cc: linux-kernel, Jonathan Cameron, Hartmut Knaack,
	Lars-Peter Clausen, Peter Meerwald-Stadler, Stefan Brüns

The ina2xx adc driver does not handle differences between INA219/220 and
INA226/230/231 completely:

- The 219 uses a 4 bit register field for for the bus/shunt voltage adc
  integration times each, whereas the 226 uses two 3 bit fields for the
  integration times and an additional 3 bit averaging field.

  The first patch correct setting integration times in the config register.

- The 219 also has an adjustable PGA. The default setting allows the
  maximum range, but also reduces accuracy.

  The second patch adds attributes for shunt PGA gain and bus voltage
  range (bus voltage PGA), and sets the config register accordingly.

Stefan Brüns (2):
  iio: adc: Fix integration time/averaging for INA219/220
  iio: adc: Allow setting Shunt Voltage PGA gain and Bus Voltage range

 drivers/iio/adc/ina2xx-adc.c | 344 ++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 322 insertions(+), 22 deletions(-)

-- 
2.12.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 0/2] Enhancements for TI INA219/220 current/voltage monitors
  2017-04-12  3:01 [PATCH 0/2] Enhancements for TI INA219/220 current/voltage monitors Stefan Brüns
@ 2017-04-14 14:45 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-04-14 14:45 UTC (permalink / raw)
  To: Stefan Brüns, linux-iio
  Cc: linux-kernel, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, Marc Titinger

On 12/04/17 04:01, Stefan Brüns wrote:
> The ina2xx adc driver does not handle differences between INA219/220 and
> INA226/230/231 completely:
> 
> - The 219 uses a 4 bit register field for for the bus/shunt voltage adc
>   integration times each, whereas the 226 uses two 3 bit fields for the
>   integration times and an additional 3 bit averaging field.
> 
>   The first patch correct setting integration times in the config register.
> 
> - The 219 also has an adjustable PGA. The default setting allows the
>   maximum range, but also reduces accuracy.
> 
>   The second patch adds attributes for shunt PGA gain and bus voltage
>   range (bus voltage PGA), and sets the config register accordingly.
> 
> Stefan Brüns (2):
>   iio: adc: Fix integration time/averaging for INA219/220
>   iio: adc: Allow setting Shunt Voltage PGA gain and Bus Voltage range
> 
>  drivers/iio/adc/ina2xx-adc.c | 344 ++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 322 insertions(+), 22 deletions(-)
> 
These will definitely need an Ack from Marc Titinger if possible.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-14 14:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12  3:01 [PATCH 0/2] Enhancements for TI INA219/220 current/voltage monitors Stefan Brüns
2017-04-14 14:45 ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.