From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B76C43461 for ; Thu, 8 Apr 2021 09:57:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB2EB61166 for ; Thu, 8 Apr 2021 09:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231512AbhDHJ5z (ORCPT ); Thu, 8 Apr 2021 05:57:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:21667 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231407AbhDHJ5x (ORCPT ); Thu, 8 Apr 2021 05:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617875862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5qRbCj/1Pw0sbqnFA7cAFN0KaHJ1niBYvUatQLNt7yA=; b=ALb58AOwBwYK8A7HXNk0ZWUrNaJeeHWvTMAN6gIOEl4lTYeKuY7pp7iLmYkl5oCBAVqeME Q9qxFD21gOvcIyZo20Uy0RYHLOna8MsMcj4b6uAjz9RfqpawpqoR8y3OvryR+mu+v8oV3h H8OZv7Nl7WUtty44R8z9YGigPjAQibs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-NppAuqKfOUeFeTzIB7gHeQ-1; Thu, 08 Apr 2021 05:57:39 -0400 X-MC-Unique: NppAuqKfOUeFeTzIB7gHeQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8F5987A83A; Thu, 8 Apr 2021 09:57:36 +0000 (UTC) Received: from [10.36.114.231] (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5501E5D9CA; Thu, 8 Apr 2021 09:57:32 +0000 (UTC) Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Linus Walleij , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <9826d7ef-7f7e-987e-c305-7ae3c533d591@redhat.com> Date: Thu, 8 Apr 2021 11:57:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.04.21 11:56, Mike Rapoport wrote: > On Thu, Apr 08, 2021 at 11:20:11AM +0200, David Hildenbrand wrote: >> Random drivers should not override a user configuration of core knobs >> (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect >> dependencies and manual overrides. >> >> "This is similar to "select" as it enforces a lower limit on another >> symbol except that the "implied" symbol's value may still be set to n >> from a direct dependency or with a visible prompt." >> >> Implying DRM_CMA should be sufficient, as that depends on CMA. > > ^ DMA_CMA >> >> Note: If this is a real dependency, we should use "depends on DMA_CMA" >> instead - but I assume the driver can work without CMA just fine -- >> esp. when we wouldn't have HAVE_DMA_CONTIGUOUS right now. >> >> Signed-off-by: David Hildenbrand >> --- >> drivers/gpu/drm/aspeed/Kconfig | 3 +-- >> drivers/gpu/drm/etnaviv/Kconfig | 3 +-- >> 2 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig >> index 5e95bcea43e9..a055f763d230 100644 >> --- a/drivers/gpu/drm/aspeed/Kconfig >> +++ b/drivers/gpu/drm/aspeed/Kconfig >> @@ -6,9 +6,8 @@ config DRM_ASPEED_GFX >> depends on MMU >> select DRM_KMS_HELPER >> select DRM_KMS_CMA_HELPER >> - select DMA_CMA if HAVE_DMA_CONTIGUOUS >> - select CMA if HAVE_DMA_CONTIGUOUS >> select MFD_SYSCON >> + imply DRM_CMA > > Ditto Gah, thanks! -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D63C433B4 for ; Thu, 8 Apr 2021 09:59:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06438610FB for ; Thu, 8 Apr 2021 09:59:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06438610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D0bd2ijDOTbn7Gbz87IPjS+39msANjKrz6Xy58dQIsQ=; b=iUvVEXOx/0FA2ltvLrp65vL6q pSHrzLJafwV/HdKBAxnndgujTcOrqOfeUid/Es5fjsZekRoHSq3hM8ZTGW4lzs6iOD8jyMrK2dtig cex8NtKIm3SqQ9OBzd6eQYSjgh21URW7uWBOH2QIbJvt2SscIiRPQ6K2k24I3226HGvzBEOm/uE/M B2CO+tDTqqoD/5wUjHr8hWqpqB2GaAZVwVgrl1emfkZBX3xdJ0WfczgdB4Libar3h5ai0AY2gvsZH 6MMoO1FBMB967LzFc+iRFwyrK8pRgP3ZtLJ+leN4R6QAFxXJJPtzfd3rEs60uoGJzx8voRRGuetpE xiC93XK4w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lURQ4-007ZXA-3X; Thu, 08 Apr 2021 09:57:48 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lURPz-007ZVc-UM for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 09:57:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617875862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5qRbCj/1Pw0sbqnFA7cAFN0KaHJ1niBYvUatQLNt7yA=; b=ALb58AOwBwYK8A7HXNk0ZWUrNaJeeHWvTMAN6gIOEl4lTYeKuY7pp7iLmYkl5oCBAVqeME Q9qxFD21gOvcIyZo20Uy0RYHLOna8MsMcj4b6uAjz9RfqpawpqoR8y3OvryR+mu+v8oV3h H8OZv7Nl7WUtty44R8z9YGigPjAQibs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-NppAuqKfOUeFeTzIB7gHeQ-1; Thu, 08 Apr 2021 05:57:39 -0400 X-MC-Unique: NppAuqKfOUeFeTzIB7gHeQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8F5987A83A; Thu, 8 Apr 2021 09:57:36 +0000 (UTC) Received: from [10.36.114.231] (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5501E5D9CA; Thu, 8 Apr 2021 09:57:32 +0000 (UTC) Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Linus Walleij , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-fbdev@vger.kernel.org References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <9826d7ef-7f7e-987e-c305-7ae3c533d591@redhat.com> Date: Thu, 8 Apr 2021 11:57:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_105744_216475_BECC8111 X-CRM114-Status: GOOD ( 22.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08.04.21 11:56, Mike Rapoport wrote: > On Thu, Apr 08, 2021 at 11:20:11AM +0200, David Hildenbrand wrote: >> Random drivers should not override a user configuration of core knobs >> (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect >> dependencies and manual overrides. >> >> "This is similar to "select" as it enforces a lower limit on another >> symbol except that the "implied" symbol's value may still be set to n >> from a direct dependency or with a visible prompt." >> >> Implying DRM_CMA should be sufficient, as that depends on CMA. > > ^ DMA_CMA >> >> Note: If this is a real dependency, we should use "depends on DMA_CMA" >> instead - but I assume the driver can work without CMA just fine -- >> esp. when we wouldn't have HAVE_DMA_CONTIGUOUS right now. >> >> Signed-off-by: David Hildenbrand >> --- >> drivers/gpu/drm/aspeed/Kconfig | 3 +-- >> drivers/gpu/drm/etnaviv/Kconfig | 3 +-- >> 2 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig >> index 5e95bcea43e9..a055f763d230 100644 >> --- a/drivers/gpu/drm/aspeed/Kconfig >> +++ b/drivers/gpu/drm/aspeed/Kconfig >> @@ -6,9 +6,8 @@ config DRM_ASPEED_GFX >> depends on MMU >> select DRM_KMS_HELPER >> select DRM_KMS_CMA_HELPER >> - select DMA_CMA if HAVE_DMA_CONTIGUOUS >> - select CMA if HAVE_DMA_CONTIGUOUS >> select MFD_SYSCON >> + imply DRM_CMA > > Ditto Gah, thanks! -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6DE8C433ED for ; Thu, 8 Apr 2021 09:57:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C9A961157 for ; Thu, 8 Apr 2021 09:57:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C9A961157 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA2436EA5B; Thu, 8 Apr 2021 09:57:43 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69FB06EA58 for ; Thu, 8 Apr 2021 09:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617875862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5qRbCj/1Pw0sbqnFA7cAFN0KaHJ1niBYvUatQLNt7yA=; b=ALb58AOwBwYK8A7HXNk0ZWUrNaJeeHWvTMAN6gIOEl4lTYeKuY7pp7iLmYkl5oCBAVqeME Q9qxFD21gOvcIyZo20Uy0RYHLOna8MsMcj4b6uAjz9RfqpawpqoR8y3OvryR+mu+v8oV3h H8OZv7Nl7WUtty44R8z9YGigPjAQibs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-NppAuqKfOUeFeTzIB7gHeQ-1; Thu, 08 Apr 2021 05:57:39 -0400 X-MC-Unique: NppAuqKfOUeFeTzIB7gHeQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8F5987A83A; Thu, 8 Apr 2021 09:57:36 +0000 (UTC) Received: from [10.36.114.231] (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5501E5D9CA; Thu, 8 Apr 2021 09:57:32 +0000 (UTC) Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: Mike Rapoport References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <9826d7ef-7f7e-987e-c305-7ae3c533d591@redhat.com> Date: Thu, 8 Apr 2021 11:57:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Arnd Bergmann , Bartlomiej Zolnierkiewicz , David Airlie , Andrew Jeffery , Randy Dunlap , etnaviv@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Simek , linux-mm@kvack.org, Joel Stanley , Russell King , Peter Collingbourne , Masahiro Yamada , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 08.04.21 11:56, Mike Rapoport wrote: > On Thu, Apr 08, 2021 at 11:20:11AM +0200, David Hildenbrand wrote: >> Random drivers should not override a user configuration of core knobs >> (e.g., CONFIG_DMA_CMA=n). Use "imply" instead, to still respect >> dependencies and manual overrides. >> >> "This is similar to "select" as it enforces a lower limit on another >> symbol except that the "implied" symbol's value may still be set to n >> from a direct dependency or with a visible prompt." >> >> Implying DRM_CMA should be sufficient, as that depends on CMA. > > ^ DMA_CMA >> >> Note: If this is a real dependency, we should use "depends on DMA_CMA" >> instead - but I assume the driver can work without CMA just fine -- >> esp. when we wouldn't have HAVE_DMA_CONTIGUOUS right now. >> >> Signed-off-by: David Hildenbrand >> --- >> drivers/gpu/drm/aspeed/Kconfig | 3 +-- >> drivers/gpu/drm/etnaviv/Kconfig | 3 +-- >> 2 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/aspeed/Kconfig b/drivers/gpu/drm/aspeed/Kconfig >> index 5e95bcea43e9..a055f763d230 100644 >> --- a/drivers/gpu/drm/aspeed/Kconfig >> +++ b/drivers/gpu/drm/aspeed/Kconfig >> @@ -6,9 +6,8 @@ config DRM_ASPEED_GFX >> depends on MMU >> select DRM_KMS_HELPER >> select DRM_KMS_CMA_HELPER >> - select DMA_CMA if HAVE_DMA_CONTIGUOUS >> - select CMA if HAVE_DMA_CONTIGUOUS >> select MFD_SYSCON >> + imply DRM_CMA > > Ditto Gah, thanks! -- Thanks, David / dhildenb _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel