All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Nadav Amit <nadav.amit@gmail.com>,
	"kernel@collabora.com" <kernel@collabora.com>
Subject: Re: [PATCH v2] mm/uffd: UFFD_FEATURE_WP_UNPOPULATED
Date: Thu, 2 Mar 2023 15:01:26 +0100	[thread overview]
Message-ID: <982c1623-ac28-2743-d6a3-4faf42f72d47@redhat.com> (raw)
In-Reply-To: <ZACrOWKWdVYO/EAI@x1n>

On 02.03.23 14:57, Peter Xu wrote:
> On Thu, Mar 02, 2023 at 10:37:44AM +0100, David Hildenbrand wrote:
>> Especially for such large sparse VMAs, the current way of allocating
>> pagetables to place markers/zeropages is far from optimal.
> 
> IMHO that's not a generic workload.  As mentioned in the reply there, I
> would suggest we go with simple then we have space to optimize it in the
> future if necessary, because the API will be the same.
> 

I disagree with "generic workload", we use sparse mmaps all over the 
place, and when blindly used by e.g., CRIU, we'll simply end up wasting 
memory and time.

But I already agreed that this optimization that is a separate thing to 
implement.

-- 
Thanks,

David / dhildenb


  reply	other threads:[~2023-03-02 14:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 23:00 [PATCH v2] mm/uffd: UFFD_FEATURE_WP_UNPOPULATED Peter Xu
2023-02-28  0:36 ` Peter Xu
2023-02-28  7:21   ` Muhammad Usama Anjum
2023-02-28 15:58     ` Peter Xu
2023-02-28 16:24       ` Muhammad Usama Anjum
2023-03-01  7:55         ` Muhammad Usama Anjum
2023-03-01 15:19           ` Peter Xu
2023-03-01 17:13             ` Muhammad Usama Anjum
2023-03-02  9:37               ` David Hildenbrand
2023-03-02 13:57                 ` Peter Xu
2023-03-02 14:01                   ` David Hildenbrand [this message]
2023-03-02 15:14                     ` Muhammad Usama Anjum
2023-03-02 22:00                       ` Peter Xu
2023-03-02 17:19   ` Muhammad Usama Anjum
2023-03-02 17:38     ` David Hildenbrand
2023-03-02 22:21       ` Peter Xu
2023-03-03  6:42         ` Muhammad Usama Anjum
2023-03-03 16:47           ` Peter Xu
2023-03-06  9:03             ` Muhammad Usama Anjum
2023-03-06 16:09               ` Muhammad Usama Anjum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=982c1623-ac28-2743-d6a3-4faf42f72d47@redhat.com \
    --to=david@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nadav.amit@gmail.com \
    --cc=peterx@redhat.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.