From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: alp.oezmert@mercedes-benz.com, bitbake-devel@lists.openembedded.org
Cc: changhyeok.bae@mercedes-benz.com
Subject: Re: [bitbake-devel] [PATCH] wget: Add CHECKMD_wget option
Date: Mon, 19 Dec 2022 10:58:43 +0000 [thread overview]
Message-ID: <982d94511de46a7c9e7eed63c1c1cdc89d4ca816.camel@linuxfoundation.org> (raw)
In-Reply-To: <a7e199839adbd9e003c04d1bd021f5f0d8f2cc3c.camel@mercedes-benz.com>
On Mon, 2022-12-19 at 08:55 +0000, alp.oezmert via lists.openembedded.org wrote:
> `CHECKCMD_wget` defines a command that the wget fetcher module will execute
> instead of the built-in HTTP client when checking if URLs exist.
This says what the patch does, but not why. I can read the patch and
see what the code change is but I can't know why we need to so this
information is much more important for the commit message.
> This
> allows to completely match the behavior of the wget fetcher including proxy
> and authentication.
We're changing the behaviour of the wget fetcher to match the wget
fetcher? This doesn't make any sense.
> By default, this option is empty, and wget fetcher behavior is not changed.
Why do we need this? Why can't the HTTP client be used?
What this appears to do is add two different code paths meaning we need
to double our testing. I really don't want to do that.
Can't the inbuilt http client code be fixed to work with whatever
auth/proxy issue I'm guessing you're running into?
Cheers,
Richard
next prev parent reply other threads:[~2022-12-19 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 8:55 [PATCH] wget: Add CHECKMD_wget option alp.oezmert
2022-12-19 10:58 ` Richard Purdie [this message]
2022-12-19 13:44 ` [bitbake-devel] " alp.oezmert
2022-12-19 14:26 ` Richard Purdie
2022-12-19 14:57 ` alp.oezmert
2022-12-19 15:02 ` Richard Purdie
2022-12-19 15:32 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=982d94511de46a7c9e7eed63c1c1cdc89d4ca816.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alp.oezmert@mercedes-benz.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=changhyeok.bae@mercedes-benz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.