From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Subject: Re: [PATCH kernel] vfio/spapr_tce: Check kzalloc() return when preregistering memory Date: Tue, 11 Apr 2017 18:27:49 +1000 Message-ID: <982ff977-620a-e940-8d64-24bb213ea931@ozlabs.ru> References: <20170327032340.18656-1-aik@ozlabs.ru> <20170327042457.GU19078@umbus.fritz.box> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c45PGRbPp97v4u2Hmrr2AsMMOJHsq3Cba" Cc: David Gibson , kvm@vger.kernel.org To: Alex Williamson Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:35293 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbdDKI1z (ORCPT ); Tue, 11 Apr 2017 04:27:55 -0400 Received: by mail-pf0-f195.google.com with SMTP id a188so4044187pfa.2 for ; Tue, 11 Apr 2017 01:27:55 -0700 (PDT) In-Reply-To: <20170327042457.GU19078@umbus.fritz.box> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c45PGRbPp97v4u2Hmrr2AsMMOJHsq3Cba Content-Type: multipart/mixed; boundary="ScpsPxo5bmwH9S4Hbauudn8WoMNjbiW2k"; protected-headers="v1" From: Alexey Kardashevskiy To: Alex Williamson Cc: David Gibson , kvm@vger.kernel.org Message-ID: <982ff977-620a-e940-8d64-24bb213ea931@ozlabs.ru> Subject: Re: [PATCH kernel] vfio/spapr_tce: Check kzalloc() return when preregistering memory References: <20170327032340.18656-1-aik@ozlabs.ru> <20170327042457.GU19078@umbus.fritz.box> In-Reply-To: <20170327042457.GU19078@umbus.fritz.box> --ScpsPxo5bmwH9S4Hbauudn8WoMNjbiW2k Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable On 27/03/17 15:24, David Gibson wrote: > On Mon, Mar 27, 2017 at 02:23:40PM +1100, Alexey Kardashevskiy wrote: >> This adds missing checking for kzalloc() return value. >> >> Fixes: 4b6fad7097f8 ("powerpc/mm/iommu, vfio/spapr: Put pages on VFIO = container shutdown") >> Signed-off-by: Alexey Kardashevskiy >=20 > Reviewed-by: David Gibson Alex? >=20 >> --- >> drivers/vfio/vfio_iommu_spapr_tce.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_i= ommu_spapr_tce.c >> index cf3de91fbfe7..c298bb36e27a 100644 >> --- a/drivers/vfio/vfio_iommu_spapr_tce.c >> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c >> @@ -198,6 +198,11 @@ static long tce_iommu_register_pages(struct tce_c= ontainer *container, >> return ret; >> =20 >> tcemem =3D kzalloc(sizeof(*tcemem), GFP_KERNEL); >> + if (!tcemem) { >> + mm_iommu_put(container->mm, mem); >> + return -ENOMEM; >> + } >> + >> tcemem->mem =3D mem; >> list_add(&tcemem->next, &container->prereg_list); >> =20 >=20 --=20 Alexey --ScpsPxo5bmwH9S4Hbauudn8WoMNjbiW2k-- --c45PGRbPp97v4u2Hmrr2AsMMOJHsq3Cba Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIrBAEBCAAVBQJY7JOGDhxhaWtAb3psYWJzLnJ1AAoJEIYTPdgrwSC5MQAQAJJw plgF3SqBRTm+AsG2r2nGqoUwwHXyw+c3PVaC28p/ZYXBoFIjd8LOwGykZpq0JRRB fp1F6T2LY9JdxB51o+2JL5Vdb3UnBMAUjLu7Jwqgg+0/fIq38TKhP8xAVwocCCDG uev2ItCReaemzt+8lYQKzOi3c9J+1BTIFetKnOXa93gPjeCE7lVFLatp3KSmscaD 5DInoAN9ZYwWuDUmeV/IcOnWU5JFRwBoWsmQMTQ0xk0CVpvs+m2KqLR5pf1O8U6B 738feOvC9O2+M5jhYuZ+KZdoTRu35a4Zyd6onjjZz1fhO9S2BM5HJfbZAzorM3Zg NSorhmVxQys7UnsDN3zk6bFd/BD6f6/m1cqCsKB+wIhXryEC/8X79NzVzflsst+B o0z8xn3sDtsOgI3ET+53GtDkyW2uUy7954+U9QB0/iv8cGgc9o5qbb81HB+K3vXs 4Su1S5H3yqI3l5hWq/vKNoNJRBMIOD3sqCFKTS6hIEfSKdNgObAtCCVi+lQuIJXJ FyrSu809q49woj2/CEQ2XBeRDsM5zGD+EvrGVWR0GA8xN8ZKYWgEbTWwl3STEQ+O v7/vsc7mPu9tr91/DyUZm6EEMKAagX93y6kO0MrZ3ANwLLE95hRGddA5Iuw8Pv3D sTxRiZ0VPI0rlFHmViwBpw+qpsD04Rj0jhMXG1HV =V4C3 -----END PGP SIGNATURE----- --c45PGRbPp97v4u2Hmrr2AsMMOJHsq3Cba--