From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Rafael Ristovski" <rafael.ristovski@gmail.com>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>
Subject: Re: [PATCH v2] drm/i915: Make legacy cursor updates more unsynced
Date: Tue, 4 Apr 2017 17:50:10 +0200 [thread overview]
Message-ID: <9847408c-842a-9cb7-de34-d1e769665b36@linux.intel.com> (raw)
In-Reply-To: <20170329142123.5923-1-ville.syrjala@linux.intel.com>
Op 29-03-17 om 16:21 schreef ville.syrjala@linux.intel.com:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We're clearing the legacy_cursor_update flag before calling
> drm_atomic_helper_setup_commit() which means the helper will
> wait for the flip to complete before cleaning up the framebuffers.
> That's not what we want for the legacy cursor, so let's clear
> the flag after setting up the commit.
>
> Also toss in a FIXME about solving these problems in a nicer
> way using the fabled vblank workers.
>
> v2: Also unsync with legacy page flips
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
> Cc: Rafael Ristovski <rafael.ristovski@gmail.com>
> Fixes: a5509abda48e ("drm/i915: Fix legacy cursor vs. watermarks for ILK-BDW")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-04-04 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:35 [PATCH] drm/i915: Make legacy cursor updates more unsynced ville.syrjala
2017-03-28 19:52 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-03-29 13:56 ` [PATCH] " Maarten Lankhorst
2017-03-29 14:21 ` [PATCH v2] " ville.syrjala
2017-04-04 15:50 ` Maarten Lankhorst [this message]
2017-04-04 16:55 ` Ville Syrjälä
2017-03-29 14:38 ` ✓ Fi.CI.BAT: success for drm/i915: Make legacy cursor updates more unsynced (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9847408c-842a-9cb7-de34-d1e769665b36@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rafael.ristovski@gmail.com \
--cc=uwe@kleine-koenig.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.