From: Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
"Lin, Mengdong" <mengdong.lin@intel.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"Koul, Vinod" <vinod.koul@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"mengdong.lin@linux.intel.com" <mengdong.lin@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH v2 1/2] ASoC: core: Add API to use DMI name in sound card long name
Date: Tue, 3 Jan 2017 14:09:28 -0600 [thread overview]
Message-ID: <984e6c66-c1c9-c37b-f6b6-d357cd967d48@intel.com> (raw)
In-Reply-To: <1483471712.4063.17.camel@loki>
>>> I dont think we need vendor (it just makes it too long). The product or board
>>> name should be unique enough for us to load the correct files.
>>>
>>> Liam
>> Yes, from the sample machines I checked, product or board name are
>> unique. But I feel there might be the risk that two vendors happen to
>> use the same product or board name, e.g. "T100TA".
> I think this would be problematic from a legal/marketing position from
> two different vendors so it would be unlikely.
Please don't remove the manufacturer name for now...
Some vendors use product names that are indeed unique and easy enough to
remember, but others like Lenovo use "1952W5R" or "20C3001VHH" (real
examples you can Google to see I am not making this up). The board name
can also be "SKG18 t". I really have no appetite for a UCM directory
called 20C3001VHH.SKG18t :-)
I would also be ready to bet that smaller manufacturers in the Chinese
ecosystem use similar product names at the DMI level. removing the
vendor name would likely result in mistakes.
You really want the manufacturer name to make the maintenance of these
files easier on the rest of us. Sometimes the DMI version field is
actually more self-explanatory, e.g. "ThinkPad 60" or "ThinkPad 10" for
the two Lenovo examples, maybe this is something we ought to look at.
next prev parent reply other threads:[~2017-01-03 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 4:58 [PATCH v2 0/2] ASoC: Use DMI name in sound card long name mengdong.lin
2017-01-03 4:58 ` [PATCH v2 1/2] ASoC: core: Add API to use " mengdong.lin
2017-01-03 14:40 ` Liam Girdwood
2017-01-03 15:44 ` Lin, Mengdong
2017-01-03 19:28 ` Liam Girdwood
2017-01-03 20:09 ` Pierre-Louis Bossart [this message]
2017-01-04 7:03 ` Mengdong Lin
2017-01-04 21:47 ` Liam Girdwood
2017-01-06 6:07 ` Mengdong Lin
2017-01-09 11:13 ` Liam Girdwood
2017-01-03 5:00 ` [PATCH v2 2/2] ASoC: Intel: Use DMI name for sound card long name in Broadwell machine driver mengdong.lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=984e6c66-c1c9-c37b-f6b6-d357cd967d48@intel.com \
--to=pierre-louis.bossart@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.