All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rasesh Mody <rasesh.mody@cavium.com>, dev@dpdk.org
Cc: Dept-EngDPDKDev@cavium.com
Subject: Re: [PATCH v2 7/8] net/qede: add missing check for VNI
Date: Mon, 3 Jul 2017 11:08:45 +0100	[thread overview]
Message-ID: <98563df5-d18b-c80b-4326-445524ee4e6b@intel.com> (raw)
In-Reply-To: <1498937402-25547-8-git-send-email-rasesh.mody@cavium.com>

On 7/1/2017 8:30 PM, Rasesh Mody wrote:
> Add missing check for VNI field while adding unicast filter.

Can you please document the result of not having vni field? And if this
is fixing an error, can you please use fixes syntax?

> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
>  drivers/net/qede/qede_ethdev.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index ad264ba..a0616a4 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -571,6 +571,7 @@ static void qede_set_cmn_tunn_param(struct ecore_tunnel_info *p_tunn,
>  		SLIST_FOREACH(tmp, &qdev->uc_list_head, list) {
>  			if ((memcmp(mac_addr, &tmp->mac,
>  				    ETHER_ADDR_LEN) == 0) &&
> +			     ucast->vni == tmp->vni &&
>  			     ucast->vlan == tmp->vlan) {
>  				DP_ERR(edev, "Unicast MAC is already added"
>  				       " with vlan = %u, vni = %u\n",
> 

  reply	other threads:[~2017-07-03 10:08 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29  9:51 [PATCH 0/9] net/qede: update PMD to 2.5.1.1 Rasesh Mody
2017-06-29  9:51 ` [PATCH 1/9] net/qede: fix DMA memory leak Rasesh Mody
2017-06-29  9:51 ` [PATCH 2/9] net/qede: add notifying HW errors Rasesh Mody
2017-06-29  9:51 ` [PATCH 3/9] net/qede: limit ring size to 32k Rasesh Mody
2017-06-29  9:51 ` [PATCH 4/9] net/qede: comments traces and format changes Rasesh Mody
2017-06-29  9:51 ` [PATCH 5/9] net/qede: change debug verbosity of PMD messages Rasesh Mody
2017-06-29  9:51 ` [PATCH 6/9] net/qede: set mdump flag Rasesh Mody
2017-06-29  9:51 ` [PATCH 7/9] net/qede: add missing check for VNI Rasesh Mody
2017-06-29  9:51 ` [PATCH 8/9] net/qede: use newer packet mbuf allocate API Rasesh Mody
2017-06-29 12:55   ` Ferruh Yigit
2017-07-01 19:34     ` Mody, Rasesh
2017-06-29  9:51 ` [PATCH 9/9] net/qede: update PMD version to 2.5.1.1 Rasesh Mody
2017-06-29 12:16 ` [PATCH 0/9] net/qede: update PMD " Ferruh Yigit
2017-07-01 19:29 ` [PATCH v2 0/8] " Rasesh Mody
2017-07-05 10:01   ` Ferruh Yigit
2017-07-08 18:35     ` Mody, Rasesh
2017-07-01 19:29 ` [PATCH v2 1/8] net/qede: fix DMA memory leak Rasesh Mody
2017-07-01 19:29 ` [PATCH v2 2/8] net/qede: add notifying HW errors Rasesh Mody
2017-07-01 19:29 ` [PATCH v2 3/8] net/qede: limit ring size to 32k Rasesh Mody
2017-07-01 19:29 ` [PATCH v2 4/8] net/qede: comments traces and format changes Rasesh Mody
2017-07-01 19:29 ` [PATCH v2 5/8] net/qede: change debug verbosity of PMD messages Rasesh Mody
2017-07-01 19:30 ` [PATCH v2 6/8] net/qede: set mdump flag Rasesh Mody
2017-07-01 19:30 ` [PATCH v2 7/8] net/qede: add missing check for VNI Rasesh Mody
2017-07-03 10:08   ` Ferruh Yigit [this message]
2017-07-01 19:30 ` [PATCH v2 8/8] net/qede: update PMD version to 2.5.1.1 Rasesh Mody
2017-07-03 10:06   ` Ferruh Yigit
2017-07-05  9:57     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98563df5-d18b-c80b-4326-445524ee4e6b@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Dept-EngDPDKDev@cavium.com \
    --cc=dev@dpdk.org \
    --cc=rasesh.mody@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.