From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74DA0C001B0 for ; Fri, 7 Jul 2023 08:22:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232927AbjGGIWR (ORCPT ); Fri, 7 Jul 2023 04:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232233AbjGGIWK (ORCPT ); Fri, 7 Jul 2023 04:22:10 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B49F21FF1; Fri, 7 Jul 2023 01:21:51 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id BF36F6606FD3; Fri, 7 Jul 2023 09:21:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688718110; bh=E41kLsUu9KWKlC5LC4u8U6BQ7Fu/d8kPchT+f2mdTcg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FphWqH25Mc2WAJGfSzoYhws3XtSXrrcmI2pHqjVdOciw9Q1lrmq7BtzX/okmNbqV/ RRvvEkttjgWIosiuI8KMP3s+8SSqAJy0CcNJSCda9+3DfnZEnqf8cCnC4opRbTIqT4 14Nd0cvEJrL7nSRHk/xNSqQfSM3PupT5YI5Wb9iyX13fTWPZ29MYH5VCdHoB0GEzzT 33/rT1ctI83dpr9WNOaWhhOS+LwOSAEZx5X60GacxGRrkl9kWulWAgF0ctVkpQ0SMz SFLdzQZd5pmsFxXsKQcd2odFmbQTZdwuw108WHskDzsHIhwIzjwFPi7ljALspfyGEb TAmgsUiyR0DQQ== Message-ID: <98580052-492e-5360-fcae-f5a5f8a3da73@collabora.com> Date: Fri, 7 Jul 2023 10:21:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 4/6] thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , Chen-Yu Tsai , Alexandre Mergnat , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-5-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230706153823.201943-5-nfraprado@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 06/07/23 17:37, Nícolas F. R. A. Prado ha scritto: > Out of the many interrupts supported by the hardware, the only ones of > interest to the driver currently are: > * The temperature went over the high offset threshold, for any of the > sensors > * The temperature went below the low offset threshold, for any of the > sensors > * The temperature went over the stage3 threshold > > These are the only thresholds configured by the driver through the > OFFSETH, OFFSETL, and PROTTC registers, respectively. > > The current interrupt mask in LVTS_MONINT_CONF, enables many more > interrupts, including data ready on sensors for both filtered and > immediate mode. These are not only not handled by the driver, but they > are also triggered too often, causing unneeded overhead. Disable these > unnecessary interrupts. > > The meaning of each bit can be seen in the comment describing > LVTS_MONINTST in the IRQ handler. > > Fixes: f5f633b18234 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver") > Signed-off-by: Nícolas F. R. A. Prado > Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D140BC001B0 for ; Fri, 7 Jul 2023 08:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cEWiMFZ4erhaxda6x95ngb0IpWvBtAdfk/3Qdd+I4f4=; b=J0MzXPUZ3g1VfF wkEOGCyK+7sYgBP5By6GzsB62SC4DJEsgJqRBZFV3isgGufvbwbKHjb77mjClltYueuVlr0ijdz+Q qCRQmbFiF2u38xWQ9RftS1upr9oZeJdTZCo0qiWrW6WsjmxrCvUkKNV5qPodfqsw6ypxgmx/yNYQK +/ZTZ1x3Ev70EJiCe81Q6hadeLMkt1tqrKaA4MM3PXowI/M9y5spdW0T4pDh0fBz8j69expTxq7xb sabna9FY+JHqVOY2bC5F2YyYM5/b6H2VDF5DjoPW+uZDBAJXqKSN/pEy4L7dxSaTEze6u1NaQd2BD JddVE096Zeqvb2pBYnbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHgix-003yeM-0G; Fri, 07 Jul 2023 08:21:55 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHgit-003ycx-2s; Fri, 07 Jul 2023 08:21:53 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id BF36F6606FD3; Fri, 7 Jul 2023 09:21:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688718110; bh=E41kLsUu9KWKlC5LC4u8U6BQ7Fu/d8kPchT+f2mdTcg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FphWqH25Mc2WAJGfSzoYhws3XtSXrrcmI2pHqjVdOciw9Q1lrmq7BtzX/okmNbqV/ RRvvEkttjgWIosiuI8KMP3s+8SSqAJy0CcNJSCda9+3DfnZEnqf8cCnC4opRbTIqT4 14Nd0cvEJrL7nSRHk/xNSqQfSM3PupT5YI5Wb9iyX13fTWPZ29MYH5VCdHoB0GEzzT 33/rT1ctI83dpr9WNOaWhhOS+LwOSAEZx5X60GacxGRrkl9kWulWAgF0ctVkpQ0SMz SFLdzQZd5pmsFxXsKQcd2odFmbQTZdwuw108WHskDzsHIhwIzjwFPi7ljALspfyGEb TAmgsUiyR0DQQ== Message-ID: <98580052-492e-5360-fcae-f5a5f8a3da73@collabora.com> Date: Fri, 7 Jul 2023 10:21:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 4/6] thermal/drivers/mediatek/lvts_thermal: Disable undesired interrupts Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Daniel Lezcano Cc: Alexandre Bailon , Balsam CHIHI , Chen-Yu Tsai , Alexandre Mergnat , kernel@collabora.com, Amit Kucheria , Matthias Brugger , "Rafael J. Wysocki" , Zhang Rui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org References: <20230706153823.201943-1-nfraprado@collabora.com> <20230706153823.201943-5-nfraprado@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230706153823.201943-5-nfraprado@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230707_012152_062058_667C69A8 X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMDYvMDcvMjMgMTc6MzcsIE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIGhhIHNjcml0dG86Cj4g T3V0IG9mIHRoZSBtYW55IGludGVycnVwdHMgc3VwcG9ydGVkIGJ5IHRoZSBoYXJkd2FyZSwgdGhl IG9ubHkgb25lcyBvZgo+IGludGVyZXN0IHRvIHRoZSBkcml2ZXIgY3VycmVudGx5IGFyZToKPiAq IFRoZSB0ZW1wZXJhdHVyZSB3ZW50IG92ZXIgdGhlIGhpZ2ggb2Zmc2V0IHRocmVzaG9sZCwgZm9y IGFueSBvZiB0aGUKPiAgICBzZW5zb3JzCj4gKiBUaGUgdGVtcGVyYXR1cmUgd2VudCBiZWxvdyB0 aGUgbG93IG9mZnNldCB0aHJlc2hvbGQsIGZvciBhbnkgb2YgdGhlCj4gICAgc2Vuc29ycwo+ICog VGhlIHRlbXBlcmF0dXJlIHdlbnQgb3ZlciB0aGUgc3RhZ2UzIHRocmVzaG9sZAo+IAo+IFRoZXNl IGFyZSB0aGUgb25seSB0aHJlc2hvbGRzIGNvbmZpZ3VyZWQgYnkgdGhlIGRyaXZlciB0aHJvdWdo IHRoZQo+IE9GRlNFVEgsIE9GRlNFVEwsIGFuZCBQUk9UVEMgcmVnaXN0ZXJzLCByZXNwZWN0aXZl bHkuCj4gCj4gVGhlIGN1cnJlbnQgaW50ZXJydXB0IG1hc2sgaW4gTFZUU19NT05JTlRfQ09ORiwg ZW5hYmxlcyBtYW55IG1vcmUKPiBpbnRlcnJ1cHRzLCBpbmNsdWRpbmcgZGF0YSByZWFkeSBvbiBz ZW5zb3JzIGZvciBib3RoIGZpbHRlcmVkIGFuZAo+IGltbWVkaWF0ZSBtb2RlLiBUaGVzZSBhcmUg bm90IG9ubHkgbm90IGhhbmRsZWQgYnkgdGhlIGRyaXZlciwgYnV0IHRoZXkKPiBhcmUgYWxzbyB0 cmlnZ2VyZWQgdG9vIG9mdGVuLCBjYXVzaW5nIHVubmVlZGVkIG92ZXJoZWFkLiBEaXNhYmxlIHRo ZXNlCj4gdW5uZWNlc3NhcnkgaW50ZXJydXB0cy4KPiAKPiBUaGUgbWVhbmluZyBvZiBlYWNoIGJp dCBjYW4gYmUgc2VlbiBpbiB0aGUgY29tbWVudCBkZXNjcmliaW5nCj4gTFZUU19NT05JTlRTVCBp biB0aGUgSVJRIGhhbmRsZXIuCj4gCj4gRml4ZXM6IGY1ZjYzM2IxODIzNCAoInRoZXJtYWwvZHJp dmVycy9tZWRpYXRlazogQWRkIHRoZSBMb3cgVm9sdGFnZSBUaGVybWFsIFNlbnNvciBkcml2ZXIi KQo+IFNpZ25lZC1vZmYtYnk6IE7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIDxuZnJhcHJhZG9AY29s bGFib3JhLmNvbT4KPiAKClJldmlld2VkLWJ5OiBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8 YW5nZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xsYWJvcmEuY29tPgoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==