From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B3FEC04AB6 for ; Fri, 31 May 2019 08:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72BE6265FA for ; Fri, 31 May 2019 08:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727057AbfEaIzH (ORCPT ); Fri, 31 May 2019 04:55:07 -0400 Received: from foss.arm.com ([217.140.101.70]:48068 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfEaIzH (ORCPT ); Fri, 31 May 2019 04:55:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB4D0341; Fri, 31 May 2019 01:55:06 -0700 (PDT) Received: from [10.162.42.223] (p8cg001049571a15.blr.arm.com [10.162.42.223]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 18C9D3F59C; Fri, 31 May 2019 01:55:03 -0700 (PDT) Subject: Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault() To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Mark Rutland , James Morse , Andrey Konovalov References: <1559133285-27986-1-git-send-email-anshuman.khandual@arm.com> <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com> <20190530063459.GA2181@infradead.org> From: Anshuman Khandual Message-ID: <985b0d8f-2141-019b-8555-272eafc58ea3@arm.com> Date: Fri, 31 May 2019 14:25:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190530063459.GA2181@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/30/2019 12:04 PM, Christoph Hellwig wrote: > On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: >> __do_page_fault() is over complicated with multiple goto statements. This >> cleans up code flow and while there drops the vm_fault_t argument. > > There is no argument dropped anywhere, just a local variable. > You are right. Will fix both subject line and the commit message. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04733C04AB6 for ; Fri, 31 May 2019 08:55:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC416265FA for ; Fri, 31 May 2019 08:55:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NzSEjKIL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC416265FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A1Fm9UH1W0Ay24M8KN+weRvEIrseQ4o08w2JIbInENs=; b=NzSEjKILSrTTBz AkRlwe2//srPkyJ5OAIFFjP8ZCxzVna+gTQoPIEqy/rlwLN/F3m2IlXdEM0KWvLKtT1DCOE+fWjVP fRLaQ4VsI1AWMu7oiOzkEFrfDBXbGi+IeN8EUwbmCWhDH//Il39TiqG6ziZg2/otSiZZtJ2Ehdi38 pcV/q5shqwqw7DofTlQiN++OCoCwPSKmz+QgLtaCo/4Xh4HIUldNEYBf1AKEWkpTzBgwgq+6ZLvx3 cndVpWt+b8eC6pE8dz/uR7KcclqysMP7+9TI10vL3TBp/EnUE+wod8a7m7q6zR70LGZjV63EcvgXW yi1CKOZQcKuNWVABzUGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWdJe-0002jv-Gb; Fri, 31 May 2019 08:55:10 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWdJb-0002Vm-6U for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 08:55:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB4D0341; Fri, 31 May 2019 01:55:06 -0700 (PDT) Received: from [10.162.42.223] (p8cg001049571a15.blr.arm.com [10.162.42.223]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 18C9D3F59C; Fri, 31 May 2019 01:55:03 -0700 (PDT) Subject: Re: [PATCH 4/4] arm64/mm: Drop vm_fault_t argument from __do_page_fault() To: Christoph Hellwig References: <1559133285-27986-1-git-send-email-anshuman.khandual@arm.com> <1559133285-27986-5-git-send-email-anshuman.khandual@arm.com> <20190530063459.GA2181@infradead.org> From: Anshuman Khandual Message-ID: <985b0d8f-2141-019b-8555-272eafc58ea3@arm.com> Date: Fri, 31 May 2019 14:25:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190530063459.GA2181@infradead.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_015507_251699_E8964F5A X-CRM114-Status: GOOD ( 13.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, James Morse , Andrey Konovalov , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/30/2019 12:04 PM, Christoph Hellwig wrote: > On Wed, May 29, 2019 at 06:04:45PM +0530, Anshuman Khandual wrote: >> __do_page_fault() is over complicated with multiple goto statements. This >> cleans up code flow and while there drops the vm_fault_t argument. > > There is no argument dropped anywhere, just a local variable. > You are right. Will fix both subject line and the commit message. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel