All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@dilger.ca>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compat: remove compat_printk
Date: Wed, 22 Jun 2016 11:09:28 -0600	[thread overview]
Message-ID: <98637B71-BE33-431B-8A91-A0F8C335654B@dilger.ca> (raw)
In-Reply-To: <32739965.DkybxvdJlf@wuerfel>

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]


> On Jun 22, 2016, at 4:15 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> On Tuesday, June 21, 2016 4:38:57 PM CEST Andrew Morton wrote:
>>> @@ -1077,15 +1076,6 @@ static struct ctl_table kern_table[] = {
>>>              .extra1         = &neg_one,
>>>      },
>>> #endif
>>> -#ifdef CONFIG_COMPAT
>>> -     {
>>> -             .procname       = "compat-log",
>>> -             .data           = &compat_log,
>>> -             .maxlen         = sizeof (int),
>>> -             .mode           = 0644,
>>> -             .proc_handler   = proc_dointvec,
>>> -     },
>>> -#endif
>> 
>> How do we know we can simply remove /proc/sys/kernel/compat-log without
>> breaking any userspace?
>> 
> 
> Good point. I guess we can leave this in place just in case (with a comment)
> and just remove the compat_printk function. We could probably have a Kconfig
> symbol for obsolete sysctl files, but if this is the only one controlled
> by it, it's probably not worth the effort.

It probably makes sense to print a deprecation warning containing the current
process name if this /proc file is modified, so that users can update any
scripts/tools using it.

Cheers, Andreas






[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2016-06-22 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 14:26 Arnd Bergmann
2016-06-21 23:38 ` Andrew Morton
2016-06-22 10:15   ` Arnd Bergmann
2016-06-22 17:09     ` Andreas Dilger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98637B71-BE33-431B-8A91-A0F8C335654B@dilger.ca \
    --to=adilger@dilger.ca \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH] compat: remove compat_printk' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.