All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Don Zickus <dzickus@redhat.com>, "Huang, Ying" <ying.huang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] pstore: change mutex locking to spin_locks
Date: Thu, 21 Jul 2011 10:57:28 -0700	[thread overview]
Message-ID: <987664A83D2D224EAE907B061CE93D5301E9EC9DC6@orsmsx505.amr.corp.intel.com> (raw)
In-Reply-To: <20110721122731.GV3765@redhat.com>

> > Is it safe to call pstore_mkfile with IRQ disabled?
> > 
> > pstore_mkfile -> d_alloc_name -> d_alloc -> kmem_cache_alloc(, GFP_KERNEL).
>
> Don't know.  But would that mean we would have to put the pstore_mkfile
> on a workqueue then or something similar?

That might be a good idea anyway.  In the "oops" case we'd like the file
to appear in the pstore filesystem if the system stayed healthy despite
the oops[1]. There isn't any reason why the pstore entry must appear instantly.
Delaying the creation would avoid running into problems related to the
oops.

-Tony

[1] So we can remove it to free pstore backend space - if we didn't die
from the oops, then the oops is going to be in /var/log/messages.

  reply	other threads:[~2011-07-21 17:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20 20:56 [PATCH] pstore: change mutex locking to spin_locks Don Zickus
2011-07-21  0:40 ` Huang Ying
2011-07-21 12:27   ` Don Zickus
2011-07-21 17:57     ` Luck, Tony [this message]
2011-07-22  0:33       ` Huang Ying
2011-07-22 12:13         ` Don Zickus
2011-07-22 13:03           ` huang ying
2011-07-22 22:39           ` Luck, Tony
2011-07-22 23:21             ` Tony Luck
2011-07-25 12:47               ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=987664A83D2D224EAE907B061CE93D5301E9EC9DC6@orsmsx505.amr.corp.intel.com \
    --to=tony.luck@intel.com \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.