From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD23C433DF for ; Sun, 23 Aug 2020 02:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFE4E2072D for ; Sun, 23 Aug 2020 02:49:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PE7FzAPR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbgHWCtb (ORCPT ); Sat, 22 Aug 2020 22:49:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:24235 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbgHWCta (ORCPT ); Sat, 22 Aug 2020 22:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598150969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TE0Zpj1FO1fCF2Nzd7hXL6TqjYYA4mP9yp1lb4isM3o=; b=PE7FzAPRK5gVl3krnskUvDTlMAMVO9oqCGehoZoPeZeK91NkBCF9IQn0YFHlGF6wl/0x5t kvAaBT5kbmhAmyL6L8Uj1TKu7EVchcmPg5d8LJ6O0cVI9FIi/Nn5vgyHGDLHymJ0NSndPZ jqFCb+aB/W27/VEKVzo7/R8npXeqiQc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-bJphY9BWNqKZtumUMnw_PA-1; Sat, 22 Aug 2020 22:49:27 -0400 X-MC-Unique: bJphY9BWNqKZtumUMnw_PA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 126901074658; Sun, 23 Aug 2020 02:49:25 +0000 (UTC) Received: from llong.remote.csb (ovpn-112-211.rdu2.redhat.com [10.10.112.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id CFF076E715; Sun, 23 Aug 2020 02:49:19 +0000 (UTC) Subject: Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control To: Chris Down , peterz@infradead.org Cc: Michal Hocko , Andrew Morton , Johannes Weiner , Vladimir Davydov , Jonathan Corbet , Alexey Dobriyan , Ingo Molnar , Juri Lelli , Vincent Guittot , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org References: <20200817140831.30260-1-longman@redhat.com> <20200818091453.GL2674@hirez.programming.kicks-ass.net> <20200818092617.GN28270@dhcp22.suse.cz> <20200818095910.GM2674@hirez.programming.kicks-ass.net> <20200818101756.GA155582@chrisdown.name> From: Waiman Long Organization: Red Hat Message-ID: <989570d6-639e-6385-d638-c4729665c2e4@redhat.com> Date: Sat, 22 Aug 2020 22:49:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200818101756.GA155582@chrisdown.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/20 6:17 AM, Chris Down wrote: > peterz@infradead.org writes: >> But then how can it run-away like Waiman suggested? > > Probably because he's not running with that commit at all. We and > others use this to prevent runaway allocation on a huge range of > production and desktop use cases and it works just fine. > >> /me goes look... and finds MEMCG_MAX_HIGH_DELAY_JIFFIES. >> >> That's a fail... :-( > > I'd ask that you understand a bit more about the tradeoffs and > intentions of the patch before rushing in to declare its failure, > considering it works just fine :-) > > Clamping the maximal time allows the application to take some action > to remediate the situation, while still being slowed down > significantly. 2 seconds per allocation batch is still absolutely > plenty for any use case I've come across. If you have evidence it > isn't, then present that instead of vague notions of "wrongness". > Sorry for the late reply. I ran some test on the latest kernel and and it seems to work as expected. I was running the test on an older kernel that doesn't have this patch and I was not aware of it before hand. Sorry for the confusion. Cheers, Longman From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [RFC PATCH 0/8] memcg: Enable fine-grained per process memory control Date: Sat, 22 Aug 2020 22:49:19 -0400 Message-ID: <989570d6-639e-6385-d638-c4729665c2e4@redhat.com> References: <20200817140831.30260-1-longman@redhat.com> <20200818091453.GL2674@hirez.programming.kicks-ass.net> <20200818092617.GN28270@dhcp22.suse.cz> <20200818095910.GM2674@hirez.programming.kicks-ass.net> <20200818101756.GA155582@chrisdown.name> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598150971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TE0Zpj1FO1fCF2Nzd7hXL6TqjYYA4mP9yp1lb4isM3o=; b=JM5MxWv2runwv2RZGRyMKLt3iwn7rfxIb1bA4/ig6Z8sl4dQ2Rpm3AU4j9laospM+cNkBl xGALO70hsHC2IkWrCO1TyDdLiQ4EAmIbOBnuPtXTiUqBMaDxeWFHlUflUq5Jyf5p2OhvlA HlTRu3CGURoP/sq6tI19z0rbSsmAHXc= In-Reply-To: <20200818101756.GA155582-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org> Content-Language: en-US Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Chris Down , peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org Cc: Michal Hocko , Andrew Morton , Johannes Weiner , Vladimir Davydov , Jonathan Corbet , Alexey Dobriyan , Ingo Molnar , Juri Lelli , Vincent Guittot , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org On 8/18/20 6:17 AM, Chris Down wrote: > peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org writes: >> But then how can it run-away like Waiman suggested? > > Probably because he's not running with that commit at all. We and > others use this to prevent runaway allocation on a huge range of > production and desktop use cases and it works just fine. > >> /me goes look... and finds MEMCG_MAX_HIGH_DELAY_JIFFIES. >> >> That's a fail... :-( > > I'd ask that you understand a bit more about the tradeoffs and > intentions of the patch before rushing in to declare its failure, > considering it works just fine :-) > > Clamping the maximal time allows the application to take some action > to remediate the situation, while still being slowed down > significantly. 2 seconds per allocation batch is still absolutely > plenty for any use case I've come across. If you have evidence it > isn't, then present that instead of vague notions of "wrongness". > Sorry for the late reply. I ran some test on the latest kernel and and it seems to work as expected. I was running the test on an older kernel that doesn't have this patch and I was not aware of it before hand. Sorry for the confusion. Cheers, Longman