From: zhanglianjie <zhanglianjie@uniontech.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] syscalls/readdir21: Convert to new API
Date: Fri, 8 Oct 2021 20:42:28 +0800 [thread overview]
Message-ID: <9895d2c0-82a1-833f-c920-b57d1757a7dc@uniontech.com> (raw)
In-Reply-To: <YV7f8yhhvy7L9YIX@yuki>
Hi,
On 2021-10-07 19:54, Cyril Hrubis wrote:
> On Wed, Sep 29, 2021 at 04:32:49PM +0800, zhanglianjie wrote:
>> Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
>> -static struct test_case_t {
>> +static struct tcase {
>> unsigned int *fd;
>> struct old_linux_dirent *dirp;
>> unsigned int count;
>> int exp_errno;
>> -} test_cases[] = {
>> +} tcases[] = {
>> {&del_dir_fd, &dirp, sizeof(struct old_linux_dirent), ENOENT},
>> {&file_fd, &dirp, sizeof(struct old_linux_dirent), ENOTDIR},
>> {&invalid_fd, &dirp, sizeof(struct old_linux_dirent), EBADF},
>> -#if !defined(UCLINUX)
>> {&dir_fd, (struct old_linux_dirent *)-1,
>> sizeof(struct old_linux_dirent), EFAULT},
>> -#endif
>> };
>
> I guess that we also miss EINVAL error here with invalid count.
>
The count here is not used, there is no way to test EINVAL.
--
Regards,
Zhang Lianjie
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-10-08 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 8:32 [LTP] [PATCH 1/2] syscalls/readdir01: Convert to new API zhanglianjie
2021-09-29 8:32 ` [LTP] [PATCH 2/2] syscalls/readdir21: " zhanglianjie
2021-10-07 11:54 ` Cyril Hrubis
2021-10-08 12:42 ` zhanglianjie [this message]
2021-10-08 14:43 ` Cyril Hrubis
2021-10-07 11:35 ` [LTP] [PATCH 1/2] syscalls/readdir01: " Cyril Hrubis
2021-10-08 12:37 ` zhanglianjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9895d2c0-82a1-833f-c920-b57d1757a7dc@uniontech.com \
--to=zhanglianjie@uniontech.com \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.