From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C9F7C4BA12 for ; Wed, 26 Feb 2020 11:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D553520637 for ; Wed, 26 Feb 2020 11:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728318AbgBZLel (ORCPT ); Wed, 26 Feb 2020 06:34:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:49984 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728278AbgBZLel (ORCPT ); Wed, 26 Feb 2020 06:34:41 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E02ADAF3F; Wed, 26 Feb 2020 11:34:39 +0000 (UTC) Subject: Re: [PATCH 1/3] mm/vma: Move VM_NO_KHUGEPAGED into generic header To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <1582692658-3294-1-git-send-email-anshuman.khandual@arm.com> <1582692658-3294-2-git-send-email-anshuman.khandual@arm.com> From: Vlastimil Babka Message-ID: <9899b82b-1295-97de-27da-a0a20dbe1a60@suse.cz> Date: Wed, 26 Feb 2020 12:34:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1582692658-3294-2-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/26/20 5:50 AM, Anshuman Khandual wrote: > Move VM_NO_KHUGEPAGED into generic header (include/linux/mm.h). This just > makes sure that no VMA flag is scattered in individual function files any > longer. While at this, fix an old comment which is no longer valid. > > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > include/linux/mm.h | 3 ++- > mm/khugepaged.c | 2 -- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 52269e56c514..6f7e400e6ea3 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -287,6 +287,8 @@ extern unsigned int kobjsize(const void *objp); > #define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this vma */ > #define VM_MERGEABLE 0x80000000 /* KSM may merge identical pages */ > > +#define VM_NO_KHUGEPAGED (VM_SPECIAL | VM_HUGETLB) While the preprocessor doesn't mind that VM_SPECIAL is only defined later, I would have moved this below VM_SPECIAL definition anyway, where it fits better, and add a comment like other defines there do?