From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF67C3A5A5 for ; Tue, 3 Sep 2019 06:35:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0428022CF8 for ; Tue, 3 Sep 2019 06:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="T4gCAoHB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727260AbfICGfD (ORCPT ); Tue, 3 Sep 2019 02:35:03 -0400 Received: from mo4-p02-ob.smtp.rzone.de ([85.215.255.81]:19826 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbfICGfC (ORCPT ); Tue, 3 Sep 2019 02:35:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1567492500; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=rpoqHO2EPNF4RDRrZEMr4EzlWpw+Y76OHWQL/9f/0RE=; b=T4gCAoHBWzFGKh4+TL6C3Yz5WhZ3eIPQkw4Y2RRpxPDHiYkUaSE6k7uA+YuPf5ronh CFR/qdAOVY08JPALsSHE/gOFLk8hqlmzgj9XcC74nbe7kxsYqez6kOJAur95uJ562fZ3 QOAfdbEV2x+75VTDiZOsnDdZ9grb2gUpOUiURTNdDYfd8wTFJCzgpM6Cr6PcpjIeK4CM MnNZ6PRze30hpIxZxE81JIMTKscdmtzUX1XUSBhH73upUhYkBjZODDQsTDAXCRmeNpz2 gnGS5WVjAiS/YZisfQiH34Pwuob2JEIL5lSVvZ/N/k2q8r+y+O4GD+1lOxYWkdm9pbEd k2qw== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Qpw97WFDlWfXA4ONfA=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 44.27.0 DYNA|AUTH) with ESMTPSA id u036f9v836YpUt0 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Tue, 3 Sep 2019 08:34:51 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [RFC 4/5] ARM: dts: omap3-n950-n9: remove opp-v1 table From: "H. Nikolaus Schaller" In-Reply-To: <20190903062808.p6jkgwylyqxcjs4z@vireshk-i7> Date: Tue, 3 Sep 2019 08:34:50 +0200 Cc: =?utf-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Rob Herring , Adam Ford , =?utf-8?Q?Andr=C3=A9_Roth?= , Mark Rutland , "Rafael J. Wysocki" , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Content-Transfer-Encoding: quoted-printable Message-Id: <98AF4586-C6FF-43A5-99B9-797145F50D07@goldelico.com> References: <2f978667c1533e46e3a5df58871e9048f3eb74e9.1567421751.git.hns@goldelico.com> <20190903023635.44yf32jowpm3hgfp@vireshk-i7> <8BC1AEC9-7B24-4C07-8659-16741D018164@goldelico.com> <20190903061403.k3d333f54gj2kuxi@vireshk-i7> <6B7B0EDB-8A60-48A0-AFAB-8A266358300C@goldelico.com> <20190903062808.p6jkgwylyqxcjs4z@vireshk-i7> To: Viresh Kumar X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 03.09.2019 um 08:28 schrieb Viresh Kumar : >=20 > On 03-09-19, 08:23, H. Nikolaus Schaller wrote: >>=20 >>> Am 03.09.2019 um 08:14 schrieb Viresh Kumar = : >>>=20 >>> On 03-09-19, 08:01, H. Nikolaus Schaller wrote: >>>>=20 >>>>> Am 03.09.2019 um 04:36 schrieb Viresh Kumar = : >>>>>=20 >>>>> On 02-09-19, 12:55, H. Nikolaus Schaller wrote: >>>>>> With opp-v2 in omap36xx.dtsi and ti-cpufreq driver the >>>>>> 1GHz capability is automatically detected. >>>>>>=20 >>>>>> Signed-off-by: H. Nikolaus Schaller >>>>>> --- >>>>>> arch/arm/boot/dts/omap3-n950-n9.dtsi | 7 ------- >>>>>> 1 file changed, 7 deletions(-) >>>>>>=20 >>>>>> diff --git a/arch/arm/boot/dts/omap3-n950-n9.dtsi = b/arch/arm/boot/dts/omap3-n950-n9.dtsi >>>>>> index 5441e9ffdbb4..e98b0c615f19 100644 >>>>>> --- a/arch/arm/boot/dts/omap3-n950-n9.dtsi >>>>>> +++ b/arch/arm/boot/dts/omap3-n950-n9.dtsi >>>>>> @@ -11,13 +11,6 @@ >>>>>> cpus { >>>>>> cpu@0 { >>>>>> cpu0-supply =3D <&vcc>; >>>>>> - operating-points =3D < >>>>>> - /* kHz uV */ >>>>>> - 300000 1012500 >>>>>> - 600000 1200000 >>>>>> - 800000 1325000 >>>>>> - 1000000 1375000 >>>>>> - >; >>>>>> }; >>>>>> }; >>>>>=20 >>>>> This should be merged with 2/5 ? >>>>=20 >>>> Well, it bloats 2/5. >>>=20 >>> It is logically the right place to do this as that's where we are >>> adding opp-v2. >>=20 >> Well, sometimes the philosophy of patches is to add something new >> first and remove the old in a second separate patch if the system >> can live with both. This makes it easier to digest single patches >> (because they are smaller) and might also better pinpoint an issue >> by bisect. >=20 > Right, but you already removed some of the opp-v1 stuff in patch 2/5. > Why leave this one out ? >=20 >>>=20 >>>> What I hope (I can't test) is that this opp-v1 table >>>> is ignored if an opp-v2 table exists. So that it can be >>>> removed by a separate follow-up patch. >>>=20 >>> It should work as that's what we are doing in OPP core, but I still >>> feel this better get merged with 2/5. >>=20 >> Ok, I see. Noted for RFCv2. >>=20 >> There will also be a big batch of changes for the compatible record >> (omap3530->omap35xx, add omap34xx where needed) of ca. 10 board = definition >> DTS files. Should this then also become part of the new 2/5? >=20 > Compatible thing should be separate patch anyway, I was just talking > about replacing opp-v1 with v2. Ok, understood. BR and thanks, Nikolaus