From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6C85AC48BC4
	for <dpdk-dev@archiver.kernel.org>; Wed, 14 Feb 2024 10:49:58 +0000 (UTC)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8504240A7A;
	Wed, 14 Feb 2024 11:49:57 +0100 (CET)
Received: from dkmailrelay1.smartsharesystems.com
 (smartserver.smartsharesystems.com [77.243.40.215])
 by mails.dpdk.org (Postfix) with ESMTP id E9A5840263
 for <dev@dpdk.org>; Wed, 14 Feb 2024 11:49:55 +0100 (CET)
Received: from smartserver.smartsharesystems.com
 (smartserver.smartsharesys.local [192.168.4.10])
 by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id AE4242011D;
 Wed, 14 Feb 2024 11:49:55 +0100 (CET)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Subject: RE: [PATCH v3] RFC deprecate RTE_MARKER in struct rte_mbuf
X-MimeOLE: Produced By Microsoft Exchange V6.5
Date: Wed, 14 Feb 2024 11:49:52 +0100
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35E9F217@smartserver.smartshare.dk>
In-Reply-To: <1707867209-1901-1-git-send-email-roretzla@linux.microsoft.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [PATCH v3] RFC deprecate RTE_MARKER in struct rte_mbuf
Thread-Index: Adpe1Q/qi1GqlIyrQzyzyHwudwhm9gAXjZfw
References: <1706657173-26166-2-git-send-email-roretzla@linux.microsoft.com>
 <1707867209-1901-1-git-send-email-roretzla@linux.microsoft.com>
From: =?iso-8859-1?Q?Morten_Br=F8rup?= <mb@smartsharesystems.com>
To: "Tyler Retzlaff" <roretzla@linux.microsoft.com>,
	<dev@dpdk.org>
Cc: "Andrew Boyer" <andrew.boyer@amd.com>,
 "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
 "Bruce Richardson" <bruce.richardson@intel.com>,
 "Chenbo Xia" <chenbox@nvidia.com>,
 "Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
 "Maxime Coquelin" <maxime.coquelin@redhat.com>
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

> From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com]
> Sent: Wednesday, 14 February 2024 00.33
>=20
> Here is the latest iteration of the proposed change to allow struct
> rte_mbuf
> to be consumed by MSVC.
>=20
> * Introduce an internal __rte_marker macro conditionally expanded for
> MSVC
>   vs existing users of the struct. At some point we can uncomment
> __rte_deprecated
>   to assist migration away from the current marker fields for
> applications
>   after appropriate announcement periods etc..
>=20
> * Introduce anonymous unions to allow aliasing of the previous named
>   offsets by a *new* name.  The intention would be to convert the dpdk
> tree
>   to use the new names along with this change and enable
> __rte_deprecated
>   for dpdk builds (not applications) to avoid accidental re-
> introduction.
>=20
> * The anonymous unions are now also used to pad cacheline0 and
> cacheline1 instead
>   of __rte_cache_min_aligned.

ACK. This design also seems reusable for similar structures.